Page MenuHomePhabricator

michalt (Michal Terepeta)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2021, 11:15 PM (10 w, 3 d)

Recent Activity

Dec 14 2021

michalt requested review of D115744: [mlir][Vector] Support 0-D vectors in ShuffleOp.
Dec 14 2021, 10:24 AM · Restricted Project
michalt requested review of D115743: [mlir][Vector] Support 0-D vectors in TransposeOp.
Dec 14 2021, 10:23 AM · Restricted Project
michalt requested review of D115742: [mlir][Vector] Support 0-D vectors in FMAOp.
Dec 14 2021, 10:23 AM · Restricted Project

Dec 12 2021

michalt added a comment to D115220: [mlir][Vector] Support 0-D vectors in `CmpIOp`.

Fixing test.

Dec 12 2021, 7:17 AM · Restricted Project

Dec 11 2021

michalt added a comment to D115220: [mlir][Vector] Support 0-D vectors in `CmpIOp`.

Thanks for the review! Could you land this? (I don't have commit access)

Dec 11 2021, 10:27 PM · Restricted Project
michalt added a comment to D115221: [mlir][Vector] Support 0-D vectors in `CreateMaskOp`.

Thanks for the review! Could I ask you to also land this? (I don't have commit access)

Dec 11 2021, 10:27 PM · Restricted Project

Dec 7 2021

michalt updated the diff for D115221: [mlir][Vector] Support 0-D vectors in `CreateMaskOp`.

Rebase and address comments

Dec 7 2021, 11:15 PM · Restricted Project
michalt updated the diff for D115220: [mlir][Vector] Support 0-D vectors in `CmpIOp`.

Rebase and address comments

Dec 7 2021, 11:06 PM · Restricted Project

Dec 6 2021

michalt requested review of D115221: [mlir][Vector] Support 0-D vectors in `CreateMaskOp`.
Dec 6 2021, 10:47 PM · Restricted Project
michalt requested review of D115220: [mlir][Vector] Support 0-D vectors in `CmpIOp`.
Dec 6 2021, 10:46 PM · Restricted Project

Dec 4 2021

michalt added inline comments to D115023: [mlir][Vector] Support 0-D vectors in `ConstantMaskOp`.
Dec 4 2021, 10:45 PM · Restricted Project
michalt updated the diff for D115023: [mlir][Vector] Support 0-D vectors in `ConstantMaskOp`.

Address review comments

Dec 4 2021, 10:44 PM · Restricted Project

Dec 2 2021

michalt requested review of D115023: [mlir][Vector] Support 0-D vectors in `ConstantMaskOp`.
Dec 2 2021, 10:29 PM · Restricted Project

Dec 1 2021

michalt requested review of D114854: [mlir][Vector] Support 0-D vectors in `BitCastOp`.
Dec 1 2021, 12:57 AM · Restricted Project
michalt requested review of D114853: [mlir][Vector] Add some missing tests for `broadcast` and `splat`.
Dec 1 2021, 12:54 AM · Restricted Project

Nov 26 2021

michalt updated the diff for D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp`.

Rebase

Nov 26 2021, 9:15 AM · Restricted Project
michalt added a comment to D114598: [mlir][Standard] Support 0-D vectors in `SplatOp`.

Thanks a lot for the review! I've rebased both changes, so hopefully everything works now. :)

Nov 26 2021, 8:22 AM · Restricted Project
michalt updated the diff for D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp`.

Rebase

Nov 26 2021, 8:21 AM · Restricted Project
michalt updated the diff for D114598: [mlir][Standard] Support 0-D vectors in `SplatOp`.

Rebase

Nov 26 2021, 8:19 AM · Restricted Project

Nov 25 2021

michalt updated the summary of D114598: [mlir][Standard] Support 0-D vectors in `SplatOp`.
Nov 25 2021, 7:46 AM · Restricted Project
michalt retitled D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp` from [mlir][Vector] Support 0-D vectors in `BroadcastOp`/`SplatOp` to [mlir][Vector] Support 0-D vectors in `BroadcastOp`.
Nov 25 2021, 7:45 AM · Restricted Project
michalt updated the summary of D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp`.
Nov 25 2021, 7:44 AM · Restricted Project
michalt updated the diff for D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp`.

Address review comments

Nov 25 2021, 7:36 AM · Restricted Project
michalt requested review of D114598: [mlir][Standard] Support 0-D vectors in `SplatOp`.
Nov 25 2021, 7:35 AM · Restricted Project
michalt updated the diff for D114549: [mlir][Vector] Support 0-D vectors in `VectorPrintOpConversion`.

Address review comments

Nov 25 2021, 7:34 AM · Restricted Project

Nov 24 2021

michalt retitled D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp` from [mlir][Vector] Support 0-D vectors in `BroadcastOp` to [mlir][Vector] Support 0-D vectors in `BroadcastOp`/`SplatOp`.
Nov 24 2021, 11:57 AM · Restricted Project
michalt requested review of D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp`.
Nov 24 2021, 10:51 AM · Restricted Project
michalt requested review of D114549: [mlir][Vector] Support 0-D vectors in `VectorPrintOpConversion`.
Nov 24 2021, 10:50 AM · Restricted Project

Nov 17 2021

michalt added a comment to D113855: [mlir][Python] Fix generation of accessors for Optional.

Something went wrong and now the diff contains only the whitespace changes. If you made them as two separate git commits, please indicate the two-commit range when updating the revision or squash them.

Nov 17 2021, 10:09 PM · Restricted Project
michalt updated the diff for D113855: [mlir][Python] Fix generation of accessors for Optional.

Correctly export the whatespace fix to Phab

Nov 17 2021, 10:06 PM · Restricted Project
michalt requested review of D114086: [mlir][Vector] First step for 0D vector type.
Nov 17 2021, 6:31 AM · Restricted Project

Nov 16 2021

michalt added a comment to D113855: [mlir][Python] Fix generation of accessors for Optional.

Thanks for the fix! Please let me know if you need help landing this.

Nov 16 2021, 10:04 PM · Restricted Project
michalt updated the diff for D113855: [mlir][Python] Fix generation of accessors for Optional.

Fix whitespace

Nov 16 2021, 10:01 PM · Restricted Project

Nov 15 2021

michalt added a comment to D113854: [mlir][Vector] Minor formatting fixes in Vector.md.

Thanks @michalt !
Do you have commit access or should I land this for you?

Nov 15 2021, 10:30 AM · Restricted Project

Nov 14 2021

michalt published D113855: [mlir][Python] Fix generation of accessors for Optional for review.

This is the first time I'm trying to do anything non-trivial with MLIR, so any feedback is very welcome (especially if I misunderstood/missed something :) Thanks!

Nov 14 2021, 11:08 AM · Restricted Project
michalt published D113854: [mlir][Vector] Minor formatting fixes in Vector.md for review.
Nov 14 2021, 10:52 AM · Restricted Project