Page MenuHomePhabricator

[NFC] move GNUELFDumper::printEnum() into a common header for reuse.
ClosedPublic

Authored by Esme on Nov 30 2021, 8:19 PM.

Details

Summary

This is a NFC patch moving the GNUELFDumper<ELFT>::printEnum() function from ELFDumper into ScopedPrinter.h for reuse.

Diff Detail

Event Timeline

Esme created this revision.Nov 30 2021, 8:19 PM
Esme requested review of this revision.Nov 30 2021, 8:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2021, 8:19 PM
jhenderson accepted this revision.Dec 2 2021, 12:46 AM

Looks good! I originally wondered about this, as the behaviour doesn't seem really related to ScopedPrinter, but the EnumEntry class is defined in the same function, so I think this is the right place for it. Could you take a look at D114684 and see if there are any additional unit tests that could be added whilst you're doing this? (I'm thinking it would be good to add some, but could be a separate patch, depending on the order in which that and this patch land).

This revision is now accepted and ready to land.Dec 2 2021, 12:46 AM