add the xcoff symbol size for the llvm-nm.

[DiggerLin]

Summary

add the xcoff symbol size for the llvm-nm.

[jhenderson]

The testing for this patch really needs to be dramatically simplified - I can't tell if there's anything important about the various different symbols present in the size.test output, for the purposes of that test.

@Esme, what's missing from yaml2obj to be able to do this test? How soon do you think you could add it?

[DiggerLin]

In D113104#3108282, @jhenderson wrote:

The testing for this patch really needs to be dramatically simplified - I can't tell if there's anything important about the various different symbols present in the size.test output, for the purposes of that test.

@Esme, what's missing from yaml2obj to be able to do this test? How soon do you think you could add it?

the symbol size also need csect auxiliary entry of symbol.

and I just re_use the same object file "test_gcc.o" in the basic.test

[DiggerLin]

reduce test case

[jhenderson]

llvm/test/tools/llvm-nm/XCOFF/size.test

18–23

I think it would be sufficient to only test a couple of symbols that have different sizes. You can leave out the others.

24

Why's this line here?

[DiggerLin]

simplify the test case.

llvm/test/tools/llvm-nm/XCOFF/size.test

18–23

I will simple the test case.
It will test the size of label, TC entry, Section Description (both for function and data).

24

thanks

[jhenderson]

llvm/test/tools/llvm-nm/XCOFF/size.test

18

There's a trailing space on this line, I think.

18–23

I'd explicitly highlight why you are specifying the specific symbols then in the test, by expanding the initial comment.

[DiggerLin]

using yaml2obj for test cases

[jhenderson]

As noted in the other llvm-nm patch, I'll be offline from the end of today until the 4th of January, and won't be able to respond to anything in that time.

llvm/test/tools/llvm-nm/XCOFF/size.test

3–5

Similar comment to the basic.test test case: move these comments to near the CHECK point, and add trailing full stops (sorry for not thinking about this earlier - now that this is written here, it's clear to me they belong elsewhere in the file).

7–8

As in other test cases, don't use --docnum with only one input, and don't use --check-prefix with only one set of CHECK lines.

14–20

Remove excessive spacing. Do you need the Address: 0x0 line?

[DiggerLin]

llvm/test/tools/llvm-nm/XCOFF/size.test

14–20

the yaml2obj will default to 0x0 if not specific the address.

[jhenderson]

llvm/test/tools/llvm-nm/XCOFF/size.test

14–20

Right, so if the default is 0x0, why do you need to specify an explicit 0x0?

48

You can delete "Size of a" from each of these comments. Just "Label symbol." etc is sufficient.

[DiggerLin]

llvm/test/tools/llvm-nm/XCOFF/size.test

14–20

sorry, I misunderstand your comment , fix it.

48

thanks

[jhenderson]

LGTM!

llvm/test/tools/llvm-nm/XCOFF/size.test

+## Test llvm-nm for XCOFF object files with --print-size option.
+
+# RUN: yaml2obj %s -o %t.o
+# RUN: llvm-nm  --print-size %t.o | FileCheck --match-full-lines %s
+
+--- !XCOFF
+FileHeader:
+  MagicNumber:    0x1DF
+Sections:
+  - Name:         .text
+    Flags:        [ STYP_TEXT ]
+  - Name:         .data
+    Flags:        [ STYP_DATA ]
+  - Name:         .bss
+    Flags:        [ STYP_BSS ]
+Symbols:
+  - Name:            ._ZL5func0v
+    Section:         .text
+    StorageClass:    C_EXT
+    Type:            0x20
+    AuxEntries:
+     - Type:                   AUX_CSECT
+       SymbolAlignmentAndType: 0x02
+       StorageMappingClass:    XMC_PR
+  - Name:            val
+    Value:           0x200
+    Section:         .data
+    StorageClass:    C_EXT
+    Type:            0x20
+    AuxEntries:
+     - Type:                   AUX_CSECT
+       SymbolAlignmentAndType: 0x01
+       StorageMappingClass:    XMC_RW
+       SectionOrLength:        0x8
+  - Name:            comval
+    Section:         .bss
+    Value:           0x13C
+    StorageClass:    C_EXT
+    Type:            0x00
+    AuxEntries:
+     - Type:                   AUX_CSECT
+       SymbolAlignmentAndType: 0x03
+       StorageMappingClass:    XMC_RW
+       SectionOrLength:        0x4
+
+## Label symbol.
+# CHECK:      00000000 00000000 T ._ZL5func0v
+## Common symbol.
+# CHECK-NEXT: 0000013c 00000004 C comval
+## SD symbol.
+# CHECK-NEXT: 00000200 00000008 D val

llvm/tools/llvm-nm/llvm-nm.cpp

for (BasicSymbolRef Sym : Symbols) {
       // see if this symbol is a symbol from that section and if not skip it.
       if (Nsect && Nsect != getNsectInMachO(*MachO, Sym))
         continue;
       NMSymbol S = {};
       S.Size = 0;
       S.Address = 0;
       if (isa<ELFObjectFileBase>(&Obj))
         S.Size = ELFSymbolRef(Sym).getSize();
+
+      if (const XCOFFObjectFile *XCOFFObj =
+              dyn_cast<const XCOFFObjectFile>(&Obj))
+        S.Size = XCOFFObj->getSymbolSize(Sym.getRawDataRefImpl());
+
       if (PrintAddress && isa<ObjectFile>(Obj)) {
         SymbolRef SymRef(Sym);
         Expected<uint64_t> AddressOrErr = SymRef.getAddress();
         if (!AddressOrErr) {
           consumeError(AddressOrErr.takeError());
           break;
         }
         S.Address = *AddressOrErr;