Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td | ||
---|---|---|
21 | This is what will show up on the website, I think we need a more extensive doc here, to set up the context and also linking to the other existing docs. |
mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.h | ||
---|---|---|
386 ↗ | (On Diff #389572) | This should probably not be part of this change. |
Thank you for cleaning this up. Just some nits and please address the comments others already had.
I would be OK with improving documentation in a follow up, just to avoid merge conflicts and rebase.
mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp | ||
---|---|---|
186 | This comment is now off. | |
269 | This is not dim of cast but dim of ToMemref. | |
mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ComprehensiveBufferize.cpp | ||
938–939 | nit: variable name | |
948–949 | nit: variable name. |
mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td | ||
---|---|---|
21 | Good point, also updated the names of the ops in Bufferization.md and BufferDeallocationInternals.md |
LGTM for the sparse part (there are some dangling references in the doc now to "memref" but since this is submitted, I will fix that in a follow up).
This is what will show up on the website, I think we need a more extensive doc here, to set up the context and also linking to the other existing docs.