Page MenuHomePhabricator

[X86][FP16] Replace vXi16 to vXf16 instead of v8f16
AcceptedPublic

Authored by pengfei on Fri, Nov 19, 6:59 PM.

Details

Summary

Fixes pr52561

Diff Detail

Event Timeline

pengfei created this revision.Fri, Nov 19, 6:59 PM
pengfei requested review of this revision.Fri, Nov 19, 6:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 19, 6:59 PM

Which of the patterns that you changed is actually causing the crash and is it possible to create a test case for the other?

LuoYuanke accepted this revision.EditedSat, Nov 27, 9:56 PM

LGTM, pls address Simon's comments.

This revision is now accepted and ready to land.Sat, Nov 27, 9:56 PM

Which of the patterns that you changed is actually causing the crash and is it possible to create a test case for the other?

The pattern is MaskVT == MVT::v16i16 and Mask = {0, -2, -2, ..., -2}. It matches the conditions in line 36273 and 36274. I tried several times but failed to generate Mask = {0, -1, -1, ..., -1} to match the condition in line 36220.
The conditions in line 36221 and 36222 are only avaliable for MaskVT == MVT::v8i16. So I didn't create another test cast.

LGTM, pls address Simon's comments.

Thanks!