[LLDB][NativePDB] Fix image lookup by address

[zequanwu]

Summary

image lookup -a doesn't work because the compilands list is always empty.
Create CU at given index if doesn't exit.

[labath]

lldb/test/Shell/SymbolFile/NativePDB/lookup-by-address.cpp

9

These fancy shell operations don't usually work on windows (which is pretty unfortunate, given this is a windows format).

Since the test executable will literally contain just the main function, maybe we could just pass a /base:BASE argument to the linker, and rely on the fact that the linker will place the function at BASE+0x1000 ?

[zequanwu]

Use /base:0x400000 in test case.

[labath]

lldb/test/Shell/SymbolFile/NativePDB/lookup-by-address.cpp

12

[stella.stamenova]

I think this broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12036

[zequanwu]

In D113821#3133324, @stella.stamenova wrote:

I think this broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12036

Thanks, hopefully this will fix it: rGb6d35352304601925bc1c055106949d2e27b3975

lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp

uint32_t SymbolFileNativePDB::ResolveSymbolContext(
   std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
   uint32_t resolved_flags = 0;
   lldb::addr_t file_addr = addr.GetFileAddress();
 
   if (NeedsResolvedCompileUnit(resolve_scope)) {
     llvm::Optional<uint16_t> modi = m_index->GetModuleIndexForVa(file_addr);
     if (!modi)
       return 0;
-    CompilandIndexItem *cci = m_index->compilands().GetCompiland(*modi);
-    if (!cci)
+    CompUnitSP cu_sp = GetCompileUnitAtIndex(modi.getValue());
+    if (!cu_sp)
       return 0;
 
-    sc.comp_unit = GetOrCreateCompileUnit(*cci).get();
+    sc.comp_unit = cu_sp.get();
     resolved_flags |= eSymbolContextCompUnit;
   }
 
   if (resolve_scope & eSymbolContextFunction ||
       resolve_scope & eSymbolContextBlock) {
     lldbassert(sc.comp_unit);
     std::vector<SymbolAndUid> matches = m_index->FindSymbolsByVa(file_addr);
     // Search the matches in reverse.  This way if there are multiple matches

lldb/test/Shell/SymbolFile/NativePDB/lookup-by-address.cpp

+// clang-format off
+// REQUIRES: lld, x86
+
+// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -GR- -c /Fo%t.obj -- %s
+// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -base:0x400000 -out:%t.exe -pdb:%t.pdb
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -O "target create %t.exe" -o "image lookup -a 0x401000" -o "exit" | FileCheck %s --check-prefix=ADDRESS
+int main(int argc, char **argv) {
+  return 0;
+}
+
+// ADDRESS: image lookup -a 0x401000
+// ADDRESS: Address: lookup-by-address.cpp.tmp.exe[0x{{[0]+}}401000] (lookup-by-address.cpp.tmp.exe..text
+// ADDRESS: Summary: lookup-by-address.cpp.tmp.exe`main at lookup-by-address.cpp:7