This is an archive of the discontinued LLVM Phabricator instance.

	Show First 20 Lines • Show All 528 Lines • ▼ Show 20 Lines

	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	// CFRetain/CFRelease/CFMakeCollectable/CFAutorelease checking for null arguments.			// CFRetain/CFRelease/CFMakeCollectable/CFAutorelease checking for null arguments.
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//

	namespace {			namespace {
	class CFRetainReleaseChecker : public Checker<check::PreCall> {			class CFRetainReleaseChecker : public Checker<check::PreCall> {
	mutable APIMisuse BT{this, "null passed to CF memory management function"};			mutable APIMisuse BT{this, "null passed to CF memory management function"};
	CallDescription CFRetain{"CFRetain", 1},			const CallDescriptionSet ModelledCalls = {
	CFRelease{"CFRelease", 1},			{"CFRetain", 1},
	CFMakeCollectable{"CFMakeCollectable", 1},			{"CFRelease", 1},
	CFAutorelease{"CFAutorelease", 1};			{"CFMakeCollectable", 1},
				{"CFAutorelease", 1},
				};

	public:			public:
	void checkPreCall(const CallEvent &Call, CheckerContext &C) const;			void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
	};			};
	} // end anonymous namespace			} // end anonymous namespace

	void CFRetainReleaseChecker::checkPreCall(const CallEvent &Call,			void CFRetainReleaseChecker::checkPreCall(const CallEvent &Call,
	CheckerContext &C) const {			CheckerContext &C) const {
	// TODO: Make this check part of CallDescription.			// TODO: Make this check part of CallDescription.
	if (!Call.isGlobalCFunction())			if (!Call.isGlobalCFunction())
	return;			return;

	// Check if we called CFRetain/CFRelease/CFMakeCollectable/CFAutorelease.			// Check if we called CFRetain/CFRelease/CFMakeCollectable/CFAutorelease.
				if (!ModelledCalls.contains(Call))
	if (!matchesAny(Call, CFRetain, CFRelease, CFMakeCollectable, CFAutorelease))
	return;			return;

	// Get the argument's value.			// Get the argument's value.
	SVal ArgVal = Call.getArgSVal(0);			SVal ArgVal = Call.getArgSVal(0);
	Optional<DefinedSVal> DefArgVal = ArgVal.getAs<DefinedSVal>();			Optional<DefinedSVal> DefArgVal = ArgVal.getAs<DefinedSVal>();
	if (!DefArgVal)			if (!DefArgVal)
	return;			return;

	▲ Show 20 Lines • Show All 733 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[analyzer][NFC] Demonstrate the use of CallDescriptionSetClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 388430

clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp

[analyzer][NFC] Demonstrate the use of CallDescriptionSet
ClosedPublic