Paths

Table of Contentst

[analyzer][NFC] Separate CallDescription from CallEvent
ClosedPublic
Actions

Authored by steakhal on Nov 10 2021, 10:45 AM.

Details

Reviewers

NoQ
martong
Szelethus
ASDenysPetrov
balazske
xazax.hun

Commits

rG0b9d3a6e53e6: [analyzer][NFC] Separate CallDescription from CallEvent

Summary

CallDescriptions deserve its own translation unit.
This patch simply moves the corresponding parts.
Also includes the CallDescription.h where it's necessary.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

steakhal created this revision.Nov 10 2021, 10:45 AM

Herald added subscribers: manas, dkrupp, donat.nagy and 8 others. · View Herald TranscriptNov 10 2021, 10:45 AM

steakhal requested review of this revision.Nov 10 2021, 10:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2021, 10:45 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

steakhal added a child revision: D113588: [analyzer][NFC] Make the API of CallDescription safer slightly.Nov 10 2021, 10:46 AM

Harbormaster completed remote builds in B133527: Diff 386233.Nov 10 2021, 12:00 PM

What a nice stack of patches! :)
LGTM!

This revision is now accepted and ready to land.Nov 12 2021, 8:37 AM

xazax.hun accepted this revision.Nov 12 2021, 9:33 AM

Szelethus accepted this revision.Nov 15 2021, 2:49 AM

Closed by commit rG0b9d3a6e53e6: [analyzer][NFC] Separate CallDescription from CallEvent (authored by steakhal). · Explain WhyNov 15 2021, 10:11 AM

This revision was automatically updated to reflect the committed changes.

steakhal added a commit: rG0b9d3a6e53e6: [analyzer][NFC] Separate CallDescription from CallEvent.

Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2021, 10:11 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

clang/

include/

clang/

StaticAnalyzer/

Core/

PathSensitive/

CallDescription.h

121 lines

CallEvent.h

104 lines

lib/

StaticAnalyzer/

Checkers/

BasicObjCFoundationChecks.cpp

3 lines

BlockInCriticalSectionChecker.cpp

1 line

CStringChecker.cpp

1 line

CastValueChecker.cpp

1 line

ChrootChecker.cpp

1 line

ContainerModeling.cpp

3 lines

DebugContainerModeling.cpp

1 line

DebugIteratorModeling.cpp

1 line

InnerPointerChecker.cpp

3 lines

IteratorModeling.cpp

3 lines

IteratorRangeChecker.cpp

2 lines

MIGChecker.cpp

1 line

MallocChecker.cpp

1 line

MmapWriteExecChecker.cpp

1 line

PthreadLockChecker.cpp

1 line

ReturnValueChecker.cpp

1 line

STLAlgorithmModeling.cpp

1 line

SimpleStreamChecker.cpp

1 line

1 line

1 line

1 line

1 line

cert/

InvalidPtrChecker.cpp

1 line

PutenvWithAutoChecker.cpp

1 line

Core/

CMakeLists.txt

1 line

CallDescription.cpp

48 lines

CallEvent.cpp

1 line

unittests/

StaticAnalyzer/

BugReportInterestingnessTest.cpp

1 line

CallDescriptionTest.cpp

1 line

ConflictingEvalCallsTest.cpp

1 line

FalsePositiveRefutationBRVisitorTest.cpp

1 line

NoStateChangeFuncVisitorTest.cpp

1 line

llvm/

utils/

gn/

secondary/

clang/

lib/

StaticAnalyzer/

Core/

BUILD.gn

1 line

Diff 387315

View Options

clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h

View Options

clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h

View Options

clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/ChrootChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/DebugContainerModeling.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/DebugIteratorModeling.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/SimpleStreamChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/StringChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp

View Options

clang/lib/StaticAnalyzer/Checkers/cert/PutenvWithAutoChecker.cpp

View Options

clang/lib/StaticAnalyzer/Core/CMakeLists.txt

View Options

clang/lib/StaticAnalyzer/Core/CallDescription.cpp

View Options

clang/lib/StaticAnalyzer/Core/CallEvent.cpp

View Options

clang/unittests/StaticAnalyzer/BugReportInterestingnessTest.cpp

View Options

clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp

View Options

clang/unittests/StaticAnalyzer/ConflictingEvalCallsTest.cpp

View Options

clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp

View Options

clang/unittests/StaticAnalyzer/NoStateChangeFuncVisitorTest.cpp

View Options

llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Core/BUILD.gn

[analyzer][NFC] Separate CallDescription from CallEventClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 387315

clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h

clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h

clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp

clang/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp

clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp

clang/lib/StaticAnalyzer/Checkers/ChrootChecker.cpp

clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

clang/lib/StaticAnalyzer/Checkers/DebugContainerModeling.cpp

clang/lib/StaticAnalyzer/Checkers/DebugIteratorModeling.cpp

clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp

clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp

clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp

clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp

clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

clang/lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp

clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp

clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp

clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp

clang/lib/StaticAnalyzer/Checkers/SimpleStreamChecker.cpp

clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

clang/lib/StaticAnalyzer/Checkers/StringChecker.cpp

clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp

clang/lib/StaticAnalyzer/Checkers/cert/PutenvWithAutoChecker.cpp

clang/lib/StaticAnalyzer/Core/CMakeLists.txt

clang/lib/StaticAnalyzer/Core/CallDescription.cpp

clang/lib/StaticAnalyzer/Core/CallEvent.cpp

clang/unittests/StaticAnalyzer/BugReportInterestingnessTest.cpp

clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp

clang/unittests/StaticAnalyzer/ConflictingEvalCallsTest.cpp

clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp

clang/unittests/StaticAnalyzer/NoStateChangeFuncVisitorTest.cpp

llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Core/BUILD.gn

[analyzer][NFC] Separate CallDescription from CallEvent
ClosedPublic
Actions

Revision Contents
Changeset List