Page MenuHomePhabricator

[analyzer][NFC] Use enum for CallDescription flags
ClosedPublic

Authored by steakhal on Wed, Nov 10, 10:46 AM.

Details

Summary

Yeah, let's prefer a slightly stronger type representing this.

Diff Detail

Event Timeline

steakhal created this revision.Wed, Nov 10, 10:46 AM

According to my comparative measurement, the whole change stack did not introduce any space and time overhead to the baseline. No reports changed. No crashes were introduced.
I tested about 12 projects or so.

xazax.hun accepted this revision.Fri, Nov 12, 9:32 AM
This revision is now accepted and ready to land.Fri, Nov 12, 9:32 AM
martong added inline comments.Thu, Nov 18, 9:33 AM
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h
38

The comment above is off now as that should go for CDF_MaybeBuiltin.
Also could you please add a menaningful comment for what CDF_None represents?

steakhal updated this revision to Diff 388434.Fri, Nov 19, 2:12 AM
steakhal marked an inline comment as done.
  • move the CDF_None above the comment block
steakhal added inline comments.Fri, Nov 19, 2:13 AM
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h
38

FIxed by now. Although I'm not sure we need to elaborate none.

martong accepted this revision.Fri, Nov 19, 2:59 AM

LGTM

This revision was landed with ongoing or failed builds.Fri, Nov 19, 9:33 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 19, 9:33 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript