Page MenuHomePhabricator

[RISCV][NFC] Refactor some rvv instructions' definition with foreach.
ClosedPublic

Authored by jacquesguan on Mon, Nov 8, 7:18 PM.

Details

Summary

Simplify rvv instructions that use eew in their mnemonic and encoding with
foreach.

Diff Detail

Event Timeline

jacquesguan created this revision.Mon, Nov 8, 7:18 PM
jacquesguan requested review of this revision.Mon, Nov 8, 7:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 8, 7:18 PM
frasercrmck added inline comments.Thu, Nov 11, 6:45 AM
llvm/lib/Target/RISCV/RISCVInstrInfoV.td
859

This part is changing from VLSSched<32> to VLSSched<64>. I assume that 32 is a bug?

jacquesguan added inline comments.Thu, Nov 11, 5:55 PM
llvm/lib/Target/RISCV/RISCVInstrInfoV.td
859

Yes, I think so.

This revision is now accepted and ready to land.Mon, Nov 15, 9:31 AM
jrtc27 added inline comments.Mon, Nov 15, 9:32 AM
llvm/lib/Target/RISCV/RISCVInstrInfoV.td
859

Drop the [NFC] from the commit subject then, as it's not true

859

(and explicitly mention this functional change in the body)

frasercrmck added inline comments.Mon, Nov 15, 9:33 AM
llvm/lib/Target/RISCV/RISCVInstrInfoV.td
859

Ah yes good catch. I agree.

Remove [NFC] and add commit information.