We already have patterns for fptosi and fptoui plus fmul to fixed point convert, this adds equivalent patterns for fptosi.sat and fptoui.sat, which should apply equally well for the legal saturating variants.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AArch64/AArch64InstrInfo.td | ||
---|---|---|
3772 | Do we need to predicate this rule and the next on HasFullFP16? |
llvm/lib/Target/AArch64/AArch64InstrInfo.td | ||
---|---|---|
3772 | Hmm. We haven't for any of the others here above or below. I don't think the nodes will be legal if we don't have fullfp16 - so they will never be possible to match against. I can add them if you think that's cleaner. |
llvm/lib/Target/AArch64/AArch64InstrInfo.td | ||
---|---|---|
3772 | So yeah, there's definitely some inconsistency here. Other rewrite rules, but indeed not around here, do have it predicated on fullfp16. I am not sure to be honest, but it looks cleaner to me (although I of course agree that the nodes won't be matched if fullfp16 isn't enabled). |
Do we need to predicate this rule and the next on HasFullFP16?