This is an archive of the discontinued LLVM Phabricator instance.

Differential D113140

[OpenMP][NFCI] Introduce the kernel environment for target regions
AbandonedPublic

Authored by jdoerfert on Nov 3 2021, 1:14 PM.

Details

Reviewers
jhuber6
ggeorgakoudis
tianshilei1992
JonChesterfield
sstefan1
baziotis
Summary

This introduces the kernel environment which contains information passed
by the compiler to a GPU kernel. For now it just encapsulated the
ident_t object that we passed explicitly before but we will add more
content, including mutable content, later on.

Diff Detail

Event Timeline

jdoerfert created this revision.Nov 3 2021, 1:14 PM
Herald added subscribers: asavonic, guansong, bollu and 4 others. · View Herald TranscriptNov 3 2021, 1:14 PM
jdoerfert requested review of this revision.Nov 3 2021, 1:14 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 3 2021, 1:14 PM
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B132316: Diff 384566.Nov 3 2021, 1:15 PM
jdoerfert updated this revision to Diff 386343.Nov 10 2021, 4:09 PM

Move more values into the kernel environment (and configuration environment), update tests

Herald added a reviewer: sstefan1. · View Herald TranscriptNov 10 2021, 4:09 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, ormris, okura and 3 others. · View Herald Transcript
Harbormaster completed remote builds in B133611: Diff 386343.Nov 10 2021, 4:10 PM
ye-luo added a subscriber: ye-luo.Nov 10 2021, 4:34 PM

the kernel environment which contains information passed by the compiler to a GPU kernel.

DId you mean this environment is baked into kernel at compile time? So there is no additional H2D cost at each call, right?

jdoerfert added a comment.Nov 10 2021, 10:19 PM
In D113140#3123162, @ye-luo wrote:

the kernel environment which contains information passed by the compiler to a GPU kernel.

DId you mean this environment is baked into kernel at compile time? So there is no additional H2D cost at each call, right?

Yes, this environment is a constant fed into the kernel at compile time.
It will allow us to pass more information, e.g., if you want to support sequentialiazed parallel regions, in a way that caused the "feature" to be removed during compilation.
It also allows us to communicate dynamic information in a way that will make us pay for it only if we "enable" it, e.g., if you don't want printf support on AMDGPU you don't have to pay for a buffer.

jdoerfert abandoned this revision.Jan 9 2022, 7:16 PM

Split up, main content starts with D116908.

Large Diff

This large diff affects 184 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
test/
OpenMP/
4 lines
10 lines
1 line
1 line
1 line
1 line
1 line
1 line
1 line
748 lines
2832 lines
592 lines
1984 lines
568 lines
204 lines
1 line
384 lines
352 lines
408 lines
208 lines
1 line
1 line
1 line
1 line
124 lines
6 lines
12 lines
126 lines
96 lines
24 lines
18 lines
28 lines
6 lines
96 lines
48 lines
48 lines
12 lines
126 lines
24 lines
16 lines
42 lines
18 lines
96 lines
24 lines
48 lines
16 lines
40 lines
120 lines
1 line
527 lines
39 lines
1 line
2 lines
1 line
56 lines
1 line
1 line
5 lines
1 line
1 line
1 line
1 line
1 line
135 lines
1 line
1 line
36 lines
71 lines
171 lines
28 lines
36 lines
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
416 lines
600 lines
1680 lines
1106 lines
2912 lines
728 lines
886 lines
204 lines
388 lines
1 line
1 line
1 line
1 line
84 lines
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
352 lines
552 lines
1608 lines
588 lines
2832 lines
592 lines
928 lines
468 lines
204 lines
388 lines
1 line
1 line
336 lines
288 lines
352 lines
288 lines
208 lines
1 line
1 line
1598 lines
68 lines
llvm/
include/
llvm/
Frontend/
OpenMP/
33 lines
37 lines
7 lines
6 lines
11 lines
lib/
Frontend/
OpenMP/
69 lines
Transforms/
IPO/
9 lines
295 lines
test/
Transforms/
OpenMP/
39 lines
241 lines
19 lines
2 lines
2 lines
16 lines
68 lines
46 lines
22 lines
13 lines
101 lines
71 lines
356 lines
25 lines
41 lines
12 lines
185 lines
20 lines
41 lines
17 lines
utils/
2 lines
llvm/
include/
llvm/
Frontend/
OpenMP/
openmp/
libomptarget/
include/
25 lines
Environment.h
DeviceEnvironment.h
25 lines
4 lines
openmp/
libomptarget/
DeviceRTL/
2 lines
include/
6 lines
6 lines
src/
2 lines
10 lines
30 lines
13 lines
deviceRTLs/
amdgcn/
2 lines
common/
src/
40 lines
4 lines
8 lines
7 lines
nvptx/
2 lines
2 lines
include/
2 lines
plugins/
1 line
amdgpu/
src/
4 lines
cuda/
src/
9 lines
src/
6 lines
tools/
deviceinfo/
2 lines

Diff 386343

clang/test/OpenMP/amdgcn_target_codegen.cpp

clang/test/OpenMP/declare_target_codegen_globalization.cpp

clang/test/OpenMP/distribute_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_private_codegen.cpp

clang/test/OpenMP/distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_private_codegen.cpp

clang/test/OpenMP/distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/for_firstprivate_codegen.cpp

clang/test/OpenMP/for_lastprivate_codegen.cpp

clang/test/OpenMP/for_linear_codegen.cpp

clang/test/OpenMP/for_private_codegen.cpp

clang/test/OpenMP/nvptx_SPMD_codegen.cpp

clang/test/OpenMP/nvptx_data_sharing.cpp

clang/test/OpenMP/nvptx_distribute_parallel_generic_mode_codegen.cpp

clang/test/OpenMP/nvptx_force_full_runtime_SPMD_codegen.cpp

clang/test/OpenMP/nvptx_lambda_capturing.cpp

clang/test/OpenMP/nvptx_multi_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_nested_parallel_codegen.cpp

clang/test/OpenMP/nvptx_parallel_codegen.cpp

clang/test/OpenMP/nvptx_parallel_for_codegen.cpp

clang/test/OpenMP/nvptx_target_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_num_threads_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp

clang/test/OpenMP/nvptx_target_printf_codegen.c

clang/test/OpenMP/nvptx_target_simd_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_generic_mode_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_simd_codegen.cpp

clang/test/OpenMP/nvptx_teams_codegen.cpp

clang/test/OpenMP/nvptx_teams_reduction_codegen.cpp

clang/test/OpenMP/openmp_win_codegen.cpp

clang/test/OpenMP/parallel_codegen.cpp

clang/test/OpenMP/parallel_copyin_codegen.cpp

clang/test/OpenMP/parallel_firstprivate_codegen.cpp

clang/test/OpenMP/parallel_for_codegen.cpp

clang/test/OpenMP/parallel_for_linear_codegen.cpp

clang/test/OpenMP/parallel_for_simd_aligned_codegen.cpp

clang/test/OpenMP/parallel_master_codegen.cpp

clang/test/OpenMP/parallel_private_codegen.cpp

clang/test/OpenMP/parallel_reduction_codegen.cpp

clang/test/OpenMP/parallel_sections_codegen.cpp

clang/test/OpenMP/sections_firstprivate_codegen.cpp

clang/test/OpenMP/sections_lastprivate_codegen.cpp

clang/test/OpenMP/sections_private_codegen.cpp

clang/test/OpenMP/sections_reduction_codegen.cpp

clang/test/OpenMP/single_codegen.cpp

clang/test/OpenMP/single_firstprivate_codegen.cpp

clang/test/OpenMP/single_private_codegen.cpp

clang/test/OpenMP/target_data_map_codegen_hold.cpp

clang/test/OpenMP/target_globals_codegen.cpp

clang/test/OpenMP/target_map_codegen_hold.cpp

clang/test/OpenMP/target_parallel_debug_codegen.cpp

clang/test/OpenMP/target_parallel_for_debug_codegen.cpp

clang/test/OpenMP/target_teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/target_teams_num_teams_codegen.cpp

clang/test/OpenMP/target_teams_thread_limit_codegen.cpp

clang/test/OpenMP/taskgroup_codegen.cpp

clang/test/OpenMP/teams_codegen.cpp

clang/test/OpenMP/teams_distribute_codegen.cpp

clang/test/OpenMP/teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_copyin_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_private_codegen.cpp

clang/test/OpenMP/teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_firstprivate_codegen.cpp

clang/test/OpenMP/teams_private_codegen.cpp

clang/test/OpenMP/threadprivate_codegen.cpp

clang/test/OpenMP/tile_codegen.cpp

llvm/include/llvm/Frontend/OpenMP/ConfigurationEnvironment.h

llvm/include/llvm/Frontend/OpenMP/DeviceEnvironment.h

llvm/include/llvm/Frontend/OpenMP/Environment.h

llvm/include/llvm/Frontend/OpenMP/KernelEnvironment.h

llvm/include/llvm/Frontend/OpenMP/OMPConstants.h

llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h

llvm/include/llvm/Frontend/OpenMP/OMPKinds.def

llvm/include/llvm/Frontend/OpenMP/SourceInfo.h

llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

llvm/lib/Transforms/IPO/OpenMPOpt.cpp

llvm/test/Transforms/OpenMP/always_inline_device.ll

llvm/test/Transforms/OpenMP/custom_state_machines.ll

llvm/test/Transforms/OpenMP/custom_state_machines_remarks.ll

llvm/test/Transforms/OpenMP/deduplication.ll

llvm/test/Transforms/OpenMP/deduplication_remarks.ll

llvm/test/Transforms/OpenMP/deduplication_target.ll

llvm/test/Transforms/OpenMP/fold_generic_main_thread.ll

llvm/test/Transforms/OpenMP/get_hardware_num_threads_in_block_fold.ll

llvm/test/Transforms/OpenMP/global_constructor.ll

llvm/test/Transforms/OpenMP/gpu_state_machine_function_ptr_replacement.ll

llvm/test/Transforms/OpenMP/is_spmd_exec_mode_fold.ll

llvm/test/Transforms/OpenMP/parallel_level_fold.ll

llvm/test/Transforms/OpenMP/parallel_region_merging.ll

llvm/test/Transforms/OpenMP/remove_globalization.ll

llvm/test/Transforms/OpenMP/replace_globalization.ll

llvm/test/Transforms/OpenMP/single_threaded_execution.ll

llvm/test/Transforms/OpenMP/spmdization.ll

llvm/test/Transforms/OpenMP/spmdization_assumes.ll

llvm/test/Transforms/OpenMP/spmdization_guarding.ll

llvm/test/Transforms/OpenMP/spmdization_remarks.ll

llvm/utils/update_cc_test_checks.py

openmp/libomptarget/DeviceRTL/CMakeLists.txt

openmp/libomptarget/DeviceRTL/include/Interface.h

openmp/libomptarget/DeviceRTL/include/State.h

openmp/libomptarget/DeviceRTL/src/Configuration.cpp

openmp/libomptarget/DeviceRTL/src/Debug.cpp

openmp/libomptarget/DeviceRTL/src/Kernel.cpp

openmp/libomptarget/DeviceRTL/src/State.cpp

openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt

openmp/libomptarget/deviceRTLs/common/src/omptarget.cu

openmp/libomptarget/deviceRTLs/common/src/support.cu

openmp/libomptarget/deviceRTLs/common/support.h

openmp/libomptarget/deviceRTLs/interface.h

openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt

openmp/libomptarget/deviceRTLs/target_interface.h

openmp/libomptarget/include/DeviceEnvironment.h

openmp/libomptarget/include/SourceInfo.h

openmp/libomptarget/include/omptarget.h

openmp/libomptarget/plugins/CMakeLists.txt

openmp/libomptarget/plugins/amdgpu/src/rtl.cpp

openmp/libomptarget/plugins/cuda/src/rtl.cpp

openmp/libomptarget/src/private.h

openmp/libomptarget/tools/deviceinfo/CMakeLists.txt