Page MenuHomePhabricator

[WIP][Attributor] Look through indirect calls
Needs ReviewPublic

Authored by jdoerfert on Oct 21 2021, 7:12 PM.

Details

Summary

Through the new Attributor::checkForAllCallees we can look through
indirect calls and visit all potential callees.

NOTE: This is a work in progress patch without much testing.

Diff Detail

Event Timeline

jdoerfert created this revision.Oct 21 2021, 7:12 PM
jdoerfert requested review of this revision.Oct 21 2021, 7:12 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added inline comments.Oct 21 2021, 7:22 PM
llvm/lib/Transforms/IPO/Attributor.cpp
1015

Why the compare to 1 for a bool?

jdoerfert added inline comments.Oct 21 2021, 9:37 PM
llvm/lib/Transforms/IPO/Attributor.cpp
1015

If we have more than 1 potential callee we don't know if it is a "must" callee anymore. I haven't thought enough about this to be sure we need or don't need it but there is the possibility we want to distinguish callees that may be called here from the one that certainly is.