Page MenuHomePhabricator

[mlir] Expand prefixing to OpFormatGen
ClosedPublic

Authored by jpienaar on Oct 19 2021, 8:12 PM.

Details

Summary

Follow up to also use the prefixed emitters in OpFormatGen (moved
getGetterName(s) and getSetterName(s) to Operator as that is most
convenient usage wise even though it just depends on Dialect). Prefix
accessors in Test dialect and follow up on missed changes in
OpDefinitionsGen.

Diff Detail

Event Timeline

jpienaar created this revision.Oct 19 2021, 8:12 PM
jpienaar requested review of this revision.Oct 19 2021, 8:12 PM
rriddle accepted this revision.Oct 19 2021, 8:48 PM
rriddle added inline comments.
mlir/lib/TableGen/Operator.cpp
674–675

Debugging?

676

Can you add a parameter comment for the true here?

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
2489–2494
This revision is now accepted and ready to land.Oct 19 2021, 8:48 PM
This revision was automatically updated to reflect the committed changes.
jpienaar marked 3 inline comments as done.