Page MenuHomePhabricator

[DebugInfo] Expand ability to load 2-byte addresses in dwarf sections
ClosedPublic

Authored by jackoalan on Oct 16 2021, 2:35 PM.

Details

Summary

Some dwarf loaders in LLVM are hard-coded to only accept 4-byte and 8-byte address sizes. This patch generalizes acceptance into DWARFContext::isAddressSizeSupported and provides a common way to generate rejection errors.

The MSP430 target has been given new tests to cover dwarf loading cases that previously failed due to 2-byte addresses.

Diff Detail

Event Timeline

jackoalan created this revision.Oct 16 2021, 2:35 PM
jackoalan requested review of this revision.Oct 16 2021, 2:35 PM
Herald added a project: Restricted Project. · View Herald Transcript
jackoalan updated this revision to Diff 380218.Oct 16 2021, 3:11 PM

Fix patch format

dblaikie accepted this revision.Oct 21 2021, 1:58 PM
dblaikie added a subscriber: dblaikie.

Looks great, thanks!

This revision is now accepted and ready to land.Oct 21 2021, 1:58 PM

Thank you for the feedback! Would you mind committing this? --author="Jack Andersen <jackoalan@gmail.com>"