Page MenuHomePhabricator

jackoalan (Jack Andersen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2016, 4:19 PM (266 w, 2 d)

Recent Activity

Yesterday

jackoalan committed rGf108c7f59dfa: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues. (authored by jackoalan).
[GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Sun, Dec 5, 12:57 PM
jackoalan closed D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Sun, Dec 5, 12:56 PM · Restricted Project
jackoalan committed rGb66339575a9b: [CMake] Installable find modules for terminfo and libffi (authored by jackoalan).
[CMake] Installable find modules for terminfo and libffi
Sun, Dec 5, 11:48 AM
jackoalan closed D114327: [CMake] Installable find modules for terminfo and libffi.
Sun, Dec 5, 11:48 AM · Restricted Project
jackoalan committed rG296ebeb808a7: Test commit to check access. (authored by jackoalan).
Test commit to check access.
Sun, Dec 5, 11:36 AM

Fri, Dec 3

jackoalan added a comment to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Thanks everyone for the comments. May I have somebody commit this for me?
--author="Jack Andersen <jackoalan@gmail.com>"

Fri, Dec 3, 7:12 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Change TracksDebugUserValues comment per review request

Fri, Dec 3, 7:09 AM · Restricted Project

Mon, Nov 29

jackoalan added a comment to D114327: [CMake] Installable find modules for terminfo and libffi.

I also do not have commit access yet. Would you mind committing this for me?
--author="Jack Andersen <jackoalan@gmail.com>"

Mon, Nov 29, 3:20 PM · Restricted Project
jackoalan added a comment to D114327: [CMake] Installable find modules for terminfo and libffi.

I should also note that I tested this change on Windows and this does not interfere with package importing there. (LLVM_ENABLE_TERMINFO and LLVM_ENABLE_FFI are set false in LLVMConfig.cmake)

Mon, Nov 29, 3:18 PM · Restricted Project
jackoalan added a comment to D114327: [CMake] Installable find modules for terminfo and libffi.

I'm assuming the logic to find the actual packages is the same

Yes, mostly existing code refactored into find modules.

Mon, Nov 29, 3:13 PM · Restricted Project
jackoalan updated the diff for D114327: [CMake] Installable find modules for terminfo and libffi.

Use LLDB's find module naming conventions and style.

Mon, Nov 29, 3:05 PM · Restricted Project

Fri, Nov 26

jackoalan abandoned D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.

Abandoning this for now. A more sensible approach to the use case has been discovered.

Fri, Nov 26, 12:49 PM · Restricted Project

Thu, Nov 25

jackoalan updated the diff for D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.

Fix clang-format issue

Thu, Nov 25, 12:26 PM · Restricted Project
jackoalan added a reviewer for D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies: t.p.northover.
Thu, Nov 25, 12:16 PM · Restricted Project
jackoalan requested review of D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.
Thu, Nov 25, 12:07 PM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Clarify TracksDebugUserValues documenting comment.

Thu, Nov 25, 10:24 AM · Restricted Project
jackoalan retitled D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues from [GlobalISel] Allow DBG_VALUE to use invalid vregs throughout pipeline to [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Thu, Nov 25, 10:21 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
  • Rename DebugValuesAllocated -> TracksDebugUserValues
  • MIR key for TracksDebugUserValues
  • TracksDebugUserValues tests for MachineVerifier
  • LiveDebugValues test to ensure undefined debug uses delete DBG_VALUE instructions
Thu, Nov 25, 10:20 AM · Restricted Project

Mon, Nov 22

jackoalan added a comment to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

That said I don't feel strongly about this. If others think this is benefitial then we can go ahead.

Mon, Nov 22, 11:35 AM · Restricted Project

Sun, Nov 21

jackoalan updated the summary of D114327: [CMake] Installable find modules for terminfo and libffi.
Sun, Nov 21, 6:52 AM · Restricted Project
jackoalan updated the summary of D114327: [CMake] Installable find modules for terminfo and libffi.
Sun, Nov 21, 6:51 AM · Restricted Project

Sat, Nov 20

jackoalan added reviewers for D114327: [CMake] Installable find modules for terminfo and libffi: haampie, JDevlieghere.
Sat, Nov 20, 5:16 PM · Restricted Project
jackoalan added a reviewer for D114327: [CMake] Installable find modules for terminfo and libffi: phosek.
Sat, Nov 20, 5:12 PM · Restricted Project
jackoalan updated the summary of D114327: [CMake] Installable find modules for terminfo and libffi.
Sat, Nov 20, 2:59 PM · Restricted Project
jackoalan requested review of D114327: [CMake] Installable find modules for terminfo and libffi.
Sat, Nov 20, 2:58 PM · Restricted Project
jackoalan added a comment to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Before we weaken the verifier

The weakening conditions are now much more targeted to this specific case.

Sat, Nov 20, 10:29 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Specifically check for vregs without defs when suppressing verification errors.

Sat, Nov 20, 10:17 AM · Restricted Project

Oct 29 2021

jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Update comment

Oct 29 2021, 4:34 PM · Restricted Project
jackoalan updated the summary of D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Oct 29 2021, 4:03 PM · Restricted Project
jackoalan updated the summary of D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Oct 29 2021, 4:02 PM · Restricted Project
jackoalan requested review of D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Oct 29 2021, 3:53 PM · Restricted Project
jackoalan updated the diff for D91514: Expose CastInst::getCastOpcode in C API.

Rebase

Oct 29 2021, 12:03 PM · Restricted Project

Oct 27 2021

jackoalan added a comment to D91514: Expose CastInst::getCastOpcode in C API.

ping

Oct 27 2021, 8:37 AM · Restricted Project

Oct 21 2021

jackoalan added a comment to D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections.

Thank you for the feedback! Would you mind committing this? --author="Jack Andersen <jackoalan@gmail.com>"

Oct 21 2021, 5:21 PM · Restricted Project

Oct 18 2021

jackoalan abandoned D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts..

Abandoning this for now, since the solution would be completely rethinking how debug value uses are handled.

Oct 18 2021, 2:56 PM · Restricted Project
jackoalan added a comment to D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts..

All, that makes much more sense. If performance is the objective, allowing the dangling use and relaxing the asserts might be the better option.

Oct 18 2021, 2:52 PM · Restricted Project
jackoalan abandoned D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.
Oct 18 2021, 9:18 AM
jackoalan added a reviewer for D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections: bkramer.
Oct 18 2021, 6:31 AM · Restricted Project

Oct 17 2021

jackoalan added reviewers for D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts.: arsenm, dsanders.
Oct 17 2021, 5:20 PM · Restricted Project
jackoalan requested review of D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts..
Oct 17 2021, 5:16 PM · Restricted Project
jackoalan added inline comments to D109750: [GlobalISel][Legalizer] Don't use eraseFromParentAndMarkDBGValuesForRemoval() for some artifacts..
Oct 17 2021, 1:56 PM · Restricted Project
jackoalan added inline comments to D109750: [GlobalISel][Legalizer] Don't use eraseFromParentAndMarkDBGValuesForRemoval() for some artifacts..
Oct 17 2021, 12:57 PM · Restricted Project

Oct 16 2021

jackoalan updated the diff for D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections.

Fix patch format

Oct 16 2021, 3:11 PM · Restricted Project
jackoalan requested review of D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections.
Oct 16 2021, 2:35 PM · Restricted Project

Oct 15 2021

jackoalan updated the diff for D91514: Expose CastInst::getCastOpcode in C API.

Add unit test

Oct 15 2021, 4:06 PM · Restricted Project

Oct 5 2021

jackoalan added a comment to D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Thank you for the feedback! Would you mind committing this? --author="Jack Andersen <jackoalan@gmail.com>"

Oct 5 2021, 5:47 PM · Restricted Project
jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Remove now-redundant MachineVerifier check. Also check debug instructions on uses only and non-debug instruction case.

Oct 5 2021, 5:39 PM · Restricted Project
jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Apply to all debug instructions according to MachineInstr::isDebugInstr

Oct 5 2021, 3:05 PM · Restricted Project

Oct 2 2021

jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Add check to MachineVerifier. Remove explicit debug operand flag uses.

Oct 2 2021, 10:23 AM · Restricted Project

Sep 29 2021

jackoalan added a comment to D110659: [compiler-rt] Add target dependencies to run ORC tests.

Not a problem, thank you for the quick turnaround :)

Sep 29 2021, 1:11 PM · Restricted Project

Sep 28 2021

jackoalan added a comment to D110659: [compiler-rt] Add target dependencies to run ORC tests.

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author

Sep 28 2021, 11:59 PM · Restricted Project
jackoalan added a comment to D110659: [compiler-rt] Add target dependencies to run ORC tests.

I do not have commit access, it'd be great if you'd do that. --author="Jack Andersen <jackoalan@gmail.com>"

Sep 28 2021, 6:26 PM · Restricted Project
jackoalan added a comment to D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Also curious if invariant debug register operands are applicable to other debug instructions (DBG_INSTR_REF, DBG_PHI, DBG_LABEL)

Sep 28 2021, 3:45 PM · Restricted Project
jackoalan added a comment to D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Shouldn't be too difficult to add the MachineVerifier check and remove the setIsDebug calls. Shall I also remove RegState::Debug in the context of DBG_VALUE builders?

Sep 28 2021, 3:10 PM · Restricted Project
jackoalan updated the summary of D110659: [compiler-rt] Add target dependencies to run ORC tests.
Sep 28 2021, 2:39 PM · Restricted Project
jackoalan updated the summary of D110659: [compiler-rt] Add target dependencies to run ORC tests.
Sep 28 2021, 2:31 PM · Restricted Project
jackoalan requested review of D110659: [compiler-rt] Add target dependencies to run ORC tests.
Sep 28 2021, 2:30 PM · Restricted Project
jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Cover MachineOperand::ChangeToRegister with invariant. Add unit test to MachineInstrTest.cpp

Sep 28 2021, 1:04 PM · Restricted Project

Sep 21 2021

jackoalan retitled D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand from Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand to [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.
Sep 21 2021, 12:21 AM · Restricted Project

Sep 20 2021

jackoalan requested review of D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.
Sep 20 2021, 1:35 PM · Restricted Project

Nov 15 2020

jackoalan requested review of D91514: Expose CastInst::getCastOpcode in C API.
Nov 15 2020, 8:26 PM · Restricted Project

Jul 1 2020

jackoalan added a comment to D83014: [PDB] read/dump fixups from PDB dbi stream.

I'd like some input on whether or not to include fixup dumping in the -all option. Relocations can quickly become numerous in a moderately complex binary.

Jul 1 2020, 6:23 PM · Restricted Project
jackoalan added reviewers for D83014: [PDB] read/dump fixups from PDB dbi stream: aleksandr.urakov, echristo, zturner.
Jul 1 2020, 5:54 PM · Restricted Project
jackoalan created D83014: [PDB] read/dump fixups from PDB dbi stream.
Jul 1 2020, 5:50 PM · Restricted Project

Jun 23 2020

jackoalan added a comment to D82160: [lldb][PDB] Constexpr static member values as AST literals.

Thank you! I do not have commit access, so I will need some help with that.

Jun 23 2020, 1:26 PM · Restricted Project, Restricted Project

Jun 22 2020

jackoalan added inline comments to D82160: [lldb][PDB] Constexpr static member values as AST literals.
Jun 22 2020, 9:29 PM · Restricted Project, Restricted Project
jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.
  • Added a test for scoped enums (works as-is but still worth testing).
  • Less frivolous use of auto
  • Made the floating point vars constexpr to maintain validity in clang's internals.
  • AstRestoreTest CLASS tests run for both DIA and Native. A pure NativePDB test that does not depend on MSVC would require extending s_constant.cpp (S_CONSTANT not generated by clang-cl) but I'm not certain how to regenerate the listing file with comments (unless that's done by hand). For now, this change should only be considered relevant for PDBs generated by MSVC.
Jun 22 2020, 8:57 PM · Restricted Project, Restricted Project

Jun 21 2020

jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.

Apply formatting fixes

Jun 21 2020, 1:33 AM · Restricted Project, Restricted Project
jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.

Fix ternary to use corresponding float/double overloaded constructors of APFloat

Jun 21 2020, 12:30 AM · Restricted Project, Restricted Project

Jun 20 2020

jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.

Review changes from @teemperor.

Jun 20 2020, 11:57 PM · Restricted Project, Restricted Project
jackoalan added a comment to D82160: [lldb][PDB] Constexpr static member values as AST literals.

Thank you @teemperor, your comments and changes in D81471 are very informative. I didn't realise DWARF had similar issues with static const members.

Jun 20 2020, 11:57 PM · Restricted Project, Restricted Project

Jun 19 2020

jackoalan created D82160: [lldb][PDB] Constexpr static member values as AST literals.
Jun 19 2020, 2:07 AM · Restricted Project, Restricted Project

Jan 15 2018

jackoalan abandoned D41534: Don't add empty InstalledDir as a candidate GCC location.

I've found that passing --gcc-toolchain=/usr results in the exact behavior I'm after.

Jan 15 2018, 2:51 PM

Dec 22 2017

jackoalan updated subscribers of D41534: Don't add empty InstalledDir as a candidate GCC location.
Dec 22 2017, 3:38 PM

Dec 21 2017

jackoalan added a reviewer for D41534: Don't add empty InstalledDir as a candidate GCC location: rsmith.
Dec 21 2017, 9:37 PM
jackoalan created D41534: Don't add empty InstalledDir as a candidate GCC location.
Dec 21 2017, 9:18 PM

Jan 27 2017

jackoalan updated the diff for D26345: Extend small data threshold driver options to PPC target.

Remove already-aliased option matchings; add test case for patch.

Jan 27 2017, 11:36 AM

Nov 30 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Rebase against upstream master. Cleanup PPCTargetInfo::relocateOne() with mask constants.

Nov 30 2016, 1:53 PM
jackoalan updated the diff for D26345: Extend small data threshold driver options to PPC target.

Rebase against upstream master

Nov 30 2016, 1:50 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Rebase against upstream master

Nov 30 2016, 1:49 PM

Nov 21 2016

jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Add target-independent small data classification for constants via MachineConstantPoolEntry::getSectionKind().

Nov 21 2016, 9:26 PM

Nov 18 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Implement getBitcodeOSABIKind, which just responds to Triple::EABI for now.

Nov 18 2016, 4:38 PM

Nov 17 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Test now uses sda21 symbol variant as changed from sdarx.

Nov 17 2016, 6:39 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

To better follow GCC convention, use sda21 rather than sdarx as the symbol variant.

Nov 17 2016, 6:34 PM
jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Ensure Config->OSABI == ELF::ELFOSABI_STANDALONE is true when synthesizing _SDA_BASE_ symbols.

Nov 17 2016, 1:39 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Object file ABI tag is now set with the following for PPC:

Nov 17 2016, 1:36 PM

Nov 16 2016

jackoalan updated D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.
Nov 16 2016, 8:25 PM
jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Make PPC target bi-endian in the same manner as MIPS. Tidy up PPCTargetInfo::relocateOne(). Rebase with latest master

Nov 16 2016, 8:18 PM
jackoalan updated the diff for D26345: Extend small data threshold driver options to PPC target.

Rebase against latest master.

Nov 16 2016, 7:23 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Rebase against latest master. check-all test results match those experienced on base master.

Nov 16 2016, 7:20 PM

Nov 12 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Add PPCTargetInfo::relocateOne() R_PPC_ADDR14 and R_PPC_REL14 handling.

Nov 12 2016, 6:54 PM
jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

_SDA_BASE_ symbols need direct calls to ElfSym<ELFT>::addSynthetic to be initially created.

Nov 12 2016, 3:54 PM

Nov 11 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Rebase with upstream master. Add -sda-base= and -sda2-base= linker options for overriding synthetic values.

Nov 11 2016, 3:57 PM

Nov 10 2016

jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Remove stray blank line, Rebase against upstream master.

Nov 10 2016, 6:01 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Remove PPCSubtarget:: useEABISmallDataSections() flag, opting for direct TargetTriple::isEABI().

Nov 10 2016, 4:16 PM

Nov 9 2016

jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Little-endian addressing fix. Uses addressing described in "3.1.4.4 PowerPC Instruction Addressing in Little-Endian Mode" section of programming manual. (needed to think of it from the offset operand end)

Nov 9 2016, 5:35 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Create SmallKind = 0x80 enum entry, rename smallUnderlyingKind() to UnderlyingKind()

Nov 9 2016, 11:12 AM

Nov 6 2016

jackoalan retitled D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols from to [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.
Nov 6 2016, 11:28 PM
jackoalan added a reviewer for D26345: Extend small data threshold driver options to PPC target: hfinkel.
Nov 6 2016, 11:20 PM
jackoalan retitled D26345: Extend small data threshold driver options to PPC target from to Extend small data threshold driver options to PPC target.
Nov 6 2016, 11:19 PM