Page MenuHomePhabricator

jackoalan (Jack Andersen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2016, 4:19 PM (317 w, 4 d)

Recent Activity

Apr 30 2022

jackoalan committed rG09325d36061e: [CAPI] Expose CastInst::getCastOpcode in C API (authored by jackoalan).
[CAPI] Expose CastInst::getCastOpcode in C API
Apr 30 2022, 3:46 PM · Restricted Project, Restricted Project
jackoalan closed D91514: Expose CastInst::getCastOpcode in C API.
Apr 30 2022, 3:45 PM · Restricted Project, Restricted Project

Jan 14 2022

jackoalan added a comment to D116713: [clangd] Support configuration of inlay hints..

Assuming origin/maain is a branch typo and is no longer being tracked, would you please delete the upstream one in https://github.com/llvm/llvm-project/branches?

Jan 14 2022, 8:03 AM · Restricted Project

Jan 4 2022

jackoalan committed rG5b1337184bfb: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes. (authored by jackoalan).
[DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes.
Jan 4 2022, 12:18 PM
jackoalan closed D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..
Jan 4 2022, 12:18 PM · Restricted Project
jackoalan updated the diff for D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..

Return resolved DWARF enums from lambda.

Jan 4 2022, 11:08 AM · Restricted Project
jackoalan updated the diff for D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..

Sink assert using lambda

Jan 4 2022, 10:28 AM · Restricted Project
jackoalan added a comment to D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..

Perhaps the right thing to do then would be to sink the assertion back down in some way - either just duplicating it in the two places it's used or using a lambda, perhaps?

Jan 4 2022, 10:03 AM · Restricted Project
jackoalan added a comment to D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..

Could you add some details about where the assert came from/went to, link to the patch that made the change?

Jan 4 2022, 9:53 AM · Restricted Project
jackoalan updated the summary of D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..
Jan 4 2022, 9:51 AM · Restricted Project

Jan 1 2022

jackoalan updated the diff for D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..

Fix test for windows

Jan 1 2022, 2:22 PM · Restricted Project
jackoalan requested review of D116480: [DebugInfo] Avoid triggering global location assert for 2-byte pointer sizes..
Jan 1 2022, 1:19 PM · Restricted Project

Dec 30 2021

jackoalan requested changes to D116427: FindTerminfo.cmake: Don't require that C language support be enabled for CMake project..

Thank you for the patch! It makes sense that the check functions depend on the corresponding language to be enabled.

Dec 30 2021, 4:53 PM · Restricted Project
jackoalan committed rG9d37d0ea3485: [Support] Expand `<CFGDIR>` as the base directory in configuration files. (authored by jackoalan).
[Support] Expand `<CFGDIR>` as the base directory in configuration files.
Dec 30 2021, 10:45 AM
jackoalan closed D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..
Dec 30 2021, 10:45 AM · Restricted Project, Restricted Project
jackoalan added a comment to D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Actually, I just thought of a possible limitation of using path-append when suffixing with something that isn't actually a path component. However, I cannot say how critical this limitation is.

Dec 30 2021, 7:52 AM · Restricted Project, Restricted Project
jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Add ReadConfigFile test case for multiple <CFGDIR> in one arg.

Dec 30 2021, 7:18 AM · Restricted Project, Restricted Project
jackoalan added inline comments to D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..
Dec 30 2021, 6:54 AM · Restricted Project, Restricted Project
jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Update ReadConfigFile test with additional <CFGDIR> expansion contexts (non-prefixed, non-suffixed, escaped in middle).

Dec 30 2021, 6:49 AM · Restricted Project, Restricted Project

Dec 29 2021

jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Update call parameters in ExpandResponseFilesDatabase::expand

Dec 29 2021, 3:59 PM · Restricted Project, Restricted Project
jackoalan updated the summary of D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..
Dec 29 2021, 11:53 AM · Restricted Project, Restricted Project
jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Make <CFGDIR> constant at point of expansion. Use bool parameter to activate <CFGDIR> expansion.

Dec 29 2021, 11:51 AM · Restricted Project, Restricted Project

Dec 28 2021

jackoalan retitled D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files. from [Support] Expand `<CONFIG>` as the base directory in response files. to [Support] Expand `<CFGDIR>` as the base directory in response files..
Dec 28 2021, 10:06 AM · Restricted Project, Restricted Project
jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Rebase, use the slightly more intuitive <CFGDIR> token to expand base paths.

Dec 28 2021, 10:06 AM · Restricted Project, Restricted Project

Dec 23 2021

jackoalan updated the summary of D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..
Dec 23 2021, 12:04 PM · Restricted Project, Restricted Project
jackoalan retitled D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files. from [Support] Expand `<@>` as the base directory in response files. to [Support] Expand `<CONFIG>` as the base directory in response files..
Dec 23 2021, 12:03 PM · Restricted Project, Restricted Project
jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Make expansion token a parameter of ExpandResponseFiles and limit use to readConfigFile. Elaborate manual entry further and add entry to release notes.

Dec 23 2021, 10:55 AM · Restricted Project, Restricted Project
jackoalan added a comment to D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..
  1. It it possible to limit the new syntax to config files only? It would avoid concerns of gcc compatibility.
Dec 23 2021, 9:22 AM · Restricted Project, Restricted Project

Dec 22 2021

jackoalan added inline comments to D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..
Dec 22 2021, 9:55 AM · Restricted Project, Restricted Project
jackoalan added a comment to D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

bump, review requested

Dec 22 2021, 6:44 AM · Restricted Project, Restricted Project

Dec 21 2021

jackoalan added inline comments to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Dec 21 2021, 9:03 AM · Restricted Project

Dec 20 2021

jackoalan added a reviewer for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files.: sepavloff.
Dec 20 2021, 12:02 PM · Restricted Project, Restricted Project

Dec 18 2021

jackoalan added a reviewer for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files.: dexonsmith.
Dec 18 2021, 10:56 AM · Restricted Project, Restricted Project

Dec 17 2021

jackoalan added inline comments to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Dec 17 2021, 2:43 PM · Restricted Project
jackoalan added inline comments to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Dec 17 2021, 2:10 PM · Restricted Project

Dec 13 2021

jackoalan added a comment to D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

IIUC, the new behavior being introduced by this patch is not the ability of having a way to refer to other files in a config/response file relative way, but rather extending that ability from only the options that start with @ to options that contain @ as a sub-string in any place.

Dec 13 2021, 6:08 AM · Restricted Project, Restricted Project

Dec 12 2021

jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Test coverage for more than one <@> per arg.

Dec 12 2021, 5:36 PM · Restricted Project, Restricted Project
jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Fix ResponseFiles test for Windows.

Dec 12 2021, 3:39 PM · Restricted Project, Restricted Project
jackoalan updated the diff for D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

Add entry to user manual explaining the <@> token.

Dec 12 2021, 2:04 PM · Restricted Project, Restricted Project
jackoalan added a comment to D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..

It should be evaluated if <@> is a sufficiently unique token to not accidentally break existing users' response files. The use of shell operator characters would likely ensure this.

Dec 12 2021, 1:43 PM · Restricted Project, Restricted Project
jackoalan requested review of D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files..
Dec 12 2021, 1:42 PM · Restricted Project, Restricted Project

Dec 5 2021

jackoalan committed rGf108c7f59dfa: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues. (authored by jackoalan).
[GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Dec 5 2021, 12:57 PM
jackoalan closed D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Dec 5 2021, 12:56 PM · Restricted Project
jackoalan committed rGb66339575a9b: [CMake] Installable find modules for terminfo and libffi (authored by jackoalan).
[CMake] Installable find modules for terminfo and libffi
Dec 5 2021, 11:48 AM
jackoalan closed D114327: [CMake] Installable find modules for terminfo and libffi.
Dec 5 2021, 11:48 AM · Restricted Project
jackoalan committed rG296ebeb808a7: Test commit to check access. (authored by jackoalan).
Test commit to check access.
Dec 5 2021, 11:36 AM

Dec 3 2021

jackoalan added a comment to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Thanks everyone for the comments. May I have somebody commit this for me?
--author="Jack Andersen <jackoalan@gmail.com>"

Dec 3 2021, 7:12 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Rebase, Change TracksDebugUserValues comment per review request

Dec 3 2021, 7:09 AM · Restricted Project

Nov 29 2021

jackoalan added a comment to D114327: [CMake] Installable find modules for terminfo and libffi.

I also do not have commit access yet. Would you mind committing this for me?
--author="Jack Andersen <jackoalan@gmail.com>"

Nov 29 2021, 3:20 PM · Restricted Project
jackoalan added a comment to D114327: [CMake] Installable find modules for terminfo and libffi.

I should also note that I tested this change on Windows and this does not interfere with package importing there. (LLVM_ENABLE_TERMINFO and LLVM_ENABLE_FFI are set false in LLVMConfig.cmake)

Nov 29 2021, 3:18 PM · Restricted Project
jackoalan added a comment to D114327: [CMake] Installable find modules for terminfo and libffi.

I'm assuming the logic to find the actual packages is the same

Yes, mostly existing code refactored into find modules.

Nov 29 2021, 3:13 PM · Restricted Project
jackoalan updated the diff for D114327: [CMake] Installable find modules for terminfo and libffi.

Use LLDB's find module naming conventions and style.

Nov 29 2021, 3:05 PM · Restricted Project

Nov 26 2021

jackoalan abandoned D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.

Abandoning this for now. A more sensible approach to the use case has been discovered.

Nov 26 2021, 12:49 PM · Restricted Project

Nov 25 2021

jackoalan updated the diff for D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.

Fix clang-format issue

Nov 25 2021, 12:26 PM · Restricted Project
jackoalan added a reviewer for D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies: t.p.northover.
Nov 25 2021, 12:16 PM · Restricted Project
jackoalan requested review of D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.
Nov 25 2021, 12:07 PM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Clarify TracksDebugUserValues documenting comment.

Nov 25 2021, 10:24 AM · Restricted Project
jackoalan retitled D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues from [GlobalISel] Allow DBG_VALUE to use invalid vregs throughout pipeline to [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Nov 25 2021, 10:21 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
  • Rename DebugValuesAllocated -> TracksDebugUserValues
  • Documenting comment for TracksDebugUserValues
  • MIR key for TracksDebugUserValues
  • TracksDebugUserValues tests for MachineVerifier
  • LiveDebugValues test to ensure undefined debug uses delete DBG_VALUE instructions
Nov 25 2021, 10:20 AM · Restricted Project

Nov 22 2021

jackoalan added a comment to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

That said I don't feel strongly about this. If others think this is benefitial then we can go ahead.

Nov 22 2021, 11:35 AM · Restricted Project

Nov 21 2021

jackoalan updated the summary of D114327: [CMake] Installable find modules for terminfo and libffi.
Nov 21 2021, 6:52 AM · Restricted Project
jackoalan updated the summary of D114327: [CMake] Installable find modules for terminfo and libffi.
Nov 21 2021, 6:51 AM · Restricted Project

Nov 20 2021

jackoalan added reviewers for D114327: [CMake] Installable find modules for terminfo and libffi: haampie, JDevlieghere.
Nov 20 2021, 5:16 PM · Restricted Project
jackoalan added a reviewer for D114327: [CMake] Installable find modules for terminfo and libffi: phosek.
Nov 20 2021, 5:12 PM · Restricted Project
jackoalan updated the summary of D114327: [CMake] Installable find modules for terminfo and libffi.
Nov 20 2021, 2:59 PM · Restricted Project
jackoalan requested review of D114327: [CMake] Installable find modules for terminfo and libffi.
Nov 20 2021, 2:58 PM · Restricted Project
jackoalan added a comment to D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Before we weaken the verifier

The weakening conditions are now much more targeted to this specific case.

Nov 20 2021, 10:29 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Specifically check for vregs without defs when suppressing verification errors.

Nov 20 2021, 10:17 AM · Restricted Project

Oct 29 2021

jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Update comment

Oct 29 2021, 4:34 PM · Restricted Project
jackoalan updated the summary of D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Oct 29 2021, 4:03 PM · Restricted Project
jackoalan updated the summary of D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Oct 29 2021, 4:02 PM · Restricted Project
jackoalan requested review of D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Oct 29 2021, 3:53 PM · Restricted Project
jackoalan updated the diff for D91514: Expose CastInst::getCastOpcode in C API.

Rebase

Oct 29 2021, 12:03 PM · Restricted Project, Restricted Project

Oct 27 2021

jackoalan added a comment to D91514: Expose CastInst::getCastOpcode in C API.

ping

Oct 27 2021, 8:37 AM · Restricted Project, Restricted Project

Oct 21 2021

jackoalan added a comment to D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections.

Thank you for the feedback! Would you mind committing this? --author="Jack Andersen <jackoalan@gmail.com>"

Oct 21 2021, 5:21 PM · Restricted Project

Oct 18 2021

jackoalan abandoned D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts..

Abandoning this for now, since the solution would be completely rethinking how debug value uses are handled.

Oct 18 2021, 2:56 PM · Restricted Project
jackoalan added a comment to D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts..

All, that makes much more sense. If performance is the objective, allowing the dangling use and relaxing the asserts might be the better option.

Oct 18 2021, 2:52 PM · Restricted Project
jackoalan abandoned D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.
Oct 18 2021, 9:18 AM
jackoalan added a reviewer for D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections: bkramer.
Oct 18 2021, 6:31 AM · Restricted Project

Oct 17 2021

jackoalan added reviewers for D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts.: arsenm, dsanders.
Oct 17 2021, 5:20 PM · Restricted Project
jackoalan requested review of D111970: [GlobalISel][Legalizer] Restore eraseFromParentAndMarkDBGValuesForRemoval() for CallLowering artifacts..
Oct 17 2021, 5:16 PM · Restricted Project
jackoalan added inline comments to D109750: [GlobalISel][Legalizer] Don't use eraseFromParentAndMarkDBGValuesForRemoval() for some artifacts..
Oct 17 2021, 1:56 PM · Restricted Project
jackoalan added inline comments to D109750: [GlobalISel][Legalizer] Don't use eraseFromParentAndMarkDBGValuesForRemoval() for some artifacts..
Oct 17 2021, 12:57 PM · Restricted Project

Oct 16 2021

jackoalan updated the diff for D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections.

Fix patch format

Oct 16 2021, 3:11 PM · Restricted Project
jackoalan requested review of D111953: [DebugInfo] Expand ability to load 2-byte addresses in dwarf sections.
Oct 16 2021, 2:35 PM · Restricted Project

Oct 15 2021

jackoalan updated the diff for D91514: Expose CastInst::getCastOpcode in C API.

Add unit test

Oct 15 2021, 4:06 PM · Restricted Project, Restricted Project

Oct 5 2021

jackoalan added a comment to D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Thank you for the feedback! Would you mind committing this? --author="Jack Andersen <jackoalan@gmail.com>"

Oct 5 2021, 5:47 PM · Restricted Project
jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Remove now-redundant MachineVerifier check. Also check debug instructions on uses only and non-debug instruction case.

Oct 5 2021, 5:39 PM · Restricted Project
jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Apply to all debug instructions according to MachineInstr::isDebugInstr

Oct 5 2021, 3:05 PM · Restricted Project

Oct 2 2021

jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Add check to MachineVerifier. Remove explicit debug operand flag uses.

Oct 2 2021, 10:23 AM · Restricted Project

Sep 29 2021

jackoalan added a comment to D110659: [compiler-rt] Add target dependencies to run ORC tests.

Not a problem, thank you for the quick turnaround :)

Sep 29 2021, 1:11 PM · Restricted Project

Sep 28 2021

jackoalan added a comment to D110659: [compiler-rt] Add target dependencies to run ORC tests.

Thanks Jack. I'm not sure what LLVM's policy is with regards to --author

Sep 28 2021, 11:59 PM · Restricted Project
jackoalan added a comment to D110659: [compiler-rt] Add target dependencies to run ORC tests.

I do not have commit access, it'd be great if you'd do that. --author="Jack Andersen <jackoalan@gmail.com>"

Sep 28 2021, 6:26 PM · Restricted Project
jackoalan added a comment to D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Also curious if invariant debug register operands are applicable to other debug instructions (DBG_INSTR_REF, DBG_PHI, DBG_LABEL)

Sep 28 2021, 3:45 PM · Restricted Project
jackoalan added a comment to D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Shouldn't be too difficult to add the MachineVerifier check and remove the setIsDebug calls. Shall I also remove RegState::Debug in the context of DBG_VALUE builders?

Sep 28 2021, 3:10 PM · Restricted Project
jackoalan updated the summary of D110659: [compiler-rt] Add target dependencies to run ORC tests.
Sep 28 2021, 2:39 PM · Restricted Project
jackoalan updated the summary of D110659: [compiler-rt] Add target dependencies to run ORC tests.
Sep 28 2021, 2:31 PM · Restricted Project
jackoalan requested review of D110659: [compiler-rt] Add target dependencies to run ORC tests.
Sep 28 2021, 2:30 PM · Restricted Project
jackoalan updated the diff for D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.

Cover MachineOperand::ChangeToRegister with invariant. Add unit test to MachineInstrTest.cpp

Sep 28 2021, 1:04 PM · Restricted Project

Sep 21 2021

jackoalan retitled D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand from Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand to [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand.
Sep 21 2021, 12:21 AM · Restricted Project