Page MenuHomePhabricator

jackoalan (Jack Andersen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2016, 4:19 PM (221 w, 4 d)

Recent Activity

Nov 15 2020

jackoalan requested review of D91514: Expose CastInst::getCastOpcode in C API.
Nov 15 2020, 8:26 PM · Restricted Project

Jul 1 2020

jackoalan added a comment to D83014: [PDB] read/dump fixups from PDB dbi stream.

I'd like some input on whether or not to include fixup dumping in the -all option. Relocations can quickly become numerous in a moderately complex binary.

Jul 1 2020, 6:23 PM · Restricted Project
jackoalan added reviewers for D83014: [PDB] read/dump fixups from PDB dbi stream: aleksandr.urakov, echristo, zturner.
Jul 1 2020, 5:54 PM · Restricted Project
jackoalan created D83014: [PDB] read/dump fixups from PDB dbi stream.
Jul 1 2020, 5:50 PM · Restricted Project

Jun 23 2020

jackoalan added a comment to D82160: [lldb][PDB] Constexpr static member values as AST literals.

Thank you! I do not have commit access, so I will need some help with that.

Jun 23 2020, 1:26 PM · Restricted Project, Restricted Project

Jun 22 2020

jackoalan added inline comments to D82160: [lldb][PDB] Constexpr static member values as AST literals.
Jun 22 2020, 9:29 PM · Restricted Project, Restricted Project
jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.
  • Added a test for scoped enums (works as-is but still worth testing).
  • Less frivolous use of auto
  • Made the floating point vars constexpr to maintain validity in clang's internals.
  • AstRestoreTest CLASS tests run for both DIA and Native. A pure NativePDB test that does not depend on MSVC would require extending s_constant.cpp (S_CONSTANT not generated by clang-cl) but I'm not certain how to regenerate the listing file with comments (unless that's done by hand). For now, this change should only be considered relevant for PDBs generated by MSVC.
Jun 22 2020, 8:57 PM · Restricted Project, Restricted Project

Jun 21 2020

jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.

Apply formatting fixes

Jun 21 2020, 1:33 AM · Restricted Project, Restricted Project
jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.

Fix ternary to use corresponding float/double overloaded constructors of APFloat

Jun 21 2020, 12:30 AM · Restricted Project, Restricted Project

Jun 20 2020

jackoalan updated the diff for D82160: [lldb][PDB] Constexpr static member values as AST literals.

Review changes from @teemperor.

Jun 20 2020, 11:57 PM · Restricted Project, Restricted Project
jackoalan added a comment to D82160: [lldb][PDB] Constexpr static member values as AST literals.

Thank you @teemperor, your comments and changes in D81471 are very informative. I didn't realise DWARF had similar issues with static const members.

Jun 20 2020, 11:57 PM · Restricted Project, Restricted Project

Jun 19 2020

jackoalan created D82160: [lldb][PDB] Constexpr static member values as AST literals.
Jun 19 2020, 2:07 AM · Restricted Project, Restricted Project

Jan 15 2018

jackoalan abandoned D41534: Don't add empty InstalledDir as a candidate GCC location.

I've found that passing --gcc-toolchain=/usr results in the exact behavior I'm after.

Jan 15 2018, 2:51 PM

Dec 22 2017

jackoalan updated subscribers of D41534: Don't add empty InstalledDir as a candidate GCC location.
Dec 22 2017, 3:38 PM

Dec 21 2017

jackoalan added a reviewer for D41534: Don't add empty InstalledDir as a candidate GCC location: rsmith.
Dec 21 2017, 9:37 PM
jackoalan created D41534: Don't add empty InstalledDir as a candidate GCC location.
Dec 21 2017, 9:18 PM

Jan 27 2017

jackoalan updated the diff for D26345: Extend small data threshold driver options to PPC target.

Remove already-aliased option matchings; add test case for patch.

Jan 27 2017, 11:36 AM

Nov 30 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Rebase against upstream master. Cleanup PPCTargetInfo::relocateOne() with mask constants.

Nov 30 2016, 1:53 PM
jackoalan updated the diff for D26345: Extend small data threshold driver options to PPC target.

Rebase against upstream master

Nov 30 2016, 1:50 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Rebase against upstream master

Nov 30 2016, 1:49 PM

Nov 21 2016

jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Add target-independent small data classification for constants via MachineConstantPoolEntry::getSectionKind().

Nov 21 2016, 9:26 PM

Nov 18 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Implement getBitcodeOSABIKind, which just responds to Triple::EABI for now.

Nov 18 2016, 4:38 PM

Nov 17 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Test now uses sda21 symbol variant as changed from sdarx.

Nov 17 2016, 6:39 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

To better follow GCC convention, use sda21 rather than sdarx as the symbol variant.

Nov 17 2016, 6:34 PM
jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Ensure Config->OSABI == ELF::ELFOSABI_STANDALONE is true when synthesizing _SDA_BASE_ symbols.

Nov 17 2016, 1:39 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Object file ABI tag is now set with the following for PPC:

Nov 17 2016, 1:36 PM

Nov 16 2016

jackoalan updated D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.
Nov 16 2016, 8:25 PM
jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Make PPC target bi-endian in the same manner as MIPS. Tidy up PPCTargetInfo::relocateOne(). Rebase with latest master

Nov 16 2016, 8:18 PM
jackoalan updated the diff for D26345: Extend small data threshold driver options to PPC target.

Rebase against latest master.

Nov 16 2016, 7:23 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Rebase against latest master. check-all test results match those experienced on base master.

Nov 16 2016, 7:20 PM

Nov 12 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Add PPCTargetInfo::relocateOne() R_PPC_ADDR14 and R_PPC_REL14 handling.

Nov 12 2016, 6:54 PM
jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

_SDA_BASE_ symbols need direct calls to ElfSym<ELFT>::addSynthetic to be initially created.

Nov 12 2016, 3:54 PM

Nov 11 2016

jackoalan updated the diff for D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.

Rebase with upstream master. Add -sda-base= and -sda2-base= linker options for overriding synthetic values.

Nov 11 2016, 3:57 PM

Nov 10 2016

jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Remove stray blank line, Rebase against upstream master.

Nov 10 2016, 6:01 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Remove PPCSubtarget:: useEABISmallDataSections() flag, opting for direct TargetTriple::isEABI().

Nov 10 2016, 4:16 PM

Nov 9 2016

jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Little-endian addressing fix. Uses addressing described in "3.1.4.4 PowerPC Instruction Addressing in Little-Endian Mode" section of programming manual. (needed to think of it from the offset operand end)

Nov 9 2016, 5:35 PM
jackoalan updated the diff for D26344: Small Data SectionKind and PPC-EABI SDA Relocation.

Create SmallKind = 0x80 enum entry, rename smallUnderlyingKind() to UnderlyingKind()

Nov 9 2016, 11:12 AM

Nov 6 2016

jackoalan retitled D26346: [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols from to [LLD][PPC] Small data section handling with synthetic _SDA_BASE_ symbols.
Nov 6 2016, 11:28 PM
jackoalan added a reviewer for D26345: Extend small data threshold driver options to PPC target: hfinkel.
Nov 6 2016, 11:20 PM
jackoalan retitled D26345: Extend small data threshold driver options to PPC target from to Extend small data threshold driver options to PPC target.
Nov 6 2016, 11:19 PM
jackoalan updated D26344: Small Data SectionKind and PPC-EABI SDA Relocation.
Nov 6 2016, 11:01 PM
jackoalan retitled D26344: Small Data SectionKind and PPC-EABI SDA Relocation from to Small Data SectionKind and PPC-EABI SDA Relocation.
Nov 6 2016, 10:55 PM
jackoalan closed D26202: [LLD][PPC] Add test for R_PPC_REL32 implementation.

Committed by ruiu as part of r285720.

Nov 6 2016, 10:18 PM

Nov 1 2016

jackoalan added a comment to D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

All I've set up is the Phabricator access, no commit privileges to my knowledge

Nov 1 2016, 10:31 AM
jackoalan retitled D26202: [LLD][PPC] Add test for R_PPC_REL32 implementation from to [LLD][PPC] Add test for R_PPC_REL32 implementation.
Nov 1 2016, 9:56 AM

Oct 31 2016

jackoalan retitled D26180: [LLD][PPC] Implement R_PPC_ADDR32 from [LLD][PPC] Add ADDR32 test to [LLD][PPC] Implement R_PPC_ADDR32.
Oct 31 2016, 11:19 PM
jackoalan updated the diff for D26180: [LLD][PPC] Implement R_PPC_ADDR32.

Commit R_PPC_ADDR32 implementation in tandem with test

Oct 31 2016, 11:19 PM
jackoalan updated the diff for D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

Ensure patch contents reflects title (no ADDR32)

Oct 31 2016, 11:16 PM
jackoalan retitled D26180: [LLD][PPC] Implement R_PPC_ADDR32 from to [LLD][PPC] Add ADDR32 test.
Oct 31 2016, 11:02 PM
jackoalan updated the diff for D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

Restore LGTM'd patch

Oct 31 2016, 10:58 PM
jackoalan added a comment to D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

Just to clarify, update diff to include *just* REL24/REL32, then submit ADDR32 standalone?

Oct 31 2016, 10:47 PM
jackoalan retitled D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations from [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations to [LLD][PPC] Implement R_PPC_REL24, R_PPC_REL32, R_PPC_ADDR32 relocations.
Oct 31 2016, 9:39 PM
jackoalan updated the diff for D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

Since ADDR32 was a trivial relocation for the last diff, this test is added to validate

Oct 31 2016, 9:29 PM

Oct 30 2016

jackoalan updated the diff for D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

This adds a test for REL24.

Oct 30 2016, 12:50 AM

Oct 29 2016

jackoalan added a comment to D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

That ends up emitting R_PPC_ADDR32 (absolute relocation, which also needs to be implemented).

Oct 29 2016, 8:11 PM
jackoalan added a comment to D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.

Ok, I've appended a simple test for REL24 in ppc-relocs.s:

Oct 29 2016, 6:47 PM
jackoalan retitled D26122: [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations from to [LLD][PPC] Implement R_PPC_REL24 and R_PPC_REL32 relocations.
Oct 29 2016, 4:41 PM