Page MenuHomePhabricator

[lldb] [gdb-remote] Remove HardcodeARMRegisters() hack
ClosedPublic

Authored by mgorny on Oct 9 2021, 7:25 AM.

Details

Summary

HardcodeARMRegisters() is a hack that was supposed to be used "until
we can get an updated debugserver down on the devices". Since it was
introduced back in 2012, there is a good chance that the debugserver
has been updated at least once since then. Removing this code makes
transition to the new DynamicRegisterInfo API easier.

Diff Detail

Event Timeline

mgorny created this revision.Oct 9 2021, 7:25 AM
mgorny requested review of this revision.Oct 9 2021, 7:25 AM
mgorny added a comment.Oct 9 2021, 7:29 AM

Ehh, it seems that we have 4 tests that abuse this to avoid having to pass the register infos:

FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_read_registers_using_g_packets (TestGDBRemoteClient.TestGDBRemoteClient)
FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_read_registers_using_p_packets (TestGDBRemoteClient.TestGDBRemoteClient)
FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_write_registers_using_G_packets (TestGDBRemoteClient.TestGDBRemoteClient)
FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_write_registers_using_P_packets (TestGDBRemoteClient.TestGDBRemoteClient)

Gentle ping.

I am ok with this. Jason Molenda or someone at Apple should probably give it the final stamp as I am no longer with Apple and don't have enough knowledge to say if this work around is still needed by older devices.

jasonmolenda accepted this revision.Oct 25 2021, 10:26 AM

Sorry for the delay in looking at this one. Yes, we usually put a new debugserver on devices every year, and we don't need to support devices this old any more, this is fine to remove. Thanks!

This revision is now accepted and ready to land.Oct 25 2021, 10:26 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 11:05 AM