[fir][NFC] Move fir.global printer to cpp file

[clementval]

Summary

All big enough parser, printer and verifier are moved to the cpp file.
This is one of the last one to be moved.

This patch is part of the upstreaming effort from fir-dev branch.

[kiranchandramohan]

LGTM.

[mehdi_amini]

Can this be converted to declarative assembly instead?

[mehdi_amini]

Can this be converted to declarative assembly instead?

flang/lib/Optimizer/Dialect/FIROps.cpp

1186

ODS generates already an accessor constantAttrName (same for all other attributes) which returns an Identifier (and so allows for pointer comparison instead of strcmp).

[clementval]

In D110929#3037320, @mehdi_amini wrote:

Can this be converted to declarative assembly instead?

This one is not trivial to convert to assembly format at least not in the current form.

flang/lib/Optimizer/Dialect/FIROps.cpp

1186

Ok. It's a member function right? How to how access the attribute name in the parser?

[mehdi_amini]

flang/lib/Optimizer/Dialect/FIROps.cpp

1186

Oh right, the parser won't have access to it since it get initialized in the AbstractOperation IIRC

flang/include/flang/Optimizer/Dialect/FIROps.td

let arguments = (ins
     OptionalAttr<UnitAttr>:$constant,
     OptionalAttr<StrAttr>:$linkName
   );
 
   let regions = (region AtMostRegion<1>:$region);
 
   let parser = "return parseGlobalOp(parser, result);";
 
-  let printer = [{
-    if (linkName().hasValue())
-      p << ' ' << linkName().getValue();
-    p << ' ';
-    p.printAttributeWithoutType((*this)->getAttr(symbolAttrName()));
-    if (auto val = getValueOrNull())
-      p << '(' << val << ')';
-    if (constantAttr())
-      p << " constant";
-    p << " : ";
-    p.printType(getType());
-    if (hasInitializationBody())
-      p.printRegion((*this)->getRegion(0), /*printEntryBlockArgs=*/false,
-                    /*printBlockTerminators=*/true);
-  }];
+  let printer = "::print(p, *this);";
 
   let skipDefaultBuilders = 1;
   let builders = [
     OpBuilder<(ins "llvm::StringRef":$name, "mlir::Type":$type,
       CArg<"llvm::ArrayRef<mlir::NamedAttribute>", "{}">:$attrs)>,
     OpBuilder<(ins "llvm::StringRef":$name, "bool":$isConstant,
       "mlir::Type":$type,
       CArg<"llvm::ArrayRef<mlir::NamedAttribute>", "{}">:$attrs)>,
let builders = [
     OpBuilder<(ins "llvm::StringRef":$name, "bool":$isConstant,
       "mlir::Type":$type, "mlir::Attribute":$initVal,
       CArg<"mlir::StringAttr", "{}">:$linkage,
       CArg<"llvm::ArrayRef<mlir::NamedAttribute>", "{}">:$attrs)>,
   ];
 
   let extraClassDeclaration = [{
     static constexpr llvm::StringRef symbolAttrName() { return "symref"; }
+    static constexpr llvm::StringRef getConstantAttrName() {
+      return "constant";
+    }
     static constexpr llvm::StringRef linkageAttrName() { return "linkName"; }
 
     /// The printable type of the global
     mlir::Type getType() {
       return typeAttr().getValue();
     }
 
     /// The semantic type of the global

flang/lib/Optimizer/Dialect/FIROps.cpp

auto parseResult = parser.parseOptionalRegion(
         *result.addRegion(), /*arguments=*/llvm::None, /*argTypes=*/llvm::None);
     if (parseResult.hasValue() && mlir::failed(*parseResult))
       return mlir::failure();
   }
 
   return mlir::success();
 }
 
+static void print(mlir::OpAsmPrinter &p, fir::GlobalOp &op) {
+  if (op.linkName().hasValue())
+    p << ' ' << op.linkName().getValue();
+  p << ' ';
+  p.printAttributeWithoutType(
+      op.getOperation()->getAttr(fir::GlobalOp::symbolAttrName()));
+  if (auto val = op.getValueOrNull())
+    p << '(' << val << ')';
+  if (op.getOperation()->getAttr(fir::GlobalOp::getConstantAttrName()))
+    p << " constant";
+  p << " : ";
+  p.printType(op.getType());
+  if (op.hasInitializationBody())
+    p.printRegion(op.getOperation()->getRegion(0),
+                  /*printEntryBlockArgs=*/false,
+                  /*printBlockTerminators=*/true);
+}
+
 void fir::GlobalOp::appendInitialValue(mlir::Operation *op) {
   getBlock().getOperations().push_back(op);
 }
 
 void fir::GlobalOp::build(mlir::OpBuilder &builder, OperationState &result,
                           StringRef name, bool isConstant, Type type,
                           Attribute initialVal, StringAttr linkage,
                           ArrayRef<NamedAttribute> attrs) {