Page MenuHomePhabricator

[HIPSPV][1/4] Refactor HIP tool chain
Needs ReviewPublic

Authored by linjamaki on Mon, Sep 27, 6:24 AM.

Details

Reviewers
yaxunl
Summary

This patch refactors the HIP tool chain for new HIP tool chain, HIPSPV
tool chain, which is added in the follow up patch part 2.

  • Rename HIPToolChain to HIPAMDToolChain and Renames HIP.* files to HIPAMD.*.
  • Introduce HIPUtility.* file where common HIP utilities, shared among HIP tool chain implementations, are placed in.
  • Move constructHIPFatbinCommand() and constructGenerateObjFileFromHIPFatBinary() to HIPUtility. HIPSPV tool chain is going to use them.
  • Tweak bundle target ID in constructHIPFatbinCommand(): extra dashes are dropped if the Target ID is empty and 'hip' offload kind is made default for non-AMD targets.

Diff Detail

Unit TestsFailed

TimeTest
60 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-cxa-atexit.S
60 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S
Script: -- : 'RUN: at line 7'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-static-initializer.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-static-initializer.S
70 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-tls.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-tls.S

Event Timeline

linjamaki created this revision.Mon, Sep 27, 6:24 AM
linjamaki edited the summary of this revision. (Show Details)Tue, Sep 28, 1:04 AM
linjamaki updated this revision to Diff 375488.Tue, Sep 28, 1:24 AM

Style fixes.

linjamaki published this revision for review.Tue, Sep 28, 1:29 AM
linjamaki edited the summary of this revision. (Show Details)
linjamaki added a reviewer: yaxunl.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Sep 28, 1:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript