- Splitted out some parts of R600 target to separate modules/headers.
- Reduced some include lists in headers.
- Minor forward declarations, redundant includes and flags in GCNSubtarget cleanup.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Drive by only.
llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h | ||
---|---|---|
73 | FWIW, I would recommend static, or anonymous namespaces rather than inline. |
llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h | ||
---|---|---|
15–16 | New "R600ISelDAGToDAG.cpp" uses class AMDGPUDAGToDAGISel declared below in the header. |
What's the point of splitting this out? Nothing outside needs to access this