This is an archive of the discontinued LLVM Phabricator instance.

[IRBuilder][NFC] Clarify docs on fadd/fmul reductions
ClosedPublic

Authored by frasercrmck on Aug 9 2021, 4:12 AM.

Details

Summary

This patch aims to clear up any confusion in documentation for the
fadd/fmul reduction creation APIs with regards to the sequential and
unordered variations without changing the APIs themselves.

The scalar accumulator value isn't only used for sequential reduction
intrinsics so the impliciation to the contrary was dropped. Then I
thought it useful to make clear that the API always creates a sequential
reduction. And lastly a note to users on how it is possible to transform
the resulting reduction into an unordered one.

Diff Detail

Event Timeline

frasercrmck requested review of this revision.Aug 9 2021, 4:12 AM
frasercrmck created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2021, 4:12 AM
This revision is now accepted and ready to land.Aug 9 2021, 9:38 AM
This revision was automatically updated to reflect the committed changes.