This is an archive of the discontinued LLVM Phabricator instance.

Differential D107719

[Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.
ClosedPublic

Authored by gAlfonso-bit on Aug 8 2021, 1:20 PM.

Details

Reviewers
RKSimon
rsmith
riccibruno
c-rhodes
MaskRay
Group Reviewers
Restricted Project
Restricted Project
Commits
rG8bc72dede68c: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from…
Summary

It is completely unused and not needed to be kept, so let us remove it.

Diff Detail

Event Timeline

gAlfonso-bit requested review of this revision.Aug 8 2021, 1:20 PM
gAlfonso-bit created this revision.
Herald added a subscriber: cfe-commits. · View Herald TranscriptAug 8 2021, 1:20 PM
gAlfonso-bit updated this revision to Diff 365042.Aug 8 2021, 1:28 PM
Harbormaster completed remote builds in B118572: Diff 365042.Aug 8 2021, 1:36 PM
gAlfonso-bit updated this revision to Diff 365043.Aug 8 2021, 1:37 PM
gAlfonso-bit updated this revision to Diff 365044.Aug 8 2021, 1:39 PM
gAlfonso-bit added reviewers: Restricted Project, Restricted Project.
Harbormaster completed remote builds in B118574: Diff 365044.Aug 8 2021, 1:47 PM
gAlfonso-bit updated this revision to Diff 365045.Aug 8 2021, 2:06 PM
Harbormaster completed remote builds in B118575: Diff 365045.Aug 8 2021, 2:14 PM
gAlfonso-bit updated this revision to Diff 365046.Aug 8 2021, 2:50 PM
Harbormaster completed remote builds in B118576: Diff 365046.Aug 8 2021, 4:37 PM
gAlfonso-bit retitled this revision from [Clang] Resolve FIXMEs in Types.h to [Clang] Remove unused QualType ElementType member from the ASTContext class..Aug 9 2021, 11:33 AM
gAlfonso-bit edited the summary of this revision. (Show Details)
gAlfonso-bit retitled this revision from [Clang] Remove unused QualType ElementType member from the ASTContext class. to [Clang][AST][NFC] Remove unused QualType ElementType member from the ASTContext class..Aug 9 2021, 11:37 AM
gAlfonso-bit edited the summary of this revision. (Show Details)
gAlfonso-bit set the repository for this revision to rG LLVM Github Monorepo.
gAlfonso-bit retitled this revision from [Clang][AST][NFC] Remove unused QualType ElementType member from the ASTContext class. to [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..
gAlfonso-bit updated this revision to Diff 365249.Aug 9 2021, 11:48 AM
This comment was removed by gAlfonso-bit.
Harbormaster completed remote builds in B118725: Diff 365249.Aug 9 2021, 1:42 PM
gAlfonso-bit added a reviewer: RKSimon.Aug 12 2021, 8:19 AM
This comment was removed by gAlfonso-bit.
RKSimon added reviewers: rsmith, riccibruno, c-rhodes.Aug 12 2021, 9:45 AM
c-rhodes accepted this revision.Aug 12 2021, 11:50 PM
This revision is now accepted and ready to land.Aug 12 2021, 11:50 PM
gAlfonso-bit updated this revision to Diff 366495.Aug 15 2021, 8:17 AM
This comment was removed by gAlfonso-bit.
Herald added a reviewer: MaskRay. · View Herald TranscriptAug 15 2021, 8:17 AM
Herald added subscribers: llvm-commits, tstellar, mgorny. · View Herald Transcript
gAlfonso-bit updated this revision to Diff 366496.Aug 15 2021, 8:17 AM
gAlfonso-bit updated this revision to Diff 366498.Aug 15 2021, 8:20 AM
Harbormaster completed remote builds in B119611: Diff 366498.Aug 15 2021, 8:59 AM
gAlfonso-bit added a comment.Aug 15 2021, 9:26 AM
This comment was removed by gAlfonso-bit.
c-rhodes added a comment.Aug 16 2021, 12:30 AM
In D107719#2945656, @gAlfonso-bit wrote:

Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)?

What's the value in backporting it to 13? It's NFC

RKSimon added a comment.Aug 16 2021, 3:37 AM

@gAlfonso-bit Do you have commit access? I don't think there's any reason to merge this - it fixes no bug or regression - it's just a cleanup.

gAlfonso-bit added a comment.Aug 16 2021, 8:12 AM
This comment was removed by gAlfonso-bit.
gAlfonso-bit added a comment.Aug 16 2021, 8:12 AM
This comment was removed by gAlfonso-bit.
gAlfonso-bit added a comment.Aug 16 2021, 8:32 AM
This comment was removed by gAlfonso-bit.
gAlfonso-bit added a comment.Aug 16 2021, 9:07 AM
This comment was removed by gAlfonso-bit.
Closed by commit rG8bc72dede68c: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from… (authored by gAlfonso-bit, committed by RKSimon). · Explain WhyAug 16 2021, 11:08 AM
This revision was automatically updated to reflect the committed changes.
RKSimon added a commit: rG8bc72dede68c: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from….

Revision Contents

PathSize
clang/
include/
clang/
AST/
4 lines

Diff 366496

clang/include/clang/AST/Type.h

Context not available.
protected: protected:
friend class ASTContext; friend class ASTContext;
/// The element type of the matrix.
// FIXME: Appears to be unused? There is also MatrixType::ElementType...
QualType ElementType;
/// Number of rows and columns. /// Number of rows and columns.
unsigned NumRows; unsigned NumRows;
unsigned NumColumns; unsigned NumColumns;
Context not available.