This is an archive of the discontinued LLVM Phabricator instance.

[Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.
ClosedPublic

Authored by gAlfonso-bit on Aug 8 2021, 1:20 PM.

Details

Summary

It is completely unused and not needed to be kept, so let us remove it.

Diff Detail

Event Timeline

gAlfonso-bit requested review of this revision.Aug 8 2021, 1:20 PM
gAlfonso-bit created this revision.
gAlfonso-bit added reviewers: Restricted Project, Restricted Project.
gAlfonso-bit retitled this revision from [Clang] Resolve FIXMEs in Types.h to [Clang] Remove unused QualType ElementType member from the ASTContext class..Aug 9 2021, 11:33 AM
gAlfonso-bit edited the summary of this revision. (Show Details)
gAlfonso-bit retitled this revision from [Clang] Remove unused QualType ElementType member from the ASTContext class. to [Clang][AST][NFC] Remove unused QualType ElementType member from the ASTContext class..Aug 9 2021, 11:37 AM
gAlfonso-bit edited the summary of this revision. (Show Details)
gAlfonso-bit set the repository for this revision to rG LLVM Github Monorepo.
gAlfonso-bit retitled this revision from [Clang][AST][NFC] Remove unused QualType ElementType member from the ASTContext class. to [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..
This comment was removed by gAlfonso-bit.
This comment was removed by gAlfonso-bit.
c-rhodes accepted this revision.Aug 12 2021, 11:50 PM
This revision is now accepted and ready to land.Aug 12 2021, 11:50 PM
This comment was removed by gAlfonso-bit.
This comment was removed by gAlfonso-bit.

Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)?

What's the value in backporting it to 13? It's NFC

@gAlfonso-bit Do you have commit access? I don't think there's any reason to merge this - it fixes no bug or regression - it's just a cleanup.

This comment was removed by gAlfonso-bit.
This comment was removed by gAlfonso-bit.
This comment was removed by gAlfonso-bit.
This comment was removed by gAlfonso-bit.