This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] swdiv_nochk Builtins for XL Compat
ClosedPublic

Authored by quinnp on Jul 16 2021, 6:50 AM.

Details

Reviewers
nemanjai
stefanp
Group Reviewers
Restricted Project
Commits
rG0268e123bea5: [PowerPC] swdiv_nochk Builtins for XL Compat
Summary

This patch is in a series of patches to provide builtins for
compatibility with the XL compiler. This patch adds software divide
builtins with no checking. These builtins are each emitted as a fast
fdiv.

Diff Detail

Event Timeline

quinnp created this revision.Jul 16 2021, 6:50 AM
quinnp requested review of this revision.Jul 16 2021, 6:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2021, 6:50 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
quinnp added reviewers: Restricted Project, nemanjai, stefanp.Jul 16 2021, 6:51 AM
nemanjai accepted this revision.Jul 16 2021, 6:56 AM

LGTM other than a couple of nits.

clang/lib/CodeGen/CGBuiltin.cpp
15629

Nit: naming convention for variables is that they are capitalized CamelCase.

clang/test/CodeGen/builtins-ppc-xlcompat-swdiv_nochk.c
4

One Linux run line and one AIX run line should suffice.

This revision is now accepted and ready to land.Jul 16 2021, 6:56 AM
quinnp updated this revision to Diff 359310.Jul 16 2021, 7:06 AM

Adressing review comments.

quinnp marked 2 inline comments as done.Jul 16 2021, 7:06 AM
quinnp updated this revision to Diff 359325.Jul 16 2021, 8:01 AM

Fixing a syntax error.

quinnp updated this revision to Diff 359327.Jul 16 2021, 8:08 AM

Removing entry checks from front end test.

This revision was landed with ongoing or failed builds.Jul 19 2021, 2:51 PM
This revision was automatically updated to reflect the committed changes.