Page MenuHomePhabricator

[RegisterCoalescer] Make resolveConflicts aware of earlyclobber
ClosedPublic

Authored by arcbbb on Fri, Jul 9, 2:07 AM.

Details

Summary

Prior to this patch, it skipped the instruction defining VNI when checking if the tainted lanes are used.
In the given example, VRGATHER is an illegal instruction because its DstReg overlaps with SrcReg.

Therefore we need to check the defining instruction as well when there is an earlyclobber constraint.

Diff Detail

Event Timeline

arcbbb created this revision.Fri, Jul 9, 2:07 AM
arcbbb requested review of this revision.Fri, Jul 9, 2:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jul 9, 2:07 AM
arcbbb updated this revision to Diff 357448.Fri, Jul 9, 2:20 AM
arcbbb edited the summary of this revision. (Show Details)

update a test case to show the difference

arcbbb edited the summary of this revision. (Show Details)Fri, Jul 9, 2:33 AM
arcbbb updated this revision to Diff 357459.Fri, Jul 9, 2:46 AM

clang-formatted

arcbbb updated this revision to Diff 357842.Sun, Jul 11, 11:40 PM

Avoid postfix increment operator.

@qcolombet, can you take a look at this?

This revision is now accepted and ready to land.Wed, Jul 21, 9:58 AM
This revision was landed with ongoing or failed builds.Wed, Jul 21, 9:11 PM
This revision was automatically updated to reflect the committed changes.