Add support to load/store i128 atomically.
Details
- Reviewers
jsji nemanjai xingxue amyk hubert.reinterpretcast - Group Reviewers
Restricted Project - Commits
- rG5eaebd5d649a: [PowerPC] Implement quadword atomic load/store
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM with some nits. Thanks!
llvm/lib/Target/PowerPC/PPCISelLowering.cpp | ||
---|---|---|
10447 | nit: multiline after if should be within {/}? | |
10526 | Add comments to all the following code please. | |
12720 | Looks like we can common up most of these code for LQX_PSEUDO/STQX_PSEUDO? Just need additional check for last BuildMI? | |
17363 | So we will set Flag to PPC::MOF_DoubleWordInt for 128. Although we haven't used the flags for now, I think it would be better if we add one more flag for 128? | |
llvm/lib/Target/PowerPC/PPCInstrInfo.cpp | ||
3106 | nit: indent is off? |
clang-tidy: warning: invalid case style for function 'LowerATOMIC_LOAD_STORE' [readability-identifier-naming]
not useful