[analyzer] Allow cmake options to be passed to satest container

[manas]

Summary

This patch selects all cmake options and passes them to global cmake
command while building LLVM inside satest docker container.

Prior to this, the cmake command was hard-coded and this would consume
a huge amount of memory while building. There was no support to pass
extra cmake options for the build, except for changing the command
manually. This patch allows testers to pass all "-D*" cmake options to
the build.

[manas]

Restore global cmake command

[manas]

In D105447#2858740, @manas wrote:

Restore global cmake command

Apparently, my initial observation of LLVM_BUILD_RUNTIME=OFF hogging up memory was false and I also didn't know what was the default value for this option. Hence, I have restored the global cmake command to its previous state.

[manas]

Edit summary

[vsavchenko]

clang/utils/analyzer/entrypoint.py

12

I think we should still use argparse for stuff like this, and we don't want any of these flags to sneak into rest.
https://stackoverflow.com/a/31141568/11582326

[manas]

clang/utils/analyzer/entrypoint.py

12

Understood! I will rework on this. Thanks for the review.

[manas]

Pass commands through settings instead of rest

[vsavchenko]

Awesome, thanks!

[manas]

Gentle ping! I think landing it will make collecting analyzer information easier (in terms of faster build) as more (appropriate) cmake options can be passed via cmdline.

clang/utils/analyzer/entrypoint.py

 import argparse
 import os
 import sys
 
 from subprocess import call, check_call, CalledProcessError
 from time import sleep
 from typing import List, Tuple
 
 
 def main():
     settings, rest = parse_arguments()
+    cmake_opts = ['-D' + cmd for cmd in settings.D]
     if settings.wait:
         wait()
     if settings.build_llvm or settings.build_llvm_only:
-        build_llvm()
+        build_llvm(cmake_opts)
     if settings.build_llvm_only:
         return
     sys.exit(test(rest))
 
 
 def wait():
     # It is an easy on CPU way of keeping the docker container running
     # while the user has a terminal session in that container.
     while True:
         sleep(3600)
 
 
 def parse_arguments() -> Tuple[argparse.Namespace, List[str]]:
     parser = argparse.ArgumentParser()
     parser.add_argument('--wait', action='store_true')
     parser.add_argument('--build-llvm', action='store_true')
     parser.add_argument('--build-llvm-only', action='store_true')
+    parser.add_argument('-D', action='append', default=[])
     return parser.parse_known_args()
 
 
-def build_llvm():
+def build_llvm(cmake_options):
     os.chdir('/build')
     try:
         if is_cmake_needed():
-            cmake()
+            cmake(cmake_options)
         ninja()
     except CalledProcessError:
         print("Build failed!")
         sys.exit(1)
 
 
 def is_cmake_needed():
     return "build.ninja" not in os.listdir()
 
 
 CMAKE_COMMAND = "cmake -G Ninja -DCMAKE_BUILD_TYPE=Release " \
     "-DCMAKE_INSTALL_PREFIX=/analyzer -DLLVM_TARGETS_TO_BUILD=X86 " \
     "-DLLVM_ENABLE_PROJECTS=\"clang;openmp\" -DLLVM_BUILD_RUNTIME=OFF " \
     "-DLLVM_ENABLE_TERMINFO=OFF -DCLANG_ENABLE_ARCMT=OFF " \
     "-DCLANG_ENABLE_STATIC_ANALYZER=ON"
 
 
-def cmake():
-    check_call(CMAKE_COMMAND + ' /llvm-project/llvm', shell=True)
+def cmake(cmake_options):
+    check_call(CMAKE_COMMAND + ' '.join(cmake_options) + ' /llvm-project/llvm',
+            shell=True)
 
 
 def ninja():
     check_call("ninja install", shell=True)
 
 
 def test(args: List[str]) -> int:
     os.chdir("/projects")
     return call("/scripts/SATest.py " + " ".join(args), shell=True)
 
 
 if __name__ == '__main__':
     main()