- User Since
- Apr 6 2020, 5:32 AM (116 w, 4 d)
Apr 28 2022
I guess the only possible scenario that I can imagine here for including these files is tests. Tests for some code tools dealing with patches.
Otherwise, 100% reasonable.
Sep 21 2021
Ooooh, delicious! Diving in!
Sep 6 2021
@aaron.ballman a gentle ping
Aug 20 2021
Finally I had a chance to come back to this patch.
@aaron.ballman what do you think about it? I tried to address your notes and implemented both features under one attribute.
Join 'suppress' and 'analyzer_suppress' attributes.
Aug 17 2021
Now it looks good! Thanks again!
Aug 6 2021
Aug 5 2021
Now it captures (and makes bold) one extra arrow from the previous note.
Correct example attached!
Oh, wait! I found a bug!
Aug 4 2021
Can you please also attach an HTML file just to verify that it works?
I have a couple of nit picks and I kind of want to check that it doesn't affect the performance on a different set of projects as well.
Aug 3 2021
That looks interesting!
Can you please add tests, though?
Aug 2 2021
Jul 29 2021
Awesome, I have nothing to add at this point!
Let's still wait for @aaron.ballman to check it.
Great job! It looks good, but I have a couple of minor tweaks to suggest.
Jul 27 2021
Looks good! Thanks!
Jul 23 2021
Oh, I didn't accept it? Sorry!
Jul 22 2021
It looks reasonable to me, but I can't say that I'm an expert here, and I'm definitely not a frequent z3 user.
Jul 21 2021
Can we please land the fix?
Jul 20 2021
I want to say that I really appreciate the effort you put into finding all the workarounds for IE, but it makes adding new features here incredibly painful because IE doesn't seem to support anything. And the majority of developers (on Linux and on MacOS) have literally no way to test it. What we gain from supporting IE for non-existing users, we lose in the ability to actually improve this code!
Maybe I'm missing something, but do we really need to care about IE? The last version was released in 2013, and even Microsoft itself stops supporting IE. Why should we care? Is there anyone who uses old deprecated browser that is not maintained? classList thing was here for almost 4 years and no one seemed to care. Am I missing something here?
But let's wait for @xazax.hun anyways
Also, I tested this fix on a set of open-source projects and I don't see any problems.
Ah, I see now! I think we could've put together a somewhat easier test knowing what's wrong, but it's not important at all.
Thanks for addressing this issue!
Jul 16 2021
Thanks for working on it, but it is a quite large change that I don't get the motivation for (it doesn't even fix the recently found bug).
Jul 15 2021
Yes, let's do this! Thanks for addressing it!
Jul 14 2021
// 1. `VisitSymbolCast`. // Get a range for main `reg_$0<int x>` - [-2147483648, 2147483647] // Cast main range to `short` - [-2147483648, 2147483647] -> [-32768, 32767]. // Now we get a valid range for further bifurcation - [-32768, 32767].
Jul 13 2021
OK, thanks for putting a summary. I now got a good idea why you need both.
At the same time, take a look at D105692. I'm about to land it and I think it's going to be useful for you.
I'll allocate some time to get into your summary, but for now here are my concerns about SymbolRangeInferrer and VisitSymbolCast.
Jul 12 2021
Jul 9 2021
Can you please explain why you do the same thing in two different ways?
Great! Thanks for addressing all of the comments!
Great, thanks for addressing my comments! I still have a couple of minor suggestions though.
Jul 8 2021
Good job, great to see how you are going through the whole list of methods!
Jul 7 2021
Honestly, I don't really see how this is better.
IMO Printer is something that prints, it should be everything that it does. It can accept different parameters tweaking how it prints in its constructor, but if it is a region printer, you should give it a region, and it should print it. It's not a one-use thing.
Jul 6 2021
This is a very complicated patch, I think we'll have to iterate on it quite a lot.
Additionally, we have to be sure that this doesn't crash our performance.
Jul 5 2021
I compared issues produced by this patch to the issues produced before that on all projects from clang/utils/analyzer/projects, and didn't find any difference.
Jul 2 2021
Also, although the test is very extensive, it is pretty lopsided at the same time. C-style cast is only one case out of the myriad of all explicit and, more importantly, implicit casts.
Hey Manas! Great job, you put this together real quick!
Hey, thanks for starting on splitting into more pieces!
Jun 30 2021
This is incredible! Thanks for addressing it! I've encountered this many times.