[SystemZ][z/OS] Pass OpenFlags when creating tmp files

[abhina.sreeskantharajan]

Summary

This patch https://reviews.llvm.org/D102876 caused some lit regressions on z/OS because tmp files were no longer being opened based on binary/text mode. This patch passes OpenFlags when creating tmp files so we can open files in different modes.

[rnk]

I see, thanks.

llvm/lib/Support/Path.cpp

1296

Instead of requiring the caller to add OF_Delete, I think it would be better to pass OF_Delete | Flags here.

[abhina.sreeskantharajan]

llvm/lib/Support/Path.cpp

1296

Sure, I'll make that change. Do you think we should change the name to "ExtraFlags" to indicate there is a default, or is the current name is fine?

[rnk]

llvm/lib/Support/Path.cpp

1296

That seems reasonable to me, I like ExtraFlags.

[abhina.sreeskantharajan]

Address rnk's comments and rename to ExtraFlags

[amccarth]

LGTM

clang/lib/Frontend/CompilerInstance.cpp

if (UseTemporary) {
     // artifacts, also append .tmp.
     StringRef OutputExtension = llvm::sys::path::extension(OutputPath);
     SmallString<128> TempPath =
         StringRef(OutputPath).drop_back(OutputExtension.size());
     TempPath += "-%%%%%%%%";
     TempPath += OutputExtension;
     TempPath += ".tmp";
     Expected<llvm::sys::fs::TempFile> ExpectedFile =
-        llvm::sys::fs::TempFile::create(TempPath);
+        llvm::sys::fs::TempFile::create(
+            TempPath, llvm::sys::fs::all_read | llvm::sys::fs::all_write,
+            Binary ? llvm::sys::fs::OF_None : llvm::sys::fs::OF_Text);
 
     llvm::Error E = handleErrors(
         ExpectedFile.takeError(), [&](const llvm::ECError &E) -> llvm::Error {
           std::error_code EC = E.convertToErrorCode();
           if (CreateMissingDirectories &&
               EC == llvm::errc::no_such_file_or_directory) {
             StringRef Parent = llvm::sys::path::parent_path(OutputPath);
             EC = llvm::sys::fs::create_directories(Parent);

llvm/include/llvm/Support/FileSystem.h

 class TempFile {
   bool Done = false;
   TempFile(StringRef Name, int FD);
 
 public:
   /// This creates a temporary file with createUniqueFile and schedules it for
   /// deletion with sys::RemoveFileOnSignal.
   static Expected<TempFile> create(const Twine &Model,
-                                   unsigned Mode = all_read | all_write);
+                                   unsigned Mode = all_read | all_write,
+                                   OpenFlags ExtraFlags = OF_None);
   TempFile(TempFile &&Other);
   TempFile &operator=(TempFile &&Other);
 
   // Name of the temporary file.
   std::string TmpName;
 
   // The open file descriptor.
   int FD = -1;

llvm/lib/Support/Path.cpp

if (close(FD) == -1) {
     std::error_code EC(errno, std::generic_category());
     return errorCodeToError(EC);
   }
   FD = -1;
 
   return Error::success();
 }
 
-Expected<TempFile> TempFile::create(const Twine &Model, unsigned Mode) {
+Expected<TempFile> TempFile::create(const Twine &Model, unsigned Mode,
+                                    OpenFlags ExtraFlags) {
   int FD;
   SmallString<128> ResultPath;
   if (std::error_code EC =
-          createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode))
+          createUniqueFile(Model, FD, ResultPath, OF_Delete | ExtraFlags, Mode))
     return errorCodeToError(EC);
 
   TempFile Ret(ResultPath, FD);
 #ifndef _WIN32
   if (sys::RemoveFileOnSignal(ResultPath)) {
     // Make sure we delete the file when RemoveFileOnSignal fails.
     consumeError(Ret.discard());
     std::error_code EC(errc::operation_not_permitted);