Page MenuHomePhabricator

[globalisel][legalizer] Separate the deprecated LegalizerInfo from the current one
ClosedPublic

Authored by dsanders on May 28 2021, 7:38 PM.

Details

Summary

It's still in use in a few places so we can't delete it yet but there's not
many at this point.

Diff Detail

Event Timeline

dsanders created this revision.May 28 2021, 7:38 PM
dsanders requested review of this revision.May 28 2021, 7:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2021, 7:38 PM
Herald added subscribers: MaskRay, wdng. · View Herald Transcript
bogner accepted this revision.Jun 1 2021, 10:39 AM

How much work is left to just remove this completely?

This revision is now accepted and ready to land.Jun 1 2021, 10:39 AM

How much work is left to just remove this completely?

For most targets it's pretty small. AMDGPU only has a few left, and ARM has a couple. Of those, some of them look pretty trivial. However, X86 still has quite a lot

This revision was landed with ongoing or failed builds.Jun 1 2021, 1:24 PM
This revision was automatically updated to reflect the committed changes.

I think I've missed an email discussing this change/deprecation: does it only affect .setAction calls? I.e. if the target only uses builders and doesn't call .setAction could it be affected by this change?