Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

danilaml (Danila Malyutin)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2018, 12:53 PM (286 w, 5 d)

Recent Activity

Fri, Sep 22

danilaml added a comment to D156491: [RA] Split a virtual register in cold blocks if it is not assigned preferred physical register.

@Carrot created an issue with the hang reproducer: https://github.com/llvm/llvm-project/issues/67188

Fri, Sep 22, 12:55 PM · Restricted Project, Restricted Project
danilaml added a comment to D156491: [RA] Split a virtual register in cold blocks if it is not assigned preferred physical register.

This patch also seems to cause near-infinite compile times in same cases (don't know if they actually finish as the process gets killed via OoM). Trying to get a reproducer now.

Fri, Sep 22, 8:52 AM · Restricted Project, Restricted Project

Thu, Sep 14

danilaml committed rGe80a8b4ab61e: [NFC] Add test for #66382 (authored by danilaml).
[NFC] Add test for #66382
Thu, Sep 14, 11:10 AM · Restricted Project, Restricted Project

Tue, Sep 5

danilaml added inline comments to D159162: [llvm] Add assembly syntax highlighting.
Tue, Sep 5, 10:55 AM · Restricted Project, Restricted Project

Mon, Sep 4

danilaml added inline comments to D159162: [llvm] Add assembly syntax highlighting.
Mon, Sep 4, 6:30 AM · Restricted Project, Restricted Project
danilaml added inline comments to D159162: [llvm] Add assembly syntax highlighting.
Mon, Sep 4, 6:26 AM · Restricted Project, Restricted Project

Wed, Aug 30

danilaml accepted D159209: [CodeGen] Fix incorrect insertion point selection for reduction nodes in ComplexDeinterleavingPass.

Not exactly familiar with this part of code, but the fix makes sense to me.
Perhaps we could add a check that OrderedRoots is topologically sorted under EXPENSIVE_CHECKS.

Wed, Aug 30, 10:29 AM · Restricted Project, Restricted Project
danilaml abandoned D159123: [CodeGen] Properly update insertion point of the builder.

Superseded by D159209

Wed, Aug 30, 10:08 AM · Restricted Project, Restricted Project

Tue, Aug 29

danilaml added reviewers for D159123: [CodeGen] Properly update insertion point of the builder: igor.kirillov, NickGuy, mgabka, dmgreen, huntergr.
Tue, Aug 29, 11:00 AM · Restricted Project, Restricted Project
danilaml added inline comments to D159123: [CodeGen] Properly update insertion point of the builder.
Tue, Aug 29, 10:59 AM · Restricted Project, Restricted Project
danilaml requested review of D159123: [CodeGen] Properly update insertion point of the builder.
Tue, Aug 29, 10:58 AM · Restricted Project, Restricted Project
danilaml committed rG2fce8f74b3c0: [CodeGen][AArch64] Commit test for #65044 (authored by danilaml).
[CodeGen][AArch64] Commit test for #65044
Tue, Aug 29, 9:07 AM · Restricted Project, Restricted Project

Aug 25 2023

danilaml committed rGe036ba50a764: [StatepointLowering] Fix possible nullptr access in debug output (authored by danilaml).
[StatepointLowering] Fix possible nullptr access in debug output
Aug 25 2023, 1:08 PM · Restricted Project, Restricted Project
danilaml closed D158866: [StatepointLowering] Fix possible nullptr access in debug output.
Aug 25 2023, 1:08 PM · Restricted Project, Restricted Project
danilaml added inline comments to D158866: [StatepointLowering] Fix possible nullptr access in debug output.
Aug 25 2023, 1:06 PM · Restricted Project, Restricted Project
danilaml updated the summary of D158866: [StatepointLowering] Fix possible nullptr access in debug output.
Aug 25 2023, 10:55 AM · Restricted Project, Restricted Project
danilaml requested review of D158866: [StatepointLowering] Fix possible nullptr access in debug output.
Aug 25 2023, 10:52 AM · Restricted Project, Restricted Project

Aug 22 2023

danilaml added inline comments to D42724: [X86] Don't make 512-bit vectors legal when preferred vector width is 256 bits and 512 bits aren't required.
Aug 22 2023, 12:30 PM · Restricted Project, Restricted Project
danilaml added inline comments to D42724: [X86] Don't make 512-bit vectors legal when preferred vector width is 256 bits and 512 bits aren't required.
Aug 22 2023, 11:37 AM · Restricted Project, Restricted Project
danilaml added inline comments to D42724: [X86] Don't make 512-bit vectors legal when preferred vector width is 256 bits and 512 bits aren't required.
Aug 22 2023, 10:26 AM · Restricted Project, Restricted Project
Herald added projects to D42724: [X86] Don't make 512-bit vectors legal when preferred vector width is 256 bits and 512 bits aren't required: Restricted Project, Restricted Project.
Aug 22 2023, 8:32 AM · Restricted Project, Restricted Project

Aug 8 2023

danilaml added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Current status?

Still requires several patches to commit.

Aug 8 2023, 6:40 AM · Restricted Project, Restricted Project

Jul 28 2023

danilaml accepted D156577: [IRCE] Add NSW to OverflowingBinaryOperator but not BinaryOperator.

LGTM

Jul 28 2023, 6:23 PM · Restricted Project, Restricted Project

Jul 27 2023

danilaml added inline comments to D94964: [LangRef] Describe memory layout for vectors types.
Jul 27 2023, 5:44 PM · Restricted Project, Restricted Project
danilaml added inline comments to D94964: [LangRef] Describe memory layout for vectors types.
Jul 27 2023, 12:06 PM · Restricted Project, Restricted Project

Jul 26 2023

Herald added a project to D94964: [LangRef] Describe memory layout for vectors types: Restricted Project.
Jul 26 2023, 7:26 AM · Restricted Project, Restricted Project

Jul 24 2023

danilaml added inline comments to D155955: [Clang] Improve the handling of large arrays evaluation..
Jul 24 2023, 7:09 AM · Restricted Project, Restricted Project

Jul 20 2023

danilaml committed rGe1aa4e7b383e: [Statepoint] Use correct RegisterClass for spilling (authored by danilaml).
[Statepoint] Use correct RegisterClass for spilling
Jul 20 2023, 6:00 AM · Restricted Project, Restricted Project
danilaml closed D155792: [Statepoint] Use correct RegisterClass for spilling.
Jul 20 2023, 6:00 AM · Restricted Project, Restricted Project
danilaml added reviewers for D155792: [Statepoint] Use correct RegisterClass for spilling: skatkov, DaniilSuchkov, dantrushin.
Jul 20 2023, 12:51 AM · Restricted Project, Restricted Project
danilaml requested review of D155792: [Statepoint] Use correct RegisterClass for spilling.
Jul 20 2023, 12:48 AM · Restricted Project, Restricted Project

Jul 19 2023

danilaml committed rG76fd79b9d537: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi (authored by danilaml).
[X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi
Jul 19 2023, 11:19 PM · Restricted Project, Restricted Project
danilaml committed rGc1013a6eee0c: [X86][AArch64] Add additional extract_lowbits test (authored by danilaml).
[X86][AArch64] Add additional extract_lowbits test
Jul 19 2023, 11:19 PM · Restricted Project, Restricted Project
danilaml closed D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 19 2023, 11:18 PM · Restricted Project, Restricted Project
danilaml closed D155734: [X86][AArch64] Add additional extract_lowbits test.
Jul 19 2023, 11:18 PM · Restricted Project, Restricted Project
danilaml added a comment to D155734: [X86][AArch64] Add additional extract_lowbits test.

LGTM. If possible, you could add new test on the end of the file, so that you won't get a lot of BB number changes.

Jul 19 2023, 11:17 PM · Restricted Project, Restricted Project
danilaml added a comment to D155734: [X86][AArch64] Add additional extract_lowbits test.

Okay, but then add an aarch64 maintainer on the review list (also add phoebe on this one).

Jul 19 2023, 3:13 PM · Restricted Project, Restricted Project
danilaml added a reviewer for D155734: [X86][AArch64] Add additional extract_lowbits test: kristof.beyls.
Jul 19 2023, 3:05 PM · Restricted Project, Restricted Project
danilaml added reviewers for D155734: [X86][AArch64] Add additional extract_lowbits test: pengfei, lebedev.ri, RKSimon.
Jul 19 2023, 3:03 PM · Restricted Project, Restricted Project
danilaml added a comment to D155734: [X86][AArch64] Add additional extract_lowbits test.

Your change is x86 only. Why are you adding aarch64 tests?

Jul 19 2023, 2:04 PM · Restricted Project, Restricted Project
danilaml added inline comments to D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 19 2023, 11:09 AM · Restricted Project, Restricted Project
danilaml added a reviewer for D155734: [X86][AArch64] Add additional extract_lowbits test: goldstein.w.n.
Jul 19 2023, 11:09 AM · Restricted Project, Restricted Project
danilaml added inline comments to D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 19 2023, 11:08 AM · Restricted Project, Restricted Project
danilaml updated the diff for D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.

split new tests pre-changes into separate review

Jul 19 2023, 11:07 AM · Restricted Project, Restricted Project
danilaml requested review of D155734: [X86][AArch64] Add additional extract_lowbits test.
Jul 19 2023, 11:02 AM · Restricted Project, Restricted Project
danilaml updated the diff for D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.

Remove updates to aarch64 test

Jul 19 2023, 9:34 AM · Restricted Project, Restricted Project
danilaml added inline comments to D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 19 2023, 9:33 AM · Restricted Project, Restricted Project
danilaml updated the diff for D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.

Add test with masked nbits

Jul 19 2023, 5:34 AM · Restricted Project, Restricted Project

Jul 18 2023

danilaml added inline comments to D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 18 2023, 10:35 AM · Restricted Project, Restricted Project
danilaml updated the summary of D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 18 2023, 9:59 AM · Restricted Project, Restricted Project
danilaml updated the summary of D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 18 2023, 9:55 AM · Restricted Project, Restricted Project
danilaml requested review of D155622: [X86] Recognize standalone `(1 << nbits) - 1` pattern as bzhi.
Jul 18 2023, 9:54 AM · Restricted Project, Restricted Project

Jul 6 2023

danilaml added a comment to D151021: [llvm-exegesis] Introduce Subprocess Executor Mode.

Having the issues with PTRACE_SEIZE on CentOS 6 (will probably need to build LLVM where for around a year). Don't use llvm-exegesis there, but it's hard to cleanly disable it from build, since tests depend on it.

Jul 6 2023, 12:16 AM · Restricted Project, Restricted Project

Apr 17 2023

danilaml added inline comments to D148514: [BranchFolding] Remove redundant conditional branch..
Apr 17 2023, 1:41 PM · Restricted Project, Restricted Project

Apr 13 2023

danilaml accepted D147910: [IRCE] Relax restrictions on IRCE's latch exit count.

LGTM

Apr 13 2023, 1:16 AM · Restricted Project, Restricted Project

Jan 13 2023

danilaml abandoned D97863: [LSR] adjust isHighCostExpansion function for Mul case.
Jan 13 2023, 5:25 AM · Restricted Project, Restricted Project

Dec 26 2022

danilaml committed rG821a59588b5b: [TwoAddressInstruction] Constrain RegClass when processing a statepoint (authored by danilaml).
[TwoAddressInstruction] Constrain RegClass when processing a statepoint
Dec 26 2022, 8:01 AM · Restricted Project, Restricted Project
danilaml closed D140672: [TwoAddressInstruction] Contrain RegClass when processing a statepoint.
Dec 26 2022, 8:01 AM · Restricted Project, Restricted Project
danilaml updated the diff for D140672: [TwoAddressInstruction] Contrain RegClass when processing a statepoint.

Simplified the test

Dec 26 2022, 7:49 AM · Restricted Project, Restricted Project
danilaml added reviewers for D140672: [TwoAddressInstruction] Contrain RegClass when processing a statepoint: dantrushin, skatkov, MatzeB.
Dec 26 2022, 6:12 AM · Restricted Project, Restricted Project
danilaml requested review of D140672: [TwoAddressInstruction] Contrain RegClass when processing a statepoint.
Dec 26 2022, 6:04 AM · Restricted Project, Restricted Project

Dec 14 2022

danilaml committed rG4a65e6783bee: [InstCombine] return the result of the GEP of PHI transformation early (authored by danilaml).
[InstCombine] return the result of the GEP of PHI transformation early
Dec 14 2022, 4:06 AM · Restricted Project, Restricted Project
danilaml closed D140004: [InstCombine] return the result of the GEP of PHI transformation early.
Dec 14 2022, 4:06 AM · Restricted Project, Restricted Project
danilaml retitled D140004: [InstCombine] return the result of the GEP of PHI transformation early from [InstCombine] return the result of the GEP of PHI transformation early to [InstCombine] return the result of the GEP of PHI transformation early.
Dec 14 2022, 2:46 AM · Restricted Project, Restricted Project
danilaml added a comment to D140004: [InstCombine] return the result of the GEP of PHI transformation early.

Discovered when some downstream analysis wasn't invalidated when this transformation was the only change instcombine made leading to a miscompile. Not sure how to write a good test for this. I remember there being a pass that verified that passes correctly reported changed IR but I think it only worked for legacy pm.

Dec 14 2022, 2:42 AM · Restricted Project, Restricted Project
danilaml requested review of D140004: [InstCombine] return the result of the GEP of PHI transformation early.
Dec 14 2022, 2:36 AM · Restricted Project, Restricted Project

Sep 13 2022

danilaml added a comment to D132799: Make sure libLLVM users link with libatomic if needed.

I've experienced similar linking issues (-lz not resolved) when cross-compiling since ZLIB was initially picked from cross-build sysroot with a full path but simply using -lz is not enough to find a target zlib.

Sep 13 2022, 6:27 AM · Restricted Project, Restricted Project

Aug 18 2022

danilaml committed rG4a9ff289fbaa: [InstCombine] Fix freeze instruction getting inserted before landingpad (authored by danilaml).
[InstCombine] Fix freeze instruction getting inserted before landingpad
Aug 18 2022, 7:44 AM · Restricted Project, Restricted Project
danilaml closed D132105: [InstCombine] Fix freeze instruction getting inserted before landingpad.
Aug 18 2022, 7:44 AM · Restricted Project, Restricted Project
danilaml updated the diff for D132105: [InstCombine] Fix freeze instruction getting inserted before landingpad.

Simplified lit test a little

Aug 18 2022, 5:29 AM · Restricted Project, Restricted Project

Aug 17 2022

danilaml added reviewers for D132105: [InstCombine] Fix freeze instruction getting inserted before landingpad: nikic, spatel, lebedev.ri, mtrofin, hyeongyukim.
Aug 17 2022, 11:58 PM · Restricted Project, Restricted Project
danilaml requested review of D132105: [InstCombine] Fix freeze instruction getting inserted before landingpad.
Aug 17 2022, 11:54 PM · Restricted Project, Restricted Project

Aug 16 2022

danilaml added inline comments to D131146: [RS4GC] Handle vectors of pointers in non-live clobbering.
Aug 16 2022, 7:50 AM · Restricted Project, Restricted Project
danilaml committed rG451497a030d7: [RS4GC] Handle vectors of pointers in non-live clobbering (authored by danilaml).
[RS4GC] Handle vectors of pointers in non-live clobbering
Aug 16 2022, 7:48 AM · Restricted Project, Restricted Project
danilaml closed D131146: [RS4GC] Handle vectors of pointers in non-live clobbering.
Aug 16 2022, 7:47 AM · Restricted Project, Restricted Project

Aug 4 2022

danilaml added reviewers for D131146: [RS4GC] Handle vectors of pointers in non-live clobbering: reames, mkazantsev, apilipenko, skatkov.
Aug 4 2022, 12:15 AM · Restricted Project, Restricted Project
danilaml added inline comments to D131146: [RS4GC] Handle vectors of pointers in non-live clobbering.
Aug 4 2022, 12:14 AM · Restricted Project, Restricted Project
danilaml requested review of D131146: [RS4GC] Handle vectors of pointers in non-live clobbering.
Aug 4 2022, 12:10 AM · Restricted Project, Restricted Project

Jun 16 2022

danilaml accepted D127294: [AARCH64 folding] Do not fold any copy with NZCV.

LGTM

Jun 16 2022, 12:05 AM · Restricted Project, Restricted Project

Jun 14 2022

danilaml committed rG3b54aa9eab82: freeze does not change the constant property (authored by danilaml).
freeze does not change the constant property
Jun 14 2022, 9:54 AM · Restricted Project, Restricted Project
danilaml closed D127744: freeze does not change the constant property.
Jun 14 2022, 9:53 AM · Restricted Project, Restricted Project
danilaml added a comment to D127744: freeze does not change the constant property.

Non blocking comment..

freeze(undef) being equally null or base as undef seems questionable to me. I think in practice it might work out okay, but there's no guarantee that the value chosen for undef isn't 0 when frozen, and 1 when not. You might want to step back and take a deeper look at the problem you're solving here.

Jun 14 2022, 8:49 AM · Restricted Project, Restricted Project
danilaml added reviewers for D127744: freeze does not change the constant property: reames, anna, skatkov, mkazantsev.
Jun 14 2022, 7:46 AM · Restricted Project, Restricted Project
danilaml requested review of D127744: freeze does not change the constant property.
Jun 14 2022, 7:45 AM · Restricted Project, Restricted Project

Jun 10 2022

danilaml added a reviewer for D127294: [AARCH64 folding] Do not fold any copy with NZCV: t.p.northover.
Jun 10 2022, 4:13 AM · Restricted Project, Restricted Project

Jun 8 2022

danilaml committed rGed6c309d4bf6: [APFloat] Fix truncation of certain subnormal numbers (authored by danilaml).
[APFloat] Fix truncation of certain subnormal numbers
Jun 8 2022, 11:55 AM · Restricted Project, Restricted Project
danilaml closed D127140: [APFloat] Fix truncation of certain subnormal numbers.
Jun 8 2022, 11:55 AM · Restricted Project, Restricted Project
danilaml added a comment to D127140: [APFloat] Fix truncation of certain subnormal numbers.

@efriedma I've added float->bloat16 conversion tests but I'm not sure these are exact same you had in mind.

Jun 8 2022, 7:23 AM · Restricted Project, Restricted Project
danilaml updated the diff for D127140: [APFloat] Fix truncation of certain subnormal numbers.

Added float->bfloat conversion tests

Jun 8 2022, 7:22 AM · Restricted Project, Restricted Project

Jun 7 2022

danilaml updated the diff for D127140: [APFloat] Fix truncation of certain subnormal numbers.

Submitted an alternative solution (adjusting the shift/exponent)

Jun 7 2022, 10:24 AM · Restricted Project, Restricted Project
danilaml added a comment to D127140: [APFloat] Fix truncation of certain subnormal numbers.

I'm not sure it's safe to assume that the lost fraction is lfLessThanHalf, in general. At least, it isn't obvious to me, particularly for cases involving bfloat.

We already have a bunch of code to adjust the shift amount for truncations: the "If this is a truncation of a denormal number [...]" block. Can we adjust that code to reduce the shift amount in this case?

Jun 7 2022, 7:42 AM · Restricted Project, Restricted Project

Jun 6 2022

danilaml added reviewers for D127140: [APFloat] Fix truncation of certain subnormal numbers: spatel, efriedma.
Jun 6 2022, 11:37 AM · Restricted Project, Restricted Project
danilaml added inline comments to D127140: [APFloat] Fix truncation of certain subnormal numbers.
Jun 6 2022, 11:36 AM · Restricted Project, Restricted Project
danilaml requested review of D127140: [APFloat] Fix truncation of certain subnormal numbers.
Jun 6 2022, 11:33 AM · Restricted Project, Restricted Project

May 31 2022

danilaml committed rG4fb3fd7d8206: [InstCombine] Fix const folding of switches with default case (authored by danilaml).
[InstCombine] Fix const folding of switches with default case
May 31 2022, 5:14 AM · Restricted Project, Restricted Project
danilaml closed D126650: [InstCombine] Fix const folding of switched with default case.
May 31 2022, 5:14 AM · Restricted Project, Restricted Project

May 30 2022

danilaml updated the diff for D126650: [InstCombine] Fix const folding of switched with default case.

Addressed the comments

May 30 2022, 8:56 AM · Restricted Project, Restricted Project
danilaml added inline comments to D126650: [InstCombine] Fix const folding of switched with default case.
May 30 2022, 7:51 AM · Restricted Project, Restricted Project
danilaml added a reviewer for D126650: [InstCombine] Fix const folding of switched with default case: nikic.
May 30 2022, 6:44 AM · Restricted Project, Restricted Project
danilaml requested review of D126650: [InstCombine] Fix const folding of switched with default case.
May 30 2022, 6:41 AM · Restricted Project, Restricted Project