Page MenuHomePhabricator

danilaml (Danila Malyutin)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2018, 12:53 PM (222 w, 6 d)

Recent Activity

Thu, Jun 16

danilaml accepted D127294: [AARCH64 folding] Do not fold any copy with NZCV.

LGTM

Thu, Jun 16, 12:05 AM · Restricted Project, Restricted Project

Tue, Jun 14

danilaml committed rG3b54aa9eab82: freeze does not change the constant property (authored by danilaml).
freeze does not change the constant property
Tue, Jun 14, 9:54 AM · Restricted Project, Restricted Project
danilaml closed D127744: freeze does not change the constant property.
Tue, Jun 14, 9:53 AM · Restricted Project, Restricted Project
danilaml added a comment to D127744: freeze does not change the constant property.

Non blocking comment..

freeze(undef) being equally null or base as undef seems questionable to me. I think in practice it might work out okay, but there's no guarantee that the value chosen for undef isn't 0 when frozen, and 1 when not. You might want to step back and take a deeper look at the problem you're solving here.

Tue, Jun 14, 8:49 AM · Restricted Project, Restricted Project
danilaml added reviewers for D127744: freeze does not change the constant property: reames, anna, skatkov, mkazantsev.
Tue, Jun 14, 7:46 AM · Restricted Project, Restricted Project
danilaml requested review of D127744: freeze does not change the constant property.
Tue, Jun 14, 7:45 AM · Restricted Project, Restricted Project

Fri, Jun 10

danilaml added a reviewer for D127294: [AARCH64 folding] Do not fold any copy with NZCV: t.p.northover.
Fri, Jun 10, 4:13 AM · Restricted Project, Restricted Project

Wed, Jun 8

danilaml committed rGed6c309d4bf6: [APFloat] Fix truncation of certain subnormal numbers (authored by danilaml).
[APFloat] Fix truncation of certain subnormal numbers
Wed, Jun 8, 11:55 AM · Restricted Project, Restricted Project
danilaml closed D127140: [APFloat] Fix truncation of certain subnormal numbers.
Wed, Jun 8, 11:55 AM · Restricted Project, Restricted Project
danilaml added a comment to D127140: [APFloat] Fix truncation of certain subnormal numbers.

@efriedma I've added float->bloat16 conversion tests but I'm not sure these are exact same you had in mind.

Wed, Jun 8, 7:23 AM · Restricted Project, Restricted Project
danilaml updated the diff for D127140: [APFloat] Fix truncation of certain subnormal numbers.

Added float->bfloat conversion tests

Wed, Jun 8, 7:22 AM · Restricted Project, Restricted Project

Tue, Jun 7

danilaml updated the diff for D127140: [APFloat] Fix truncation of certain subnormal numbers.

Submitted an alternative solution (adjusting the shift/exponent)

Tue, Jun 7, 10:24 AM · Restricted Project, Restricted Project
danilaml added a comment to D127140: [APFloat] Fix truncation of certain subnormal numbers.

I'm not sure it's safe to assume that the lost fraction is lfLessThanHalf, in general. At least, it isn't obvious to me, particularly for cases involving bfloat.

We already have a bunch of code to adjust the shift amount for truncations: the "If this is a truncation of a denormal number [...]" block. Can we adjust that code to reduce the shift amount in this case?

Tue, Jun 7, 7:42 AM · Restricted Project, Restricted Project

Mon, Jun 6

danilaml added reviewers for D127140: [APFloat] Fix truncation of certain subnormal numbers: spatel, efriedma.
Mon, Jun 6, 11:37 AM · Restricted Project, Restricted Project
danilaml added inline comments to D127140: [APFloat] Fix truncation of certain subnormal numbers.
Mon, Jun 6, 11:36 AM · Restricted Project, Restricted Project
danilaml requested review of D127140: [APFloat] Fix truncation of certain subnormal numbers.
Mon, Jun 6, 11:33 AM · Restricted Project, Restricted Project

May 31 2022

danilaml committed rG4fb3fd7d8206: [InstCombine] Fix const folding of switches with default case (authored by danilaml).
[InstCombine] Fix const folding of switches with default case
May 31 2022, 5:14 AM · Restricted Project, Restricted Project
danilaml closed D126650: [InstCombine] Fix const folding of switched with default case.
May 31 2022, 5:14 AM · Restricted Project, Restricted Project

May 30 2022

danilaml updated the diff for D126650: [InstCombine] Fix const folding of switched with default case.

Addressed the comments

May 30 2022, 8:56 AM · Restricted Project, Restricted Project
danilaml added inline comments to D126650: [InstCombine] Fix const folding of switched with default case.
May 30 2022, 7:51 AM · Restricted Project, Restricted Project
danilaml added a reviewer for D126650: [InstCombine] Fix const folding of switched with default case: nikic.
May 30 2022, 6:44 AM · Restricted Project, Restricted Project
danilaml requested review of D126650: [InstCombine] Fix const folding of switched with default case.
May 30 2022, 6:41 AM · Restricted Project, Restricted Project

Mar 25 2022

danilaml added a comment to D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

hashlib should have deterministic hash functions.

Mar 25 2022, 5:59 AM · Restricted Project, Restricted Project

Mar 2 2022

danilaml committed rGff33b6f90ac2: [Support][AArch64] Detect a few more host CPU features on AArch64 (authored by danilaml).
[Support][AArch64] Detect a few more host CPU features on AArch64
Mar 2 2022, 10:31 PM · Restricted Project
danilaml closed D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.
Mar 2 2022, 10:30 PM · Restricted Project, Restricted Project

Mar 1 2022

danilaml added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.

@peter.smith @nickdesaulniers What needs to be done to move forward with this? Do I need to add more procinfo<>feature mappings? Implement a new way to get features entirely?

Mar 1 2022, 8:04 AM · Restricted Project, Restricted Project

Feb 22 2022

danilaml added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.

This file describes the ABI for exporting the AArch64 CPU ID/feature registers to userspace. The availability of this ABI is advertised via the HWCAP_CPUID in HWCAPs.

and

https://github.com/rust-lang/rust/blob/master/src/tools/rustfmt/tests/source/cfg_if/detect/os/aarch64.rs

So it should be possible from user space.

https://reviews.llvm.org/D92619

Feb 22 2022, 7:01 AM · Restricted Project, Restricted Project

Feb 11 2022

danilaml added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.
Feb 11 2022, 6:22 PM · Restricted Project, Restricted Project
danilaml updated the summary of D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.
Feb 11 2022, 6:55 AM · Restricted Project, Restricted Project
danilaml added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.

You'll have to forgive me, I'm coming at this without a lot of context other than what is supported on what Arm architecture, and I didn't have time to reverse engineer it from the code. Thanks for the link, that makes it look like this is related to something like parsing proc/cpuinfo and nowhere else.

If that is the case, would it be possible to update the description with a bit more context, including the link you posted to the available values. Many of the reviewers here won't have the linux context so it can help reviewers if they know what they need to check for.

If this is indeed linux related, may I suggest adding nickdesaulniers as a reviewer. He has been involved in clang built linux project and may know more people that can help from the linux kernel side. If we are going to add more features it would be good to think about what we need to support in total and how to get there across one or more patches.

For testing, given that this is something from the environment I think it would require a unit-test if done on the LLVM side. Making one of those would be good, but quite a bit of work, would be good to put a comment in the description for the benefit of other reviewers.

Feb 11 2022, 6:53 AM · Restricted Project, Restricted Project
danilaml added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.

I think we need to be careful here. The extensions in that StringSwitch are for Armv8-a and hence applicable to all AArch64 CPUs. Things like sve are only available on later processors. We'll need to check to see what the intent was here before adding things. We'll also need to work out how to add tests for these, a good idea would be to see how the existing ones are tested.

Got a bit too much on at the moment to look into this in detail. May have some time next week.

Feb 11 2022, 3:23 AM · Restricted Project, Restricted Project

Feb 10 2022

danilaml added reviewers for D119435: [Support][AArch64] Detect a few more host CPU features on AArch64: mstorsjo, bsmith, peter.smith.
Feb 10 2022, 6:39 AM · Restricted Project, Restricted Project
danilaml added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.

Compared to X86, there is a LOT missing (and this hasn't really been updated since ~2014), but at least add a few basic ones.

Feb 10 2022, 6:35 AM · Restricted Project, Restricted Project
danilaml requested review of D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.
Feb 10 2022, 6:34 AM · Restricted Project, Restricted Project

Jan 25 2022

danilaml committed rG153b1e3cba1e: [AArch64] Add patterns for relaxed atomic ld/st into fp registers (authored by danilaml).
[AArch64] Add patterns for relaxed atomic ld/st into fp registers
Jan 25 2022, 4:34 AM
danilaml closed D117573: [AArch64] Add patterns for relaxed atomic ld/st into fp registers.
Jan 25 2022, 4:34 AM · Restricted Project

Jan 20 2022

danilaml added a comment to D117573: [AArch64] Add patterns for relaxed atomic ld/st into fp registers.

You mention unimplemented hooks in D60394 and on the github issue, so why did you go for this approach instead? Solving this in a generic manner seems like the 'good' thing to do, no?

Jan 20 2022, 11:44 AM · Restricted Project

Jan 18 2022

danilaml added reviewers for D117573: [AArch64] Add patterns for relaxed atomic ld/st into fp registers: t.p.northover, samparker, aemerson, paquette.
Jan 18 2022, 9:36 AM · Restricted Project
danilaml requested review of D117573: [AArch64] Add patterns for relaxed atomic ld/st into fp registers.
Jan 18 2022, 9:30 AM · Restricted Project

Dec 30 2021

danilaml added a comment to D60394: [X86] Add patterns for using movss/movsd for atomic load/store of f32/64. Remove atomic fadd pseudos use isel patterns instead..

I wonder if instead of matching bitcasts, implementing TODOs (hooks) form here https://reviews.llvm.org/D15471 was considered.

Dec 30 2021, 4:55 AM · Restricted Project

Nov 26 2021

danilaml accepted D114337: Support Windows.

LGTM

Nov 26 2021, 7:11 AM · Restricted Project

Nov 25 2021

danilaml added inline comments to D114337: Support Windows.
Nov 25 2021, 11:28 AM · Restricted Project
danilaml added inline comments to D114337: Support Windows.
Nov 25 2021, 5:34 AM · Restricted Project

Nov 21 2021

danilaml added inline comments to D114337: Support Windows.
Nov 21 2021, 7:36 AM · Restricted Project

Nov 17 2021

danilaml accepted D114098: Use BinaryCacheRoot calling IsSharedObject() .
Nov 17 2021, 9:18 PM · Restricted Project

Oct 25 2021

danilaml committed rG7b102fcc9116: [CodeGen] Fix dependence breaking for tied operands (authored by danilaml).
[CodeGen] Fix dependence breaking for tied operands
Oct 25 2021, 8:53 AM
danilaml closed D107582: [CodeGen] Fix dependence breaking for tied operands.
Oct 25 2021, 8:53 AM · Restricted Project
danilaml committed rG2d9ee590b667: [AArch64] Handle ST1iN instructions in isAArch64FrameOffsetLegal (authored by danilaml).
[AArch64] Handle ST1iN instructions in isAArch64FrameOffsetLegal
Oct 25 2021, 7:06 AM
danilaml closed D112311: [AArch64] Handle ST1iN instructions in isAArch64FrameOffsetLegal.
Oct 25 2021, 7:06 AM · Restricted Project
danilaml updated the diff for D112311: [AArch64] Handle ST1iN instructions in isAArch64FrameOffsetLegal.

Changed test to MIR and added STi64 case

Oct 25 2021, 6:34 AM · Restricted Project
danilaml added inline comments to D112311: [AArch64] Handle ST1iN instructions in isAArch64FrameOffsetLegal.
Oct 25 2021, 6:02 AM · Restricted Project

Oct 22 2021

danilaml updated the summary of D112311: [AArch64] Handle ST1iN instructions in isAArch64FrameOffsetLegal.
Oct 22 2021, 5:45 AM · Restricted Project
danilaml requested review of D112311: [AArch64] Handle ST1iN instructions in isAArch64FrameOffsetLegal.
Oct 22 2021, 5:34 AM · Restricted Project

Oct 21 2021

danilaml added inline comments to D111533: [SCEV] Invalidate user SCEVs along with operand SCEVs to avoid cache corruption.
Oct 21 2021, 6:46 AM · Restricted Project

Oct 18 2021

danilaml added inline comments to D107582: [CodeGen] Fix dependence breaking for tied operands.
Oct 18 2021, 12:38 PM · Restricted Project
danilaml updated the diff for D107582: [CodeGen] Fix dependence breaking for tied operands.

Addressed comments

Oct 18 2021, 12:37 PM · Restricted Project
danilaml added a comment to D107582: [CodeGen] Fix dependence breaking for tied operands.

The overall issue here is that this pass doesn't seem to correctly handle instructions with implicit defs and tied reg operands. One case of it was fixed in https://reviews.llvm.org/D4351 , and this tries to fix similar issue (see the end of the summary and the test case)

Correct me if I'm wrong, but my impression of D4351 / line 225/226 is that the pass intends to simply not deal with tied-operands at all (regardless of implicit defs/uses being present or not); that seems reasonable enough for me. Though line 226 somehow stopped that logic from kicking in when there are undef operands involved right? So it seems to me the bug happens when you have a tied + undef operand at the same time? I don't see yet how (or if at all) implicit defs/uses play into the picture.

Oct 18 2021, 12:17 PM · Restricted Project
danilaml added a comment to D107582: [CodeGen] Fix dependence breaking for tied operands.

@MatzeB Do you have any thoughts on this?

Unfortunately this pass has a very unconventional way to analyze things and manage liveness. It's hard to understand what is going on, so it's hard to judge changes to this pass...

Oct 18 2021, 10:18 AM · Restricted Project
danilaml added a comment to D107582: [CodeGen] Fix dependence breaking for tied operands.

ping

Oct 18 2021, 6:33 AM · Restricted Project

Sep 22 2021

danilaml added a comment to D107582: [CodeGen] Fix dependence breaking for tied operands.

ping

Sep 22 2021, 9:32 AM · Restricted Project

Sep 21 2021

danilaml committed rG78b51c7a2cb6: [LSR] Make sure that Factor fits into Base type (authored by danilaml).
[LSR] Make sure that Factor fits into Base type
Sep 21 2021, 10:51 AM
danilaml closed D108772: [LSR] Make sure that Factor fits into Base type.
Sep 21 2021, 10:51 AM · Restricted Project

Sep 17 2021

danilaml added inline comments to D108772: [LSR] Make sure that Factor fits into Base type.
Sep 17 2021, 5:21 PM · Restricted Project
danilaml updated the diff for D108772: [LSR] Make sure that Factor fits into Base type.

Add more comments to the test

Sep 17 2021, 5:12 PM · Restricted Project
danilaml added inline comments to D108772: [LSR] Make sure that Factor fits into Base type.
Sep 17 2021, 6:25 AM · Restricted Project
danilaml updated the diff for D108772: [LSR] Make sure that Factor fits into Base type.

Addressed Quentin's comments

Sep 17 2021, 6:22 AM · Restricted Project

Sep 15 2021

danilaml added a comment to D108772: [LSR] Make sure that Factor fits into Base type.

Ping

Sep 15 2021, 6:36 AM · Restricted Project

Sep 6 2021

danilaml added a comment to D108772: [LSR] Make sure that Factor fits into Base type.

ping

Sep 6 2021, 7:19 AM · Restricted Project

Aug 31 2021

danilaml added a comment to D107582: [CodeGen] Fix dependence breaking for tied operands.

ping?

Aug 31 2021, 7:35 AM · Restricted Project

Aug 30 2021

danilaml updated the diff for D108772: [LSR] Make sure that Factor fits into Base type.

Addressed Anna's suggestions

Aug 30 2021, 8:53 AM · Restricted Project
danilaml committed rG668b045b8d9f: [LSR][NFC] Add test case for pr42770 (authored by danilaml).
[LSR][NFC] Add test case for pr42770
Aug 30 2021, 8:47 AM

Aug 27 2021

danilaml updated the diff for D108772: [LSR] Make sure that Factor fits into Base type.

Add missing REQUIRES: asserts

Aug 27 2021, 2:39 PM · Restricted Project

Aug 26 2021

danilaml added inline comments to D108772: [LSR] Make sure that Factor fits into Base type.
Aug 26 2021, 11:19 AM · Restricted Project
danilaml added reviewers for D108772: [LSR] Make sure that Factor fits into Base type: atrick, qcolombet, mzolotukhin, DaniilSuchkov.
Aug 26 2021, 11:05 AM · Restricted Project
danilaml requested review of D108772: [LSR] Make sure that Factor fits into Base type.
Aug 26 2021, 11:03 AM · Restricted Project
danilaml added reviewers for D107582: [CodeGen] Fix dependence breaking for tied operands: timshen, qcolombet.
Aug 26 2021, 5:24 AM · Restricted Project

Aug 16 2021

danilaml added a comment to D107582: [CodeGen] Fix dependence breaking for tied operands.

Ping.
I'm tempted to just disable all dep breaking for implicit-def registers, but I fear that it might be too pessimistic for x86_64.

Aug 16 2021, 8:31 AM · Restricted Project

Aug 13 2021

danilaml added inline comments to rG9075864b7375: [BasicAA] Refactor linear expression decomposition.
Aug 13 2021, 4:47 AM

Aug 11 2021

danilaml added inline comments to rG9075864b7375: [BasicAA] Refactor linear expression decomposition.
Aug 11 2021, 6:46 AM
danilaml added inline comments to rG9075864b7375: [BasicAA] Refactor linear expression decomposition.
Aug 11 2021, 6:13 AM
danilaml added inline comments to rG9075864b7375: [BasicAA] Refactor linear expression decomposition.
Aug 11 2021, 4:23 AM

Aug 10 2021

danilaml added inline comments to rG9075864b7375: [BasicAA] Refactor linear expression decomposition.
Aug 10 2021, 10:27 AM
danilaml added inline comments to rG9075864b7375: [BasicAA] Refactor linear expression decomposition.
Aug 10 2021, 10:25 AM
danilaml added inline comments to rG9075864b7375: [BasicAA] Refactor linear expression decomposition.
Aug 10 2021, 10:03 AM

Aug 5 2021

danilaml updated the summary of D107582: [CodeGen] Fix dependence breaking for tied operands.
Aug 5 2021, 10:16 AM · Restricted Project
danilaml requested review of D107582: [CodeGen] Fix dependence breaking for tied operands.
Aug 5 2021, 9:54 AM · Restricted Project

Aug 3 2021

Herald added a project to D4351: bug fix for PR20020: anti-dependency-breaker causes miscompilation: Restricted Project.
Aug 3 2021, 7:26 AM · Restricted Project

Jul 5 2021

danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Rebased

Jul 5 2021, 10:31 AM · Restricted Project

Jun 23 2021

danilaml added a comment to D79555: [libc++] [C++20] [P0415] Constexpr for std::complex..

ping?

Jun 23 2021, 5:46 AM · Restricted Project

Jun 22 2021

danilaml committed rG2ef1fbfe0e34: Add norm sub-target feature to table gen for ARC (authored by thomasjohns).
Add norm sub-target feature to table gen for ARC
Jun 22 2021, 4:40 AM
danilaml closed D104558: Add norm sub-target feature to table gen for ARC.
Jun 22 2021, 4:40 AM · Restricted Project

Jun 21 2021

danilaml accepted D104558: Add norm sub-target feature to table gen for ARC.

Test failures appear unrelated.

Jun 21 2021, 8:48 AM · Restricted Project

Jun 9 2021

danilaml added a comment to D103352: [globalisel][legalizer] Separate the deprecated LegalizerInfo from the current one.

I think I've missed an email discussing this change/deprecation: does it only affect .setAction calls? I.e. if the target only uses builders and doesn't call .setAction could it be affected by this change?

Jun 9 2021, 7:40 AM · Restricted Project

Jun 4 2021

danilaml committed rG12592a439ae5: Add commutable attribute to opcodes for ARC (authored by marksl).
Add commutable attribute to opcodes for ARC
Jun 4 2021, 9:55 AM
danilaml closed D103653: Add commutable attribute to opcodes for ARC.
Jun 4 2021, 9:55 AM · Restricted Project
danilaml added a comment to D101835: [llvm] llvm-tapi-diff.

I'm pretty sure this also causes a build failure on older, but supported versions of GCC due to this bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480):

../tools/llvm-tapi-diff/DiffEngine.cpp:35:71: error: specialization of template<class T, llvm::DiffAttrKind U> void llvm::DiffScalarVal<T, U>::print(llvm::raw_ostream&, std::__cxx11::string) in different namespace [-fpermissive]
                                                     std::string Indent) {
                                                                       ^
Jun 4 2021, 8:46 AM · Restricted Project
danilaml accepted D103653: Add commutable attribute to opcodes for ARC.

LGTM

Jun 4 2021, 5:37 AM · Restricted Project

May 31 2021

danilaml added a comment to D102092: [lldb] Enable -Wmisleading-indentation.

I remember some noise due to this option (albeit on GCC), because it stops tracking indentation when the number of lines is too big, as it is for files including TableGen'ed inc files. Not sure if there is a way to improve it.

May 31 2021, 8:02 AM · Restricted Project, Restricted Project

May 17 2021

danilaml added a comment to rGd4d80a2903c1: Bump googletest to 1.10.0.

This compilation error (reproducible on GCC 6.2) is still not fixed unfortunately:

../unittests/IR/PassBuilderCallbacksTest.cpp: In member function ‘virtual void {anonymous}::LoopCallbacksTest_InstrumentedInvalidatingPasses_Test::TestBody()’:
May 17 2021, 4:22 AM

Apr 29 2021

danilaml committed rZORG41979ca6ea64: [zorg] Add buildbot for Synopsys ARC (authored by Lily_He).
[zorg] Add buildbot for Synopsys ARC
Apr 29 2021, 5:43 AM