User Details
- User Since
- Mar 28 2018, 12:53 PM (222 w, 6 d)
Thu, Jun 16
LGTM
Tue, Jun 14
Fri, Jun 10
Wed, Jun 8
@efriedma I've added float->bloat16 conversion tests but I'm not sure these are exact same you had in mind.
Added float->bfloat conversion tests
Tue, Jun 7
Submitted an alternative solution (adjusting the shift/exponent)
Mon, Jun 6
May 31 2022
May 30 2022
Addressed the comments
Mar 25 2022
hashlib should have deterministic hash functions.
Mar 2 2022
Mar 1 2022
@peter.smith @nickdesaulniers What needs to be done to move forward with this? Do I need to add more procinfo<>feature mappings? Implement a new way to get features entirely?
Feb 22 2022
Feb 11 2022
Feb 10 2022
Compared to X86, there is a LOT missing (and this hasn't really been updated since ~2014), but at least add a few basic ones.
Jan 25 2022
Jan 20 2022
Jan 18 2022
Dec 30 2021
I wonder if instead of matching bitcasts, implementing TODOs (hooks) form here https://reviews.llvm.org/D15471 was considered.
Nov 26 2021
Nov 25 2021
Nov 21 2021
Nov 17 2021
Oct 25 2021
Changed test to MIR and added STi64 case
Oct 22 2021
Oct 21 2021
Oct 18 2021
Addressed comments
ping
Sep 22 2021
ping
Sep 21 2021
Sep 17 2021
Add more comments to the test
Addressed Quentin's comments
Sep 15 2021
Ping
Sep 6 2021
ping
Aug 31 2021
ping?
Aug 30 2021
Addressed Anna's suggestions
Aug 27 2021
Add missing REQUIRES: asserts
Aug 26 2021
Aug 16 2021
Ping.
I'm tempted to just disable all dep breaking for implicit-def registers, but I fear that it might be too pessimistic for x86_64.
Aug 13 2021
Aug 11 2021
Aug 10 2021
Aug 5 2021
Aug 3 2021
Jul 5 2021
Rebased
Jun 23 2021
ping?
Jun 22 2021
Jun 21 2021
Test failures appear unrelated.
Jun 9 2021
I think I've missed an email discussing this change/deprecation: does it only affect .setAction calls? I.e. if the target only uses builders and doesn't call .setAction could it be affected by this change?
Jun 4 2021
I'm pretty sure this also causes a build failure on older, but supported versions of GCC due to this bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480):
../tools/llvm-tapi-diff/DiffEngine.cpp:35:71: error: specialization of template<class T, llvm::DiffAttrKind U> void llvm::DiffScalarVal<T, U>::print(llvm::raw_ostream&, std::__cxx11::string) in different namespace [-fpermissive] std::string Indent) { ^
LGTM
May 31 2021
I remember some noise due to this option (albeit on GCC), because it stops tracking indentation when the number of lines is too big, as it is for files including TableGen'ed inc files. Not sure if there is a way to improve it.
May 17 2021
This compilation error (reproducible on GCC 6.2) is still not fixed unfortunately:
../unittests/IR/PassBuilderCallbacksTest.cpp: In member function ‘virtual void {anonymous}::LoopCallbacksTest_InstrumentedInvalidatingPasses_Test::TestBody()’: