Page MenuHomePhabricator

danilaml (Danila Malyutin)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2018, 12:53 PM (140 w, 2 d)

Recent Activity

Fri, Nov 27

danilaml added a reviewer for D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects: jdoerfert.
Fri, Nov 27, 3:14 AM · Restricted Project
danilaml added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

@TOCK
I've meant the surrounding context for the diff (https://llvm.org/docs/Phabricator.html#phabricator-request-review-web),
i.e. git show HEAD -U999999

Fri, Nov 27, 3:12 AM · Restricted Project

Thu, Nov 26

danilaml added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

The diffs lack context.

Thu, Nov 26, 6:09 AM · Restricted Project

Thu, Nov 19

danilaml added reviewers for D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734": serge-sans-paille, fedor.sergeev.

I've taken a liberty of adding more reviewers to hopefully help get this going.

Thu, Nov 19, 2:36 AM · Restricted Project

Oct 30 2020

danilaml added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

Ping?

Oct 30 2020, 6:29 AM · Restricted Project

Oct 14 2020

danilaml added inline comments to D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC..
Oct 14 2020, 5:04 AM · Restricted Project

Oct 6 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Rebased.
Had some time to come back to this.
I've tried implementing the following proposed way to get VTC locally:

Oct 6 2020, 7:00 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Oct 6 2020, 6:47 AM · Restricted Project

Jul 10 2020

danilaml closed D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Committed in 4c57b004f148dffc6db199890d91fc3e6e578972

Jul 10 2020, 8:44 AM

Jul 8 2020

danilaml added reviewers for D83396: [LNT] Use minimized version of jquery.scrolltofixed: jmolloy, cmatthews.
Jul 8 2020, 7:25 AM
danilaml added a comment to D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Btw, it looks like lnt's .arcconfig is missing a callsign which broke moz-phab when I tried to submit using it.

Jul 8 2020, 7:21 AM
danilaml created D83396: [LNT] Use minimized version of jquery.scrolltofixed.
Jul 8 2020, 7:18 AM

Jul 7 2020

danilaml added a comment to D62574: Add support for target-configurable address spaces..

It's generally not safe to alter address spaces below the top level. C is just very permissive about it.

Jul 7 2020, 9:44 AM · Restricted Project

Jul 6 2020

danilaml added a comment to D62574: Add support for target-configurable address spaces..

What are the remaining roadblocks left before this patch can be merged? I'm interested in having a target-specific way to define the allowed explicit/implicit address space conversions.
Also, it appears that currently whether implicit casts between pointers of different AS are allowed is determined by the superset relations only, however https://reviews.llvm.org/D73360 introduced another (openCL-specific) variable into the mix: whether the conversion is a top level or not. IMHO, this should also be configured by the target, although I'm not sure whether it needs a separate hook (isBitcastNoop or similar?) or it needs to check the legality of the implicit casts differently.

Jul 6 2020, 8:05 AM · Restricted Project

Jul 3 2020

danilaml committed rG38909f31bd08: [IR] Short-circuit comparison with itself for Attributes (authored by danilaml).
[IR] Short-circuit comparison with itself for Attributes
Jul 3 2020, 6:26 AM
danilaml closed D82295: [IR] Short-circuit comparison with itself for Attributes.
Jul 3 2020, 6:26 AM · Restricted Project

Jun 30 2020

danilaml added a comment to D82295: [IR] Short-circuit comparison with itself for Attributes.

ping

Jun 30 2020, 7:34 AM · Restricted Project

Jun 25 2020

danilaml abandoned D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

@RKSimon sadly not.

Jun 25 2020, 3:12 AM · Restricted Project

Jun 23 2020

danilaml updated the diff for D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 23 2020, 4:45 AM · Restricted Project
danilaml added a comment to D82295: [IR] Short-circuit comparison with itself for Attributes.

@dblaikie It was actually failing on some of the lit tests when compiler was compiled with EXPENSIVE_CHECKS enabled (kind of how I discovered it), but after this recent refactor which removed a sort step: https://github.com/llvm/llvm-project/commit/ed766f1bb1040a520fb5646ab75851e2b0fd66df#diff-7b43e801c5abbb03d571f9aad6af63a5L792
I don't know if the codepath with ::sort (which has those checks) can be hit from llvm IR. Instead, I've added an explicit check to AttributesTest.cpp that currently asserts.

Jun 23 2020, 4:45 AM · Restricted Project

Jun 22 2020

danilaml added inline comments to D43620: [Pipeliner] Fixed node order issue related to zero latency edges.
Jun 22 2020, 8:35 AM · Restricted Project
danilaml updated the diff for D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 8:01 AM · Restricted Project
danilaml added inline comments to D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 6:57 AM · Restricted Project
danilaml added reviewers for D82295: [IR] Short-circuit comparison with itself for Attributes: dblaikie, t.p.northover, jyknight.
Jun 22 2020, 6:57 AM · Restricted Project
danilaml created D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 6:26 AM · Restricted Project

Jun 18 2020

Herald added a project to D43620: [Pipeliner] Fixed node order issue related to zero latency edges: Restricted Project.

Sorry for commenting on an old merge PR, but was looking through some asserts and stumbled on this code which raised some questions.

Jun 18 2020, 7:34 AM · Restricted Project

Apr 6 2020

danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 6 2020, 8:38 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 6 2020, 8:05 AM · Restricted Project

Apr 3 2020

danilaml added inline comments to rG37943e518c5a: [docs] Added solutions to slow build under common problems..
Apr 3 2020, 8:02 AM
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 7:29 AM · Restricted Project
danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:57 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:24 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:24 AM · Restricted Project

Apr 2 2020

danilaml added inline comments to D68510: [PATCH 16/27] [noalias] Clone scopes and llvm.noalias.decl when unrolling..
Apr 2 2020, 3:45 AM · Restricted Project

Mar 20 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Updated revision with additional checks and rebased.

Mar 20 2020, 10:50 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 20 2020, 10:49 AM · Restricted Project

Mar 18 2020

danilaml committed rG2aaafaf5005f: [NFC] Add missing REQUIRES clause to a test (authored by danilaml).
[NFC] Add missing REQUIRES clause to a test
Mar 18 2020, 7:03 AM
danilaml committed rG940ba1465b2c: Fix possible assertion when using PBQP with debug info (authored by danilaml).
Fix possible assertion when using PBQP with debug info
Mar 18 2020, 5:57 AM
danilaml closed D76129: Fix possible assertion when using PBQP with debug info.
Mar 18 2020, 5:57 AM · Restricted Project

Mar 17 2020

danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 17 2020, 8:31 AM · Restricted Project

Mar 16 2020

danilaml added inline comments to D76129: Fix possible assertion when using PBQP with debug info.
Mar 16 2020, 10:52 AM · Restricted Project
danilaml added inline comments to D76129: Fix possible assertion when using PBQP with debug info.
Mar 16 2020, 8:42 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 16 2020, 8:42 AM · Restricted Project
danilaml added a comment to D73501: [SCEV] rewriteLoopExitValues(): even if have hard uses, still rewrite if cheap (PR44668).

@lebedev.ri I've been successfully using a pass based on https://reviews.llvm.org/D12494 in a downstream port (although I'm not sure if it's enough to fix all ARM's regressions). I was planning to submit it for the review after some touch ups (i.e. it only uses legacy pm) but haven't found the time for that yet. I also need to evaluate whether it is still needed after D75908 (that might take some time).

Mar 16 2020, 5:52 AM · Restricted Project

Mar 13 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

ping

Mar 13 2020, 10:44 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 10:11 AM · Restricted Project
danilaml added inline comments to D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 9:39 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 9:39 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 7:28 AM · Restricted Project
danilaml added a comment to D76129: Fix possible assertion when using PBQP with debug info.

Test generated from the following C code:

Mar 13 2020, 7:28 AM · Restricted Project
danilaml added a reviewer for D76129: Fix possible assertion when using PBQP with debug info: aadg.
Mar 13 2020, 6:55 AM · Restricted Project
danilaml updated the summary of D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 6:22 AM · Restricted Project
danilaml created D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 6:22 AM · Restricted Project

Mar 6 2020

danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml added reviewers for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases: Ayal, fhahn, hsaito, gilr, rengolin, dcaballe.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 7:41 AM · Restricted Project
danilaml created D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 7:41 AM · Restricted Project

Feb 19 2020

danilaml added a comment to D65673: [MBP] Disable aggressive loop rotate in plain mode.

@Carrot this seems to be reverted, but aggressive loop rotate still has mostly negative affect on performance in internal benchmarks that I've run.
Could you please elaborate on how branches taken was reduced from 2 to 1 (and how it was calculated) for the test case you mentioned in the https://reviews.llvm.org/D43256#1534855

Feb 19 2020, 8:14 AM · Restricted Project

Jan 1 2020

danilaml added a comment to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

@craig.topper this pass runs on IR. In the real code that prompted me to come up with this patch the BB block was split during ISel building phase, because (IUC) it was too big. And just so happens that the split was right between sext to i64 and mul. I've tried to simulate it with the code above.
@bjope Thanks. That might be a valid option for testing (although it's not really target specific at this point). However, it might be moot if it turns out there is no way to either 1) check whether two CopyFromRegs came from the same IR value or 2) find out in other ways that one node is just replicated sign bit of the other node.

Jan 1 2020, 7:08 AM · Restricted Project

Dec 30 2019

danilaml added inline comments to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.
Dec 30 2019, 8:13 AM · Restricted Project

Dec 23 2019

danilaml added a comment to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

One of the motivating examples (not sure how stable this IR to use as a test) is something like this (needs -mllvm -disable-cgp to prevent sext sinking):

define i64 @foo(i32 %a, i32 %b) local_unnamed_addr {
entry:
  %conv6 = sext i32 %a to i64
  %conv17 = sext i32 %b to i64
  %add = add i64 %conv6, 42
  %cmp0 = icmp slt i64 %conv17, %add
  br i1 %cmp0, label %exit, label %exit2 ; branch to prevent bb merging
Dec 23 2019, 9:25 AM · Restricted Project
danilaml added inline comments to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.
Dec 23 2019, 8:02 AM · Restricted Project

Dec 20 2019

danilaml updated the summary of D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.
Dec 20 2019, 8:39 AM · Restricted Project

Dec 18 2019

danilaml created D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.
Dec 18 2019, 5:18 AM · Restricted Project

Sep 26 2019

danilaml added inline comments to D67904: [ARM][MVE] validForTailPredication insts.
Sep 26 2019, 5:30 AM · Restricted Project

Sep 24 2019

danilaml added inline comments to D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.
Sep 24 2019, 5:40 AM · Restricted Project

Sep 4 2019

danilaml committed rL370896: Request commit access for danilaml.
Request commit access for danilaml
Sep 4 2019, 6:05 AM

Aug 27 2019

danilaml added inline comments to D66450: [POC Only] Demonstration of approach to undo exit value rewriting.
Aug 27 2019, 6:10 AM

Aug 21 2019

danilaml added inline comments to D37932: [DebugInfo] Correctly coalesce DBG_VALUEs that mix direct and indirect values.
Aug 21 2019, 3:33 AM · Restricted Project

Aug 20 2019

danilaml added inline comments to D37932: [DebugInfo] Correctly coalesce DBG_VALUEs that mix direct and indirect values.
Aug 20 2019, 10:16 AM · Restricted Project
danilaml added inline comments to D37932: [DebugInfo] Correctly coalesce DBG_VALUEs that mix direct and indirect values.
Aug 20 2019, 9:36 AM · Restricted Project
danilaml added a comment to D66450: [POC Only] Demonstration of approach to undo exit value rewriting.

Thanks for submitting this. It's good to see different approaches.

Aug 20 2019, 8:48 AM
Herald added a project to D37932: [DebugInfo] Correctly coalesce DBG_VALUEs that mix direct and indirect values: Restricted Project.
Aug 20 2019, 4:22 AM · Restricted Project

Aug 19 2019

danilaml added a comment to D65751: [LNT] Add support for v2 fmt in test data library.

I see. It also looks like "run_order" was switched to llvm_project_revision for some reason (I couldn't quite get why - is it simply because the old schema used it? Seems not worth it even if it's hard to correct it in LNT), but if it won't change the behavior (i.e. produced reports) for existing LNT users then it's fine. There seems to be some confusion around what run order is supposed to be already.

Aug 19 2019, 6:53 AM · Restricted Project
danilaml added a comment to D65751: [LNT] Add support for v2 fmt in test data library.

What does this mean for the existing v1 users? Will they continue using v1 format, i.e. will LNT keep using whatever it was using before this patch or will it switch to v2? Btw, is there some place/short summary of the rationale behind v2? Not really related to this patch per se, just want to understand the implication of the new format for the downstream users.

Aug 19 2019, 4:05 AM · Restricted Project

Aug 13 2019

Herald added a project to D12494: New IR pass: LoopExitValues: Restricted Project.

Any particular reason this was never followed through? This pass might solve https://bugs.llvm.org/show_bug.cgi?id=42965 .

Aug 13 2019, 8:23 AM · Restricted Project

Aug 5 2019

danilaml accepted D65750: [LNT] Add missing method docstrings in lnt.testing.
Aug 5 2019, 9:21 AM · Restricted Project
danilaml accepted D65749: [LNT] Wrap comments and docstrings at 72 chars.
Aug 5 2019, 9:16 AM · Restricted Project

Jun 7 2019

danilaml committed rL362787: in test_suite run_test function, opt and self.opt is same object.
in test_suite run_test function, opt and self.opt is same object
Jun 7 2019, 3:37 AM
danilaml closed D61662: in test_suite run_test function, opt and self.opt is same obect.
Jun 7 2019, 3:37 AM · Restricted Project

Jun 5 2019

danilaml added a comment to D61662: in test_suite run_test function, opt and self.opt is same obect.

ping

Jun 5 2019, 5:39 AM · Restricted Project

Jan 31 2019

danilaml added inline comments to D57264: Bump minimum toolchain version.
Jan 31 2019, 6:51 AM · Restricted Project

Jan 29 2019

danilaml added inline comments to D57264: Bump minimum toolchain version.
Jan 29 2019, 4:49 AM · Restricted Project

Jan 11 2019

danilaml added a comment to D56567: [ADT] Force attribute used on functions marked as always_inline..

How big is the slowdown?

Jan 11 2019, 2:31 AM

Jan 10 2019

danilaml added inline comments to D56550: Add recipes for migrating downstream branches of git mirrors.
Jan 10 2019, 9:23 AM · Restricted Project

Jan 9 2019

danilaml committed rL350706: [LNT] add missing test inputs.
[LNT] add missing test inputs
Jan 9 2019, 4:20 AM
danilaml committed rL350704: [LNT] fix ValueError in a corner case of geomean comparison.
[LNT] fix ValueError in a corner case of geomean comparison
Jan 9 2019, 4:02 AM
danilaml closed D56133: [LNT] fix ValueError in corner case.
Jan 9 2019, 4:02 AM
danilaml committed rL350699: [LNT] Fix typo in a comment.
[LNT] Fix typo in a comment
Jan 9 2019, 2:14 AM

Dec 28 2018

danilaml created D56133: [LNT] fix ValueError in corner case.
Dec 28 2018, 8:57 AM

Nov 22 2018

danilaml accepted rC347465: [clang-format] Do not treat asm clobber [ as ObjCExpr, refined.
Nov 22 2018, 9:50 AM
danilaml added inline comments to rC347465: [clang-format] Do not treat asm clobber [ as ObjCExpr, refined.
Nov 22 2018, 8:04 AM

Oct 24 2018

danilaml added inline comments to D53414: Add instructions for migrating branches from one git repository to another..
Oct 24 2018, 7:20 AM · Restricted Project
danilaml added inline comments to D53414: Add instructions for migrating branches from one git repository to another..
Oct 24 2018, 6:17 AM · Restricted Project
danilaml added inline comments to D53414: Add instructions for migrating branches from one git repository to another..
Oct 24 2018, 4:47 AM · Restricted Project

Sep 26 2018

danilaml added a comment to D52360: [clang-tidy] Fix for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy.

Would that also skip checks for something like shared_ptr?

Sep 26 2018, 5:15 AM · Restricted Project

Sep 17 2018

danilaml added a comment to D51862: [LNT] more pep8 code style fixes.

ping

Sep 17 2018, 3:47 AM

Sep 11 2018

danilaml added a comment to D49116: Setup clang-format as an Arcanist linter.

Would it make clang-format linker available to Phabricator automatically or it would still be required to be run manually by those submitting the diffs?

Sep 11 2018, 9:22 AM · Restricted Project