Page MenuHomePhabricator

danilaml (Danila Malyutin)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2018, 12:53 PM (168 w, 2 d)

Recent Activity

Wed, Jun 9

danilaml added a comment to D103352: [globalisel][legalizer] Separate the deprecated LegalizerInfo from the current one.

I think I've missed an email discussing this change/deprecation: does it only affect .setAction calls? I.e. if the target only uses builders and doesn't call .setAction could it be affected by this change?

Wed, Jun 9, 7:40 AM · Restricted Project

Fri, Jun 4

danilaml committed rG12592a439ae5: Add commutable attribute to opcodes for ARC (authored by marksl).
Add commutable attribute to opcodes for ARC
Fri, Jun 4, 9:55 AM
danilaml closed D103653: Add commutable attribute to opcodes for ARC.
Fri, Jun 4, 9:55 AM · Restricted Project
danilaml added a comment to D101835: [llvm] llvm-tapi-diff.

I'm pretty sure this also causes a build failure on older, but supported versions of GCC due to this bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480):

../tools/llvm-tapi-diff/DiffEngine.cpp:35:71: error: specialization of template<class T, llvm::DiffAttrKind U> void llvm::DiffScalarVal<T, U>::print(llvm::raw_ostream&, std::__cxx11::string) in different namespace [-fpermissive]
                                                     std::string Indent) {
                                                                       ^
Fri, Jun 4, 8:46 AM · Restricted Project
danilaml accepted D103653: Add commutable attribute to opcodes for ARC.

LGTM

Fri, Jun 4, 5:37 AM · Restricted Project

Mon, May 31

danilaml added a comment to D102092: [lldb] Enable -Wmisleading-indentation.

I remember some noise due to this option (albeit on GCC), because it stops tracking indentation when the number of lines is too big, as it is for files including TableGen'ed inc files. Not sure if there is a way to improve it.

Mon, May 31, 8:02 AM · Restricted Project, Restricted Project

May 17 2021

danilaml added a comment to rGd4d80a2903c1: Bump googletest to 1.10.0.

This compilation error (reproducible on GCC 6.2) is still not fixed unfortunately:

../unittests/IR/PassBuilderCallbacksTest.cpp: In member function ‘virtual void {anonymous}::LoopCallbacksTest_InstrumentedInvalidatingPasses_Test::TestBody()’:
May 17 2021, 4:22 AM

Apr 29 2021

danilaml committed rZORG41979ca6ea64: [zorg] Add buildbot for Synopsys ARC (authored by Lily_He).
[zorg] Add buildbot for Synopsys ARC
Apr 29 2021, 5:43 AM
danilaml closed D101345: [zorg] Add buildbot for Synopsys ARC.
Apr 29 2021, 5:43 AM · Restricted Project

Mar 3 2021

danilaml added reviewers for D97863: [LSR] adjust isHighCostExpansion function for Mul case: atrick, lebedev.ri.
Mar 3 2021, 8:34 AM · Restricted Project
danilaml added a comment to D97863: [LSR] adjust isHighCostExpansion function for Mul case.

This is mostly to get the comments on the original function and it's intent. Before this change the test would bail out on a first Instruction::Mul user which doesn't make much sense from the context. I.e. if there were two Mul users, one satisfying the SE.getSCEV(UI) == Mul condition, then whether the increment would be considered high cost would depend on the order of the Users in the users() list.
Also, it would return true (meaning high cost) if the existing instruction already computes given SCEV, which seems to be the opposite of the stated intent unless I'm misunderstanding something.

Mar 3 2021, 8:32 AM · Restricted Project
danilaml requested review of D97863: [LSR] adjust isHighCostExpansion function for Mul case.
Mar 3 2021, 8:21 AM · Restricted Project

Feb 25 2021

danilaml added a comment to D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.

Also not sure why the attempt to replace llvm:: with std:: has failed (probably some weird mix of obsolete STL with a newer patched GCC), although if it's the ABI we want, it doesn't matter.

The root of this problem lies in llvm::OptionalStorage which is specialized based on the value of llvm::is_trivially_copyable. In order to guarantee that code compiled with, say, clang, can link with LLVM compiled with, say gcc, we need to guarantee that the same specialization happen for the same type. That's the problem described in the bug https://bugs.llvm.org/show_bug.cgi?id=39427 I quoted in the commit comment.

As you point out, we cannot rely on std::is_trivially_copyable to enforce that guarantee, because it's not reproducible across compiler (this is something I didn't know back in the day, and probably hold true at some point for a subset of compiler large enough not to trigger the assert I added).
This is why we're looking for decent way to ensure llvm::is_trivially_copyable behaves thr same across compilers. And this patch is a decent minimal approach at doing so.

Feb 25 2021, 4:31 AM · Restricted Project

Feb 24 2021

danilaml added a comment to D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.

It's better, I just still not completely get why that assert was necessary in the first place. I.e. what exact scenario is it trying to prevent? If we just want all trivially_copyable uses to be consistent across compilers, then that assert won't help (at the very least since std:: is not consistent across compiler/std versions).

Yeah, that was the original attempt: make sure that llvm::is_trivially_copyable was consistent with std::is_trivially_copyable when compiler implement it (at that time, some compiler were not supporting it all). As you know, experience proved that this was a naive approach :-/

Feb 24 2021, 9:34 AM · Restricted Project
danilaml accepted D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.

@danilaml This is certainly not complete, but that's much better than just removing an assert as proposed in https://reviews.llvm.org/D86126. Once that one is accepted, we can move forward and commit https://reviews.llvm.org/D86126

Feb 24 2021, 3:01 AM · Restricted Project

Feb 16 2021

danilaml added a comment to D96553: [NFC] Combine runNewPMPasses() and runNewPMCustomPasses().

Don't know why no buildbot has caught it, but I think (haven't bisected yet, but this seems like the most likely culprit) this broke

LLVM :: tools/llvm-lto2/X86/pipeline.ll
lld :: ELF/lto/ltopasses-custom.ll

715dc556b782f718ce1815aaf5c58626f5fe839c should help

Feb 16 2021, 3:48 AM · Restricted Project

Feb 15 2021

danilaml added a comment to D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.

I don't know whether these checks are enough (have trivial copy constructor =/=> trivially copyable AFAIK), but otherwise LGTM.

Feb 15 2021, 7:11 AM · Restricted Project
danilaml added a comment to D96553: [NFC] Combine runNewPMPasses() and runNewPMCustomPasses().

Don't know why no buildbot has caught it, but I think (haven't bisected yet, but this seems like the most likely culprit) this broke

LLVM :: tools/llvm-lto2/X86/pipeline.ll
lld :: ELF/lto/ltopasses-custom.ll
Feb 15 2021, 3:33 AM · Restricted Project

Feb 10 2021

danilaml added inline comments to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".
Feb 10 2021, 9:26 AM · Restricted Project

Feb 3 2021

danilaml added a comment to D62574: Add support for target-configurable address spaces..

So is missing an in-tree user (like AMDGPU) the only thing that prevents from merging this?

Feb 3 2021, 2:12 AM · Restricted Project

Jan 20 2021

danilaml accepted D95069: Install future before running sphinx.

LGTM 👍

Jan 20 2021, 10:32 AM
danilaml accepted D95064: Fix type hint for add_column in lnt.server.db.util.

LGTM

Jan 20 2021, 10:19 AM
danilaml accepted D95065: Tell mypy to ignore import of cython module.

LGTM

Jan 20 2021, 10:18 AM
danilaml accepted D95067: Fix mypy warning about short_help using __doc__.

LGTM

Jan 20 2021, 10:18 AM
danilaml accepted D95068: Help mypy with typing.

LGTM

Jan 20 2021, 10:17 AM
danilaml accepted D95066: Fix return type in baseline()'s type hint.

LGTM

Jan 20 2021, 10:16 AM
danilaml added a comment to D95033: Disable mypy cache.

Why does the cache cause this error in mypy? Is it a documented problem?

Jan 20 2021, 5:04 AM

Jan 18 2021

danilaml closed D94767: [LNT] Fix some ResourceWarnings.

Landed in https://github.com/llvm/llvm-lnt/commit/e736349f7cca1b18e93b6a12e222db0bafcf54f5

Jan 18 2021, 3:34 AM

Jan 15 2021

danilaml closed D94775: [LNT] add __pycache__ to ignored files.

Landed in https://github.com/llvm/llvm-lnt/commit/2e93cbd17fd5eb4b2e3773e5022186feac554d7c

Jan 15 2021, 6:52 AM
danilaml updated the diff for D94775: [LNT] add __pycache__ to ignored files.
Jan 15 2021, 6:45 AM
danilaml added reviewers for D94775: [LNT] add __pycache__ to ignored files: thopre, cmatthews, MatzeB.
Jan 15 2021, 6:44 AM
danilaml requested review of D94775: [LNT] add __pycache__ to ignored files.
Jan 15 2021, 6:42 AM
danilaml closed D94774: [LNT] Fix F811 warnings.

Committed in https://github.com/llvm/llvm-lnt/commit/0982122b76efad15e244a18b42ce77de2a906140

Jan 15 2021, 6:36 AM
danilaml added a reviewer for D94774: [LNT] Fix F811 warnings: thopre.
Jan 15 2021, 6:32 AM
danilaml requested review of D94774: [LNT] Fix F811 warnings.
Jan 15 2021, 6:31 AM
danilaml added inline comments to D94767: [LNT] Fix some ResourceWarnings.
Jan 15 2021, 6:25 AM
danilaml added inline comments to D94767: [LNT] Fix some ResourceWarnings.
Jan 15 2021, 6:09 AM
danilaml updated the diff for D94767: [LNT] Fix some ResourceWarnings.
Jan 15 2021, 6:09 AM
danilaml accepted D94758: Ignore files generated by running tox.

LGTM

Jan 15 2021, 5:58 AM
danilaml added a reviewer for D94767: [LNT] Fix some ResourceWarnings: thopre.
Jan 15 2021, 5:03 AM
danilaml requested review of D94767: [LNT] Fix some ResourceWarnings.
Jan 15 2021, 4:59 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, I'm not aware of a buildbot for LNT. I did not even know there was one before.

Jan 15 2021, 3:03 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

I'm personally more enclined to prevent lit from running without lit installed because then some of the tests are skipped.

Jan 15 2021, 2:45 AM

Jan 14 2021

danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, pushed to the wrong branch (Phabricator/arcanist workflow is annoying >_<) and didn't notice your comment.

Hm, I've made sure that all tests pass on both py2 and py3 before submitting and I can't reproduce it on my machine.
Could you check if test_suite-profile-import.py.tmp.err and test_suite-profile-import.py.tmp.log have any suspicious errors (they should be in <..>/test_run_tmp/runtest/Output/)?

Do you use tox to run the tests?

I use lit directly (lit -svv ./tests) which what I understand tox does as well. I've rerun all tests using tox and the only test that failed was server/ui/V4Pages.py (I believe it's because I've already had an lnt instance running and that test doesn't account for that possibility).

Are you testing your patch on top of 042938b5c332fa63f1fefdd7116f39e161b8c51b? My guess is you are testing on a commit prior to f98bc1b3018248fbe551b0e7491ac5ba388216d5 which prevents tests involving profile from being run. Btw, using tox with a comparison of before/after logs allows you to spot codestyle issues added by your patch like the double glob import I pointed out.

Best regards,

Thomas

Jan 14 2021, 9:46 AM
danilaml added inline comments to D93900: [llvm-readef/obj] - Change the design structure of ELF dumper. NFCI..
Jan 14 2021, 9:35 AM · Restricted Project
danilaml added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

ping?

Jan 14 2021, 9:01 AM · Restricted Project
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, pushed to the wrong branch (Phabricator/arcanist workflow is annoying >_<) and didn't notice your comment.

Hm, I've made sure that all tests pass on both py2 and py3 before submitting and I can't reproduce it on my machine.
Could you check if test_suite-profile-import.py.tmp.err and test_suite-profile-import.py.tmp.log have any suspicious errors (they should be in <..>/test_run_tmp/runtest/Output/)?

Do you use tox to run the tests?

I use lit directly (lit -svv ./tests) which what I understand tox does as well. I've rerun all tests using tox and the only test that failed was server/ui/V4Pages.py (I believe it's because I've already had an lnt instance running and that test doesn't account for that possibility).

Jan 14 2021, 8:22 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, pushed to the wrong branch (Phabricator/arcanist workflow is annoying >_<) and didn't notice your comment.

Jan 14 2021, 8:07 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Could you explain me what does the test you added do? I'm not familiar with lnt runtest and its option nor with all the lit thingy.

Jan 14 2021, 5:25 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Fixed tests.

Jan 14 2021, 4:26 AM
danilaml updated the diff for D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Jan 14 2021, 4:01 AM

Jan 13 2021

danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Added a test.

Jan 13 2021, 9:59 AM
danilaml updated the diff for D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Jan 13 2021, 9:53 AM

Jan 11 2021

danilaml added inline comments to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Jan 11 2021, 10:00 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

I'll try to come up with a test case. I thought there were already tests for profile data, so I need to look into why they didn't catch it.

Jan 11 2021, 9:58 AM
danilaml added inline comments to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Jan 11 2021, 8:13 AM
danilaml added reviewers for D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies: thopre, cmatthews, jmolloy, kristof.beyls.
Jan 11 2021, 8:10 AM
danilaml requested review of D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Jan 11 2021, 8:06 AM

Dec 31 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Is there no transform that can be taught to do this cleanup instead?

Dec 31 2020, 8:03 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Dec 31 2020, 5:08 AM · Restricted Project

Dec 28 2020

danilaml added inline comments to D93794: Fixed a build error when using CMake 3.15.1 + NDK-R20.
Dec 28 2020, 4:33 AM · Restricted Project

Dec 10 2020

danilaml added inline comments to rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible.
Dec 10 2020, 7:34 AM
danilaml added inline comments to rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible.
Dec 10 2020, 4:05 AM

Nov 27 2020

danilaml added a reviewer for D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects: jdoerfert.
Nov 27 2020, 3:14 AM · Restricted Project
danilaml added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

@TOCK
I've meant the surrounding context for the diff (https://llvm.org/docs/Phabricator.html#phabricator-request-review-web),
i.e. git show HEAD -U999999

Nov 27 2020, 3:12 AM · Restricted Project

Nov 26 2020

danilaml added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

The diffs lack context.

Nov 26 2020, 6:09 AM · Restricted Project

Nov 19 2020

danilaml added reviewers for D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734": serge-sans-paille, fedor.sergeev.

I've taken a liberty of adding more reviewers to hopefully help get this going.

Nov 19 2020, 2:36 AM · Restricted Project

Oct 30 2020

danilaml added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

Ping?

Oct 30 2020, 6:29 AM · Restricted Project

Oct 14 2020

danilaml added inline comments to D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC..
Oct 14 2020, 5:04 AM · Restricted Project

Oct 6 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Rebased.
Had some time to come back to this.
I've tried implementing the following proposed way to get VTC locally:

Oct 6 2020, 7:00 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Oct 6 2020, 6:47 AM · Restricted Project

Jul 10 2020

danilaml closed D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Committed in 4c57b004f148dffc6db199890d91fc3e6e578972

Jul 10 2020, 8:44 AM

Jul 8 2020

danilaml added reviewers for D83396: [LNT] Use minimized version of jquery.scrolltofixed: jmolloy, cmatthews.
Jul 8 2020, 7:25 AM
danilaml added a comment to D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Btw, it looks like lnt's .arcconfig is missing a callsign which broke moz-phab when I tried to submit using it.

Jul 8 2020, 7:21 AM
danilaml created D83396: [LNT] Use minimized version of jquery.scrolltofixed.
Jul 8 2020, 7:18 AM

Jul 7 2020

danilaml added a comment to D62574: Add support for target-configurable address spaces..

It's generally not safe to alter address spaces below the top level. C is just very permissive about it.

Jul 7 2020, 9:44 AM · Restricted Project

Jul 6 2020

danilaml added a comment to D62574: Add support for target-configurable address spaces..

What are the remaining roadblocks left before this patch can be merged? I'm interested in having a target-specific way to define the allowed explicit/implicit address space conversions.
Also, it appears that currently whether implicit casts between pointers of different AS are allowed is determined by the superset relations only, however https://reviews.llvm.org/D73360 introduced another (openCL-specific) variable into the mix: whether the conversion is a top level or not. IMHO, this should also be configured by the target, although I'm not sure whether it needs a separate hook (isBitcastNoop or similar?) or it needs to check the legality of the implicit casts differently.

Jul 6 2020, 8:05 AM · Restricted Project

Jul 3 2020

danilaml committed rG38909f31bd08: [IR] Short-circuit comparison with itself for Attributes (authored by danilaml).
[IR] Short-circuit comparison with itself for Attributes
Jul 3 2020, 6:26 AM
danilaml closed D82295: [IR] Short-circuit comparison with itself for Attributes.
Jul 3 2020, 6:26 AM · Restricted Project

Jun 30 2020

danilaml added a comment to D82295: [IR] Short-circuit comparison with itself for Attributes.

ping

Jun 30 2020, 7:34 AM · Restricted Project

Jun 25 2020

danilaml abandoned D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

@RKSimon sadly not.

Jun 25 2020, 3:12 AM · Restricted Project

Jun 23 2020

danilaml updated the diff for D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 23 2020, 4:45 AM · Restricted Project
danilaml added a comment to D82295: [IR] Short-circuit comparison with itself for Attributes.

@dblaikie It was actually failing on some of the lit tests when compiler was compiled with EXPENSIVE_CHECKS enabled (kind of how I discovered it), but after this recent refactor which removed a sort step: https://github.com/llvm/llvm-project/commit/ed766f1bb1040a520fb5646ab75851e2b0fd66df#diff-7b43e801c5abbb03d571f9aad6af63a5L792
I don't know if the codepath with ::sort (which has those checks) can be hit from llvm IR. Instead, I've added an explicit check to AttributesTest.cpp that currently asserts.

Jun 23 2020, 4:45 AM · Restricted Project

Jun 22 2020

danilaml added inline comments to D43620: [Pipeliner] Fixed node order issue related to zero latency edges.
Jun 22 2020, 8:35 AM · Restricted Project
danilaml updated the diff for D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 8:01 AM · Restricted Project
danilaml added inline comments to D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 6:57 AM · Restricted Project
danilaml added reviewers for D82295: [IR] Short-circuit comparison with itself for Attributes: dblaikie, t.p.northover, jyknight.
Jun 22 2020, 6:57 AM · Restricted Project
danilaml created D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 6:26 AM · Restricted Project

Jun 18 2020

Herald added a project to D43620: [Pipeliner] Fixed node order issue related to zero latency edges: Restricted Project.

Sorry for commenting on an old merge PR, but was looking through some asserts and stumbled on this code which raised some questions.

Jun 18 2020, 7:34 AM · Restricted Project

Apr 6 2020

danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 6 2020, 8:38 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 6 2020, 8:05 AM · Restricted Project

Apr 3 2020

danilaml added inline comments to rG37943e518c5a: [docs] Added solutions to slow build under common problems..
Apr 3 2020, 8:02 AM
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 7:29 AM · Restricted Project
danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:57 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:24 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:24 AM · Restricted Project

Apr 2 2020

danilaml added inline comments to D68510: [PATCH 16/27] [noalias] Clone scopes and llvm.noalias.decl when unrolling..
Apr 2 2020, 3:45 AM · Restricted Project

Mar 20 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Updated revision with additional checks and rebased.

Mar 20 2020, 10:50 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 20 2020, 10:49 AM · Restricted Project

Mar 18 2020

danilaml committed rG2aaafaf5005f: [NFC] Add missing REQUIRES clause to a test (authored by danilaml).
[NFC] Add missing REQUIRES clause to a test
Mar 18 2020, 7:03 AM