User Details
- User Since
- Mar 28 2018, 12:53 PM (286 w, 5 d)
Fri, Sep 22
@Carrot created an issue with the hang reproducer: https://github.com/llvm/llvm-project/issues/67188
This patch also seems to cause near-infinite compile times in same cases (don't know if they actually finish as the process gets killed via OoM). Trying to get a reproducer now.
Thu, Sep 14
Tue, Sep 5
Mon, Sep 4
Wed, Aug 30
Not exactly familiar with this part of code, but the fix makes sense to me.
Perhaps we could add a check that OrderedRoots is topologically sorted under EXPENSIVE_CHECKS.
Superseded by D159209
Tue, Aug 29
Aug 25 2023
Aug 22 2023
Aug 8 2023
Jul 28 2023
LGTM
Jul 27 2023
Jul 26 2023
Jul 24 2023
Jul 20 2023
Jul 19 2023
Okay, but then add an aarch64 maintainer on the review list (also add phoebe on this one).
split new tests pre-changes into separate review
Remove updates to aarch64 test
Add test with masked nbits
Jul 18 2023
Jul 6 2023
Having the issues with PTRACE_SEIZE on CentOS 6 (will probably need to build LLVM where for around a year). Don't use llvm-exegesis there, but it's hard to cleanly disable it from build, since tests depend on it.
Apr 17 2023
Apr 13 2023
LGTM
Jan 13 2023
Dec 26 2022
Simplified the test
Dec 14 2022
Discovered when some downstream analysis wasn't invalidated when this transformation was the only change instcombine made leading to a miscompile. Not sure how to write a good test for this. I remember there being a pass that verified that passes correctly reported changed IR but I think it only worked for legacy pm.
Sep 13 2022
I've experienced similar linking issues (-lz not resolved) when cross-compiling since ZLIB was initially picked from cross-build sysroot with a full path but simply using -lz is not enough to find a target zlib.
Aug 18 2022
Simplified lit test a little
Aug 17 2022
Aug 16 2022
Aug 4 2022
Jun 16 2022
LGTM
Jun 14 2022
Jun 10 2022
Jun 8 2022
@efriedma I've added float->bloat16 conversion tests but I'm not sure these are exact same you had in mind.
Added float->bfloat conversion tests
Jun 7 2022
Submitted an alternative solution (adjusting the shift/exponent)
Jun 6 2022
May 31 2022
May 30 2022
Addressed the comments