AIX use __ssp_canary_word instead of __stack_chk_guard.
This patch update the target hook to use correct symbol,
so that the basic stackprotect feature can work.
The traceback will be handled in follow up patch.
Paths
| Differential D103100
[AIX] Enable stackprotect feature ClosedPublic Authored by jsji on May 25 2021, 9:48 AM.
Details
Summary AIX use __ssp_canary_word instead of __stack_chk_guard. The traceback will be handled in follow up patch.
Diff Detail
Event TimelineHerald added subscribers: kbarton, hiraditya, nemanjai. · View Herald TranscriptMay 25 2021, 9:48 AM hubert.reinterpretcast added inline comments.
hubert.reinterpretcast added inline comments.
jsji added a child revision: D103202: [AIX] Add traceback ssp canary bit support.May 26 2021, 1:33 PM
Comment Actions Address comments.
Comment Actions LGTM. Thanks.
This revision is now accepted and ready to land.May 27 2021, 5:44 PM This revision was landed with ongoing or failed builds.May 27 2021, 7:47 PM Closed by commit rGb2581196eb03: [AIX] Enable stackprotect feature (authored by jsji). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 348434 llvm/lib/Target/PowerPC/PPCISelLowering.h
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/lib/Transforms/IPO/Internalize.cpp
llvm/test/CodeGen/PowerPC/stack-guard-oob.ll
llvm/test/CodeGen/PowerPC/stack-protector.ll
llvm/test/Transforms/Internalize/stackguard.ll
|
Not declaring static explicitly means that some header somewhere declaring this as extern will cause this to be an external definition. I don't think that's great (and I don't think the case is strong for this file to contain a potentially-external definition of this name).