Page MenuHomePhabricator

w2yehia (wael yehia)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2014, 1:20 PM (413 w, 4 d)

Recent Activity

Mon, Aug 8

w2yehia added a reverting change for rG93bb2f16e85d: XFAIL some PGO tests on AIX until the new linker becomes publicly available.: rGaf8205d0eb47: Revert "XFAIL some PGO tests on AIX until the new linker becomes publicly….
Mon, Aug 8, 7:05 AM · Restricted Project, Restricted Project
w2yehia committed rGaf8205d0eb47: Revert "XFAIL some PGO tests on AIX until the new linker becomes publicly… (authored by w2yehia).
Revert "XFAIL some PGO tests on AIX until the new linker becomes publicly…
Mon, Aug 8, 7:05 AM · Restricted Project, Restricted Project

Fri, Aug 5

Herald added a project to D49863: [istream] Fix error flags and exceptions propagated from input stream operations: Restricted Project.
Fri, Aug 5, 3:43 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Aug 3

w2yehia added a comment to D130889: [llvm] Introduce a pass plugin registry and loader.

Looks good. Thanks.

Wed, Aug 3, 8:58 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 18

w2yehia added a comment to D129401: [libLTO] Set data-sections by default in libLTO..

I've realized that getExplicitDataSections() interacts with ...

Mon, Jul 18, 8:42 AM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

w2yehia accepted D129401: [libLTO] Set data-sections by default in libLTO..
Jul 11 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
w2yehia added a comment to D129401: [libLTO] Set data-sections by default in libLTO..

LGTM

Jul 11 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
w2yehia added inline comments to D129401: [libLTO] Set data-sections by default in libLTO..
Jul 11 2022, 7:27 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2022

w2yehia committed rG0952cf5bbbc4: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands. (authored by w2yehia).
[InstCombine] decomposeSimpleLinearExpr should bail out on negative operands.
Jun 7 2022, 5:58 PM · Restricted Project, Restricted Project
w2yehia closed D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 7 2022, 5:58 PM · Restricted Project, Restricted Project
w2yehia added inline comments to D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 7 2022, 10:22 AM · Restricted Project, Restricted Project
w2yehia updated the diff for D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..

use update_test_checks.py to generate the CHECKs

Jun 7 2022, 10:21 AM · Restricted Project, Restricted Project
w2yehia added a comment to D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..

@nikic any chance you can review this today? thanks!

Jun 7 2022, 6:13 AM · Restricted Project, Restricted Project

Jun 6 2022

w2yehia added inline comments to D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 6 2022, 12:56 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 6 2022, 11:39 AM · Restricted Project, Restricted Project
w2yehia added inline comments to D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 6 2022, 11:39 AM · Restricted Project, Restricted Project
w2yehia updated the diff for D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..

As per review, remove !OBI->hasNoSignedWrap() from the early exit condition. Also the original fix is no longer needed so remove it as well.

Jun 6 2022, 7:10 AM · Restricted Project, Restricted Project
w2yehia added inline comments to D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 6 2022, 6:27 AM · Restricted Project, Restricted Project
w2yehia updated subscribers of D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 6 2022, 6:11 AM · Restricted Project, Restricted Project

Jun 2 2022

w2yehia added inline comments to D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
Jun 2 2022, 5:59 AM · Restricted Project, Restricted Project

May 27 2022

w2yehia added inline comments to D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
May 27 2022, 10:18 AM · Restricted Project, Restricted Project
w2yehia updated the summary of D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
May 27 2022, 9:13 AM · Restricted Project, Restricted Project
w2yehia updated the diff for D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
May 27 2022, 9:12 AM · Restricted Project, Restricted Project
w2yehia requested review of D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands..
May 27 2022, 7:59 AM · Restricted Project, Restricted Project

May 5 2022

w2yehia committed rG93bb2f16e85d: XFAIL some PGO tests on AIX until the new linker becomes publicly available. (authored by w2yehia).
XFAIL some PGO tests on AIX until the new linker becomes publicly available.
May 5 2022, 6:36 PM · Restricted Project, Restricted Project

May 4 2022

w2yehia committed rG2407c13aa4a4: [AIX][PGO] Enable linux style PGO on AIX (authored by w2yehia).
[AIX][PGO] Enable linux style PGO on AIX
May 4 2022, 9:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia closed D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 4 2022, 9:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia updated the diff for D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 4 2022, 11:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia added inline comments to D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 4 2022, 11:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia added inline comments to D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 4 2022, 10:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia updated the diff for D124857: [AIX][PGO] Enable linux style PGO on AIX.

Address one comment.

May 4 2022, 10:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia added a comment to D124857: [AIX][PGO] Enable linux style PGO on AIX.

@davidxl @MaskRay @jsji FYI, please review the addition on line 242 of compiler-rt/lib/profile/InstrProfilingPlatformLinux.c

May 4 2022, 8:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia updated the diff for D124857: [AIX][PGO] Enable linux style PGO on AIX.

Add dummy variables to allow linking in general against the profile-rt on AIX in the default linking model (-bcdtos:all).

May 4 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia added inline comments to D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 4 2022, 6:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 3 2022

w2yehia added inline comments to D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 3 2022, 9:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia requested review of D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 3 2022, 8:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

w2yehia committed rGf296b4c44462: [AIX] Always pass namedsects option when linking with PGO. (authored by w2yehia).
[AIX] Always pass namedsects option when linking with PGO.
Apr 21 2022, 10:02 AM · Restricted Project, Restricted Project
w2yehia closed D124046: [AIX] Always pass namedsects option when linking with PGO..
Apr 21 2022, 10:02 AM · Restricted Project, Restricted Project

Apr 19 2022

w2yehia updated the diff for D124046: [AIX] Always pass namedsects option when linking with PGO..
Apr 19 2022, 3:49 PM · Restricted Project, Restricted Project
w2yehia requested review of D124046: [AIX] Always pass namedsects option when linking with PGO..
Apr 19 2022, 3:16 PM · Restricted Project, Restricted Project

Mar 21 2022

w2yehia added a comment to D70688: [PGO] Add Value Profiling for Loop Trip Count (WIP).
In D70688#3395357, @hoy wrote:

The work is interesting. I'm wondering if it is still ongoing. I haven't looked into the implementation details here yet, but here are a couple basic questions:

  1. Does the generated loop MD reflect the average loop trip count per loop run or the accumulated total trip count for all runs of the loop?
  2. How does the generated loop MD differ from the synthesized loop tripe count based on the branch_weight metadata?
  3. Have you seen a particular loop optimization pass benefits from this work?

Thanks.

Mar 21 2022, 8:47 AM · Restricted Project, Restricted Project

Mar 17 2022

w2yehia added a comment to D121566: Load pass plugins during option processing, so that plugin options are registered and live..

Giving my LGTM assuming you are still doing the Python code cleanup. Please observe the Polly buildbots after committing.

Thanks, will keep an eye for sure.

Mar 17 2022, 8:41 PM · Restricted Project, Restricted Project
w2yehia committed rGc80198b3d39d: Reland "Load pass plugins during option processing, so that plugin options are… (authored by w2yehia).
Reland "Load pass plugins during option processing, so that plugin options are…
Mar 17 2022, 8:28 PM · Restricted Project
w2yehia closed D121566: Load pass plugins during option processing, so that plugin options are registered and live..
Mar 17 2022, 8:28 PM · Restricted Project, Restricted Project
w2yehia added a comment to D121566: Load pass plugins during option processing, so that plugin options are registered and live..

Could you rebase the patch? The premerge-check's patch application failed: https://buildkite.com/llvm-project/diff-checks/builds/94599

Mar 17 2022, 11:38 AM · Restricted Project, Restricted Project
w2yehia updated the diff for D121566: Load pass plugins during option processing, so that plugin options are registered and live..

Fixed failing polly tests by adding a NPM macro %loadNPMPolly.
@Meinersbur Thanks for the review. Please let me know if the cfg changes are ok before I commit the changes.

Mar 17 2022, 8:20 AM · Restricted Project, Restricted Project

Mar 16 2022

w2yehia reopened D121566: Load pass plugins during option processing, so that plugin options are registered and live..
Mar 16 2022, 11:44 AM · Restricted Project, Restricted Project
w2yehia added a comment to D121566: Load pass plugins during option processing, so that plugin options are registered and live..

but if consequent it should also give an error if no pass from the loaded plugin was used.

Agreed. However, how can I tell if this occurs? Is there a simple way to check that?

Mar 16 2022, 10:54 AM · Restricted Project, Restricted Project

Mar 15 2022

w2yehia updated subscribers of D121566: Load pass plugins during option processing, so that plugin options are registered and live..

@Meinersbur Hi Michael. I see this in polly's lit config file:

config.substitutions.append(('%loadPolly', '-load '
                             + config.polly_lib_dir + '/LLVMPolly@LLVM_SHLIBEXT@'
                             + ' -load-pass-plugin '
                             + config.polly_lib_dir + '/LLVMPolly@LLVM_SHLIBEXT@'

The -load-pass-plugin was added in D45484, but the follow up change D45493 never landed.
From my understanding, -load and -load-pass-plugin are disjoint (one is for legacy PM and one for NPM) by design.
Since you cannot run both legacy and new PM, the only reason I think you need both -load and -load-pass-plugin is to be able to register polly's options before they're processed.
Which is the problem this PR addresses.
Should we remove -load-pass-plugin from %loadPolly for now, until polly switches to using NPM (i'm guessing it's using legacy PM because the new diagnostic i'm adding is being triggered by polly's tests) ?

Mar 15 2022, 8:14 PM · Restricted Project, Restricted Project
w2yehia added a reverting change for rG5e8700ce8bf5: Load pass plugins during option processing, so that plugin options are…: rGed4c03afac91: Revert "Load pass plugins during option processing, so that plugin options are….
Mar 15 2022, 6:03 AM · Restricted Project
w2yehia committed rGed4c03afac91: Revert "Load pass plugins during option processing, so that plugin options are… (authored by w2yehia).
Revert "Load pass plugins during option processing, so that plugin options are…
Mar 15 2022, 6:03 AM · Restricted Project
w2yehia added a comment to D121566: Load pass plugins during option processing, so that plugin options are registered and live..

I got many failures in poly.
Seems it uses both -load and -load-pass-plugin with legacy PM passes?

Mar 15 2022, 5:59 AM · Restricted Project, Restricted Project
w2yehia closed D121566: Load pass plugins during option processing, so that plugin options are registered and live..
Mar 15 2022, 5:46 AM · Restricted Project, Restricted Project
w2yehia committed rG5e8700ce8bf5: Load pass plugins during option processing, so that plugin options are… (authored by w2yehia).
Load pass plugins during option processing, so that plugin options are…
Mar 15 2022, 5:44 AM · Restricted Project

Mar 14 2022

w2yehia added inline comments to D121566: Load pass plugins during option processing, so that plugin options are registered and live..
Mar 14 2022, 9:38 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D121566: Load pass plugins during option processing, so that plugin options are registered and live..

Issue an error when -load-pass-plugin is used with legacy PM.

Mar 14 2022, 9:37 PM · Restricted Project, Restricted Project
w2yehia added reviewers for D121566: Load pass plugins during option processing, so that plugin options are registered and live.: mehdi_amini, eli.friedman, pfaffe, philip.pfaffe.
Mar 14 2022, 9:38 AM · Restricted Project, Restricted Project

Mar 13 2022

w2yehia requested review of D121566: Load pass plugins during option processing, so that plugin options are registered and live..
Mar 13 2022, 9:53 PM · Restricted Project, Restricted Project

Feb 26 2022

w2yehia added a comment to D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.

LGTM

Feb 26 2022, 5:50 AM · Restricted Project

Feb 25 2022

w2yehia added inline comments to D119109: [clang][AIX] Enable LTO and teach the driver to pass options to the plugin.
Feb 25 2022, 2:23 PM · Restricted Project

Feb 5 2022

w2yehia committed rGaddd0733250a: [AIX][PowerPC][PGO] Generate .ref for some PGO sections (authored by w2yehia).
[AIX][PowerPC][PGO] Generate .ref for some PGO sections
Feb 5 2022, 4:05 AM
w2yehia closed D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections .
Feb 5 2022, 4:04 AM · Restricted Project

Jan 26 2022

w2yehia added a comment to D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections .

@sfertile @daltenty ping

Jan 26 2022, 6:06 PM · Restricted Project

Jan 25 2022

w2yehia accepted D118101: [compiler-rt][profile][AIX] pass extra link opts for test.
Jan 25 2022, 9:02 AM · Restricted Project

Jan 10 2022

w2yehia added a comment to D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections .

@sfertile @daltenty ping

Jan 10 2022, 8:03 AM · Restricted Project

Jan 5 2022

w2yehia updated the diff for D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections .

clang-format

Jan 5 2022, 8:51 AM · Restricted Project

Jan 4 2022

w2yehia added reviewers for D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections : sfertile, daltenty.
Jan 4 2022, 10:54 AM · Restricted Project
w2yehia updated the summary of D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections .
Jan 4 2022, 10:53 AM · Restricted Project
w2yehia requested review of D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections .
Jan 4 2022, 10:52 AM · Restricted Project

Nov 30 2021

w2yehia committed rG0850655da69a: Big-endian version of vpermxor (authored by tislam).
Big-endian version of vpermxor
Nov 30 2021, 2:50 PM
w2yehia closed D114540: Big-endian version of vpermxor.
Nov 30 2021, 2:50 PM · Restricted Project, Restricted Project

Oct 12 2021

w2yehia accepted D110945: [compiler-rt][profile] Enable profile tests for AIX.
Oct 12 2021, 7:12 PM · Restricted Project
w2yehia added a comment to D110945: [compiler-rt][profile] Enable profile tests for AIX.

LGTM if concerns are resolved.

Oct 12 2021, 7:42 AM · Restricted Project
w2yehia added inline comments to D110945: [compiler-rt][profile] Enable profile tests for AIX.
Oct 12 2021, 7:42 AM · Restricted Project

Sep 29 2021

w2yehia added a comment to D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..

I bisected a breakage in our auto-roller to this change. I seems that in DLLVM_LINK_LLVM_DYLIB mode this break the opt command:

$ opt -internalize -internalize-public-api-list=main -globaldce test.o -o test2.o
: CommandLine Error: Option 'debug-pass-manager' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

Our auto-roller that is failing is at https://autoroll.skia.org/r/llvm-project-emscripten-releases.

This is currently blocking llvm changes from getting into new emscripten releases. Perhaps we can revert?

Sep 29 2021, 12:44 PM · Restricted Project
w2yehia added a reverting change for D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace.: rG8b8da01d8827: Revert "[LTO][Legacy] Add -debug-pass-manager option to enable pass run/skip….
Sep 29 2021, 12:44 PM · Restricted Project
w2yehia added a reverting change for rGa60405cf035d: [LTO][Legacy] Add -debug-pass-manager option to enable pass run/skip trace.: rG8b8da01d8827: Revert "[LTO][Legacy] Add -debug-pass-manager option to enable pass run/skip….
Sep 29 2021, 12:44 PM
w2yehia committed rG8b8da01d8827: Revert "[LTO][Legacy] Add -debug-pass-manager option to enable pass run/skip… (authored by w2yehia).
Revert "[LTO][Legacy] Add -debug-pass-manager option to enable pass run/skip…
Sep 29 2021, 12:44 PM
w2yehia committed rGa60405cf035d: [LTO][Legacy] Add -debug-pass-manager option to enable pass run/skip trace. (authored by w2yehia).
[LTO][Legacy] Add -debug-pass-manager option to enable pass run/skip trace.
Sep 29 2021, 5:18 AM
w2yehia closed D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..
Sep 29 2021, 5:18 AM · Restricted Project

Sep 27 2021

w2yehia added a comment to D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..

@steven_wu @tejohnson ping. Thanks.

Sep 27 2021, 11:32 AM · Restricted Project

Sep 23 2021

w2yehia added a comment to D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..

the pre-merge build failures are noise (an NFC change has the same failures)

Sep 23 2021, 5:21 AM · Restricted Project

Sep 22 2021

w2yehia updated the diff for D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..

clang-format

Sep 22 2021, 7:06 AM · Restricted Project
w2yehia added a comment to D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..

@steven_wu @tejohnson ping. Thanks.

Sep 22 2021, 7:02 AM · Restricted Project

Sep 20 2021

w2yehia updated the diff for D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..
Sep 20 2021, 9:16 PM · Restricted Project
w2yehia added inline comments to D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..
Sep 20 2021, 9:15 PM · Restricted Project
w2yehia updated the diff for D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..

Common up the -debug-pass-manager option between LTOCodeGenerator, llvm-lto (which uses LTOCodeGenerator), and llvm-lto2 (which does not use LTOCodeGenerator but uses libLLVMLTO).
Add testcase.

Sep 20 2021, 12:27 PM · Restricted Project
w2yehia added reviewers for D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace.: steven_wu, fhahn.
Sep 20 2021, 8:50 AM · Restricted Project
w2yehia updated the diff for D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..
Sep 20 2021, 8:50 AM · Restricted Project
w2yehia requested review of D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace..
Sep 20 2021, 8:04 AM · Restricted Project

Aug 12 2021

w2yehia committed rGf8f355872e0b: Add PowerPC AIX triple to indirect call VP testcase. (authored by w2yehia).
Add PowerPC AIX triple to indirect call VP testcase.
Aug 12 2021, 7:17 PM

Jul 28 2021

w2yehia updated the diff for D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions.

commited version

Jul 28 2021, 5:44 AM · Restricted Project
w2yehia committed rG9559bd19908b: [LTO][Legacy] Add new API to check presence of ctor/dtor functions. (authored by w2yehia).
[LTO][Legacy] Add new API to check presence of ctor/dtor functions.
Jul 28 2021, 5:43 AM
w2yehia closed D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions.
Jul 28 2021, 5:43 AM · Restricted Project

Jul 27 2021

w2yehia updated the diff for D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions.

Added testcase for LTOModule::hasCtorDtor()

Jul 27 2021, 1:03 PM · Restricted Project
w2yehia updated the diff for D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions.

address code review comment.

Jul 27 2021, 10:16 AM · Restricted Project
w2yehia updated the summary of D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions.
Jul 27 2021, 9:52 AM · Restricted Project
w2yehia added reviewers for D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions: steven_wu, fhahn.
Jul 27 2021, 9:09 AM · Restricted Project
w2yehia requested review of D106887: [LTO][Legacy] Add new API to check presence of ctor/dtor functions.
Jul 27 2021, 9:03 AM · Restricted Project

Jun 27 2021

w2yehia accepted D104991: [PowerPC] Add XL Compat fetch builtins.
Jun 27 2021, 1:25 PM · Restricted Project