Page MenuHomePhabricator

w2yehia (wael yehia)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2014, 1:20 PM (280 w, 4 d)

Recent Activity

Dec 9 2019

w2yehia added a comment to D70976: [zorg] Add LNT testing to clang-ppc64le-rhel.

Hi Galina (@gkistanova ). This is just a friendly ping. Thanks.

Dec 9 2019, 6:31 AM

Dec 3 2019

w2yehia added reviewers for D70976: [zorg] Add LNT testing to clang-ppc64le-rhel: gkistanova, stefanp.
Dec 3 2019, 1:21 PM
w2yehia updated the diff for D70976: [zorg] Add LNT testing to clang-ppc64le-rhel.
Dec 3 2019, 1:21 PM
w2yehia created D70976: [zorg] Add LNT testing to clang-ppc64le-rhel.
Dec 3 2019, 12:16 PM

Nov 26 2019

w2yehia updated the summary of D70688: [PGO] Add Value Profiling for Loop Trip Count (WIP).
Nov 26 2019, 8:54 AM · Restricted Project
w2yehia updated the summary of D70688: [PGO] Add Value Profiling for Loop Trip Count (WIP).
Nov 26 2019, 7:30 AM · Restricted Project

Nov 25 2019

w2yehia updated the summary of D70688: [PGO] Add Value Profiling for Loop Trip Count (WIP).
Nov 25 2019, 11:23 AM · Restricted Project
w2yehia created D70688: [PGO] Add Value Profiling for Loop Trip Count (WIP).
Nov 25 2019, 11:04 AM · Restricted Project
w2yehia added a comment to D70543: [zorg] Add Clang PPC buildbot on Red Hat.

@gkistanova Hi Galina, I sent you an email on Thursday, November 21, 2019 requesting access for the new build bot.
Can you please confirm that you received it. Thanks.

Nov 25 2019, 10:07 AM

Nov 21 2019

w2yehia added a comment to D70543: [zorg] Add Clang PPC buildbot on Red Hat.

Hi Galina (@gkistanova), how do I get this patch into the zorg repo? Thanks

Nov 21 2019, 2:21 PM
w2yehia created D70543: [zorg] Add Clang PPC buildbot on Red Hat.
Nov 21 2019, 8:19 AM

Oct 9 2019

w2yehia accepted D68718: [llvm-profdata] Make "malformed-ptr-to-counter-array.test" textual.
Oct 9 2019, 6:50 PM · Restricted Project
w2yehia added a comment to D68718: [llvm-profdata] Make "malformed-ptr-to-counter-array.test" textual.

Hi Vedant, thanks for the quick fix.
The test file works, and I'm able to patch it when I add more value profiles.
I think the comments should be rearranged like so (basically I fixed the placement of the Counter and Name sections):

// Header
//
// INSTR_PROF_RAW_HEADER(uint64_t, Magic, __llvm_profile_get_magic())
// INSTR_PROF_RAW_HEADER(uint64_t, Version, __llvm_profile_get_version())
// INSTR_PROF_RAW_HEADER(uint64_t, DataSize, DataSize)
// INSTR_PROF_RAW_HEADER(uint64_t, CountersSize, CountersSize)
// INSTR_PROF_RAW_HEADER(uint64_t, NamesSize,  NamesSize)
// INSTR_PROF_RAW_HEADER(uint64_t, CountersDelta, (uintptr_t)CountersBegin)
// INSTR_PROF_RAW_HEADER(uint64_t, NamesDelta, (uintptr_t)NamesBegin)
// INSTR_PROF_RAW_HEADER(uint64_t, ValueKindLast, IPVK_Last)
Oct 9 2019, 3:43 PM · Restricted Project
w2yehia added a comment to D66979: [InstrProf] Tighten a check for malformed data records in raw profiles.

@vsk thanks

Oct 9 2019, 12:23 PM · Restricted Project
w2yehia added a comment to D66979: [InstrProf] Tighten a check for malformed data records in raw profiles.

Hi @vsk can you provide a description/script on how to recreate the malformed-ptr-to-counter-array.profraw file when someone is changing the profile layout (for example by adding new value profiling kinds).
I'm thinking something like llvm/test/tools/llvm-profdata/raw-two-profiles.test would be nice
Thanks.

Oct 9 2019, 4:27 AM · Restricted Project

Oct 1 2019

w2yehia added inline comments to D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..
Oct 1 2019, 5:36 PM · Restricted Project
w2yehia added a comment to D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..

Thanks Rong.
Let me know what you think.

Oct 1 2019, 1:31 PM · Restricted Project

Sep 30 2019

w2yehia added a comment to D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..

Teresa and David, thanks for reviewing.
Rong Xu, I'll wait for your approval.

Sep 30 2019, 8:40 AM · Restricted Project

Sep 27 2019

w2yehia updated the diff for D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..
  1. Renamed Plugin_t to PluginT, and checked that no other type name has an underscore.
  2. Renamed VPCPluginChain to PluginChain
Sep 27 2019, 12:36 PM · Restricted Project
w2yehia updated the diff for D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..

Renamed ValueProfileOracle to ValueProfileCollector. I agree that at the moment, this utility class has a single purpose and that's to collect value profiling candidates; so the new name makes sense.

Sep 27 2019, 11:59 AM · Restricted Project
w2yehia updated the diff for D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..

I enclosed the VPOPluginChain template class in an unnamed namespace so that all instantiated member functions (and constructors) get internal linkage rather than external weak, which will hopefully give more reason to inline them and eliminate their definitions. Thanks to Hubert Tong for this suggestion.

Sep 27 2019, 11:10 AM · Restricted Project

Sep 26 2019

w2yehia updated the diff for D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..

Changed 'VPOPluginChain_t' to 'VPOPluginChainFinal` based on Teresa's comment.

Sep 26 2019, 7:26 AM · Restricted Project

Sep 23 2019

w2yehia created D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins..
Sep 23 2019, 8:38 AM · Restricted Project

Sep 11 2019

w2yehia added a comment to D65026: [Bugpoint redesign] Added pass to reduce Metadata.

Just FYI, that our (IBM's) internal bots are also breaking because the following tests are not cleaning the build/test/Reduce/tmp folder:

LLVM :: Reduce/remove-funcs.ll
LLVM :: Reduce/remove-metadata.ll

And we're forced to always to a clean build.

Sep 11 2019, 11:48 AM · Restricted Project