- User Since
- Sep 8 2014, 1:20 PM (413 w, 4 d)
Mon, Aug 8
Fri, Aug 5
Wed, Aug 3
Looks good. Thanks.
Mon, Jul 18
Jul 11 2022
Jun 7 2022
use update_test_checks.py to generate the CHECKs
@nikic any chance you can review this today? thanks!
Jun 6 2022
As per review, remove !OBI->hasNoSignedWrap() from the early exit condition. Also the original fix is no longer needed so remove it as well.
Jun 2 2022
May 27 2022
May 5 2022
May 4 2022
Address one comment.
Add dummy variables to allow linking in general against the profile-rt on AIX in the default linking model (-bcdtos:all).
May 3 2022
Apr 21 2022
Apr 19 2022
Mar 21 2022
Mar 17 2022
Giving my LGTM assuming you are still doing the Python code cleanup. Please observe the Polly buildbots after committing.
Thanks, will keep an eye for sure.
Fixed failing polly tests by adding a NPM macro %loadNPMPolly.
@Meinersbur Thanks for the review. Please let me know if the cfg changes are ok before I commit the changes.
Mar 16 2022
but if consequent it should also give an error if no pass from the loaded plugin was used.
Agreed. However, how can I tell if this occurs? Is there a simple way to check that?
Mar 15 2022
@Meinersbur Hi Michael. I see this in polly's lit config file:
config.substitutions.append(('%loadPolly', '-load ' + config.polly_lib_dir + '/LLVMPolly@LLVM_SHLIBEXT@' + ' -load-pass-plugin ' + config.polly_lib_dir + '/LLVMPolly@LLVM_SHLIBEXT@'
The -load-pass-plugin was added in D45484, but the follow up change D45493 never landed.
From my understanding, -load and -load-pass-plugin are disjoint (one is for legacy PM and one for NPM) by design.
Since you cannot run both legacy and new PM, the only reason I think you need both -load and -load-pass-plugin is to be able to register polly's options before they're processed.
Which is the problem this PR addresses.
Should we remove -load-pass-plugin from %loadPolly for now, until polly switches to using NPM (i'm guessing it's using legacy PM because the new diagnostic i'm adding is being triggered by polly's tests) ?
I got many failures in poly.
Seems it uses both -load and -load-pass-plugin with legacy PM passes?
Mar 14 2022
Issue an error when -load-pass-plugin is used with legacy PM.
Mar 13 2022
Feb 26 2022
Feb 25 2022
Feb 5 2022
Jan 26 2022
Jan 25 2022
Jan 10 2022
Jan 5 2022
Jan 4 2022
Nov 30 2021
Oct 12 2021
LGTM if concerns are resolved.
Sep 29 2021
Sep 27 2021
Sep 23 2021
the pre-merge build failures are noise (an NFC change has the same failures)
Sep 22 2021
Sep 20 2021
Common up the -debug-pass-manager option between LTOCodeGenerator, llvm-lto (which uses LTOCodeGenerator), and llvm-lto2 (which does not use LTOCodeGenerator but uses libLLVMLTO).
Aug 12 2021
Jul 28 2021
Jul 27 2021
Added testcase for LTOModule::hasCtorDtor()
address code review comment.