Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People w2yehia

w2yehia (wael yehia)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2014, 1:20 PM (472 w, 6 d)

Recent Activity
View All

Thu, Sep 21

w2yehia added a comment to D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.

Please update InstrProfilingPlatformAIX.c as well, specifically add new dummy vars for the new section.
Edit: I can post the patch if you wish.

Thu, Sep 21, 11:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Sep 19

w2yehia committed rTc165082e5d42: [SingleSource] Pass -fenable-matrix at link time in case ThinLTO is used (authored by w2yehia).
[SingleSource] Pass -fenable-matrix at link time in case ThinLTO is used
Tue, Sep 19, 9:27 AM · Restricted Project

Thu, Sep 7

w2yehia committed rGc525b8ede682: [AIX] Use llvm::get_threadid() to get a numeric ID (authored by w2yehia).
[AIX] Use llvm::get_threadid() to get a numeric ID
Thu, Sep 7, 4:47 PM · Restricted Project, Restricted Project
w2yehia added a comment to D159319: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols.
In D159319#4641304, @lhames wrote:

@w2yehia Looks like this broke https://green.lab.llvm.org/green/job/clang-stage1-RA/35559/. Could you please take a look?

Thu, Sep 7, 3:09 PM · Restricted Project, Restricted Project
w2yehia committed rG11d5c7bd289c: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols (authored by w2yehia).
[AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols
Thu, Sep 7, 10:47 AM · Restricted Project, Restricted Project
w2yehia closed D159319: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols.
Thu, Sep 7, 10:47 AM · Restricted Project, Restricted Project

Wed, Sep 6

w2yehia updated the diff for D159319: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols.

address code review comments,

Wed, Sep 6, 8:41 PM · Restricted Project, Restricted Project

Aug 31 2023

w2yehia committed rG534e23e47b03: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin (authored by w2yehia).
[ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin
Aug 31 2023, 8:19 PM · Restricted Project, Restricted Project
w2yehia closed D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.
Aug 31 2023, 8:19 PM · Restricted Project, Restricted Project
w2yehia added reviewers for D159319: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols: daltenty, xingxue, sfertile.
Aug 31 2023, 5:19 PM · Restricted Project, Restricted Project
w2yehia requested review of D159319: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols.
Aug 31 2023, 5:18 PM · Restricted Project, Restricted Project

Aug 30 2023

w2yehia added inline comments to D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect.
Aug 30 2023, 12:35 PM · Restricted Project, Restricted Project
w2yehia accepted D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect.
Aug 30 2023, 12:33 PM · Restricted Project, Restricted Project

Aug 16 2023

w2yehia added a comment to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

@fhahn @MaskRay ping. Thanks.

Aug 16 2023, 7:07 AM · Restricted Project, Restricted Project

Aug 10 2023

w2yehia updated the diff for D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.
Aug 10 2023, 7:39 AM · Restricted Project, Restricted Project

Aug 9 2023

w2yehia updated the diff for D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

clang-format

Aug 9 2023, 9:18 AM · Restricted Project, Restricted Project

Aug 2 2023

w2yehia added a comment to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

@MaskRay @fhahn please review when you have time. Thanks

Aug 2 2023, 9:22 AM · Restricted Project, Restricted Project
w2yehia updated the diff for D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

address MaskRay's comments

Aug 2 2023, 9:21 AM · Restricted Project, Restricted Project

Jul 31 2023

w2yehia added inline comments to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.
Jul 31 2023, 8:54 PM · Restricted Project, Restricted Project

Jul 28 2023

w2yehia committed rG9d4e8c09f493: [XCOFF] Do not put MergeableCStrings in their own section (authored by w2yehia).
[XCOFF] Do not put MergeableCStrings in their own section
Jul 28 2023, 8:25 PM · Restricted Project, Restricted Project
w2yehia closed D156202: [XCOFF] Do not put MergeableCStrings in their own section.
Jul 28 2023, 8:24 PM · Restricted Project, Restricted Project

Jul 26 2023

w2yehia added reviewers for D156202: [XCOFF] Do not put MergeableCStrings in their own section: daltenty, xingxue.
Jul 26 2023, 6:11 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D156202: [XCOFF] Do not put MergeableCStrings in their own section.
Jul 26 2023, 6:11 PM · Restricted Project, Restricted Project

Jul 24 2023

w2yehia requested review of D156202: [XCOFF] Do not put MergeableCStrings in their own section.
Jul 24 2023, 9:44 PM · Restricted Project, Restricted Project

Jul 21 2023

w2yehia added a comment to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

@fhahn can you please review when you have a chance. Thanks

Jul 21 2023, 10:17 AM · Restricted Project, Restricted Project
w2yehia added inline comments to D155290: [PGO] Use Unique Profile Files when New Processes are Forked.
Jul 21 2023, 5:22 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2023

w2yehia added a reviewer for D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin: MaskRay.
Jul 19 2023, 2:45 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

move tests into its own file

Jul 19 2023, 2:44 PM · Restricted Project, Restricted Project
w2yehia committed rGf94608a16489: Define llvm::thread::DefaultStackSize to 4 megabytes on AIX (authored by w2yehia).
Define llvm::thread::DefaultStackSize to 4 megabytes on AIX
Jul 19 2023, 11:58 AM · Restricted Project, Restricted Project
w2yehia closed D155731: [AIX] Define llvm::thread::DefaultStackSize to 4 megabytes on AIX.
Jul 19 2023, 11:58 AM · Restricted Project, Restricted Project
w2yehia requested review of D155731: [AIX] Define llvm::thread::DefaultStackSize to 4 megabytes on AIX.
Jul 19 2023, 10:57 AM · Restricted Project, Restricted Project
w2yehia committed rG645f6dcd69a5: [ThinLTO][AIX] Enable thinlto on AIX (authored by w2yehia).
[ThinLTO][AIX] Enable thinlto on AIX
Jul 19 2023, 10:37 AM · Restricted Project, Restricted Project
w2yehia closed D155700: [ThinLTO][AIX] Enable thinLTO on AIX.
Jul 19 2023, 10:37 AM · Restricted Project, Restricted Project
w2yehia added inline comments to D155700: [ThinLTO][AIX] Enable thinLTO on AIX.
Jul 19 2023, 10:32 AM · Restricted Project, Restricted Project
w2yehia requested review of D155700: [ThinLTO][AIX] Enable thinLTO on AIX.
Jul 19 2023, 6:37 AM · Restricted Project, Restricted Project

Jul 11 2023

w2yehia added a reviewer for D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin: phosek.
Jul 11 2023, 9:32 AM · Restricted Project, Restricted Project
w2yehia added a comment to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

@MaskRay @fhahn ping. Thanks

Jul 11 2023, 9:32 AM · Restricted Project, Restricted Project
w2yehia committed rG7ec844c881a2: [Doc][clang] Some PGO documentation improvements. (authored by w2yehia).
[Doc][clang] Some PGO documentation improvements.
Jul 11 2023, 9:27 AM · Restricted Project, Restricted Project
w2yehia closed D154239: [Doc][clang] Some PGO documentation improvements..
Jul 11 2023, 9:27 AM · Restricted Project, Restricted Project

Jun 30 2023

w2yehia added a reviewer for D154239: [Doc][clang] Some PGO documentation improvements.: phosek.
Jun 30 2023, 11:07 AM · Restricted Project, Restricted Project
w2yehia added reviewers for D154239: [Doc][clang] Some PGO documentation improvements.: vsk, MaskRay.
Jun 30 2023, 11:06 AM · Restricted Project, Restricted Project
w2yehia requested review of D154239: [Doc][clang] Some PGO documentation improvements..
Jun 30 2023, 10:25 AM · Restricted Project, Restricted Project
w2yehia added a comment to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

@fhahn ping. Thanks

Jun 30 2023, 10:22 AM · Restricted Project, Restricted Project

Jun 26 2023

w2yehia added inline comments to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.
Jun 26 2023, 7:51 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

forgot to touch dummy input file.

Jun 26 2023, 7:47 AM · Restricted Project, Restricted Project

Jun 22 2023

w2yehia added a comment to D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.

this was caught when I tried running test-suite with -flto=thin

Jun 22 2023, 12:56 PM · Restricted Project, Restricted Project
w2yehia requested review of D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin.
Jun 22 2023, 12:55 PM · Restricted Project, Restricted Project

Apr 4 2023

w2yehia committed rG09ab1f335bce: [AIX][PGO] Add malloc error handling and deallocation to FindBinaryId function (authored by w2yehia).
[AIX][PGO] Add malloc error handling and deallocation to FindBinaryId function
Apr 4 2023, 12:58 PM · Restricted Project, Restricted Project
w2yehia closed D147559: [AIX][PGO] Add malloc error handling and deallocation to FindBinaryId function.
Apr 4 2023, 12:58 PM · Restricted Project, Restricted Project
w2yehia added a reviewer for D147559: [AIX][PGO] Add malloc error handling and deallocation to FindBinaryId function: stephenpeckham.
Apr 4 2023, 12:32 PM · Restricted Project, Restricted Project
w2yehia requested review of D147559: [AIX][PGO] Add malloc error handling and deallocation to FindBinaryId function.
Apr 4 2023, 12:32 PM · Restricted Project, Restricted Project

Mar 29 2023

w2yehia committed rG0e2ed90516ee: [AIX][PGO] Teach profile runtime to read build-id (authored by w2yehia).
[AIX][PGO] Teach profile runtime to read build-id
Mar 29 2023, 8:18 AM · Restricted Project, Restricted Project
w2yehia closed D146976: [AIX][PGO] Teach profile runtime to read build-id.
Mar 29 2023, 8:17 AM · Restricted Project, Restricted Project
w2yehia updated the diff for D146976: [AIX][PGO] Teach profile runtime to read build-id.
Mar 29 2023, 7:50 AM · Restricted Project, Restricted Project

Mar 28 2023

w2yehia added inline comments to D146976: [AIX][PGO] Teach profile runtime to read build-id.
Mar 28 2023, 12:43 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D146976: [AIX][PGO] Teach profile runtime to read build-id.
Mar 28 2023, 12:43 PM · Restricted Project, Restricted Project
w2yehia committed rG256914bf1c13: [AIX] Update release notes regarding -mxcoff-build-id and the profile runtime (authored by w2yehia).
[AIX] Update release notes regarding -mxcoff-build-id and the profile runtime
Mar 28 2023, 7:53 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2023

w2yehia added reviewers for D146976: [AIX][PGO] Teach profile runtime to read build-id: daltenty, qiongsiwu1, stephenpeckham, MaskRay.
Mar 27 2023, 8:45 AM · Restricted Project, Restricted Project
w2yehia requested review of D146976: [AIX][PGO] Teach profile runtime to read build-id.
Mar 27 2023, 8:44 AM · Restricted Project, Restricted Project
w2yehia committed rGda92f2fb33c4: [AIX][Driver] Implement -mxcoff-build-id option (authored by w2yehia).
[AIX][Driver] Implement -mxcoff-build-id option
Mar 27 2023, 8:38 AM · Restricted Project, Restricted Project
w2yehia closed D146431: [AIX][Driver] Implement -mxcoff-build-id option..
Mar 27 2023, 8:37 AM · Restricted Project, Restricted Project

Mar 25 2023

w2yehia updated the diff for D146431: [AIX][Driver] Implement -mxcoff-build-id option..
Mar 25 2023, 10:54 PM · Restricted Project, Restricted Project
w2yehia added a comment to D146431: [AIX][Driver] Implement -mxcoff-build-id option..

Let's document the option as well under: https://clang.llvm.org/docs/ClangCommandLineReference.html#powerpc

Mar 25 2023, 10:54 PM · Restricted Project, Restricted Project

Mar 24 2023

w2yehia updated the diff for D146431: [AIX][Driver] Implement -mxcoff-build-id option..

Fix bug: StringRef::lower() returns a std::string as a temporary, and Twine doesn't own the memory of the substrings.
The temporary should be used in the same C++ statement so that there's no lifetime issues.

Mar 24 2023, 12:49 PM · Restricted Project, Restricted Project

Mar 22 2023

w2yehia added a comment to D146431: [AIX][Driver] Implement -mxcoff-build-id option..

Is there any reason to require an even number of hex digits? Or to convert the hex string to lower case?

Mar 22 2023, 1:45 PM · Restricted Project, Restricted Project
w2yehia added inline comments to D146431: [AIX][Driver] Implement -mxcoff-build-id option..
Mar 22 2023, 1:42 PM · Restricted Project, Restricted Project

Mar 20 2023

w2yehia updated the diff for D146431: [AIX][Driver] Implement -mxcoff-build-id option..

add new test

Mar 20 2023, 12:46 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D146431: [AIX][Driver] Implement -mxcoff-build-id option..
Mar 20 2023, 12:36 PM · Restricted Project, Restricted Project
w2yehia added reviewers for D146431: [AIX][Driver] Implement -mxcoff-build-id option.: qiongsiwu, stephenpeckham.
Mar 20 2023, 12:04 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D146431: [AIX][Driver] Implement -mxcoff-build-id option..

add "<0xHEXSTRING>" to the option documentation.

Mar 20 2023, 12:03 PM · Restricted Project, Restricted Project
w2yehia added reviewers for D146431: [AIX][Driver] Implement -mxcoff-build-id option.: daltenty, MaskRay.
Mar 20 2023, 8:44 AM · Restricted Project, Restricted Project
w2yehia requested review of D146431: [AIX][Driver] Implement -mxcoff-build-id option..
Mar 20 2023, 8:41 AM · Restricted Project, Restricted Project

Mar 18 2023

w2yehia committed rG787fbad57e05: [NFC][AIX][PGO] Create AIX specific compiler-rt profile file. (authored by w2yehia).
[NFC][AIX][PGO] Create AIX specific compiler-rt profile file.
Mar 18 2023, 1:22 PM · Restricted Project, Restricted Project

Mar 14 2023

w2yehia accepted D145899: [AIX][Clang] Respect -r when invoking the linker.

LGTM. Would be nice to get @daltenty 's approval too.

Mar 14 2023, 1:22 PM · Restricted Project, Restricted Project

Mar 13 2023

w2yehia added a comment to D145899: [AIX][Clang] Respect -r when invoking the linker.

testcase?

Mar 13 2023, 10:17 AM · Restricted Project, Restricted Project

Mar 8 2023

w2yehia added inline comments to D144190: [AIX][clang] Storage Locations for Constant Pointers.
Mar 8 2023, 9:31 AM · Restricted Project, Restricted Project

Feb 21 2023

w2yehia accepted D144302: [PGO] Setting ValueProfNode Array's Alignment.

LGTM

Feb 21 2023, 7:45 PM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2023

w2yehia added inline comments to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.
Feb 2 2023, 8:15 AM · Restricted Project, Restricted Project

Jan 25 2023

w2yehia committed rG5e72407635a4: [flang] Add driver install directory to AIX toolchain program paths list. (authored by pscoro).
[flang] Add driver install directory to AIX toolchain program paths list.
Jan 25 2023, 4:40 PM · Restricted Project, Restricted Project
w2yehia closed D140628: [flang] Add driver install directory to AIX toolchain program paths list.
Jan 25 2023, 4:40 PM · Restricted Project, Restricted Project

Jan 24 2023

w2yehia accepted D140628: [flang] Add driver install directory to AIX toolchain program paths list.
Jan 24 2023, 9:00 AM · Restricted Project, Restricted Project

Jan 12 2023

w2yehia added inline comments to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.
Jan 12 2023, 8:50 AM · Restricted Project, Restricted Project

Dec 19 2022

w2yehia added inline comments to D139924: LTO C API: always parse modules in opaque pointer mode..
Dec 19 2022, 3:56 PM · Restricted Project, Restricted Project

Nov 29 2022

w2yehia committed rGd4cb39287c50: [AIX][LTO] Properly respect LDR_CNTRL and set MAXDATA32 to 0xA0000000@DSA. (authored by w2yehia).
[AIX][LTO] Properly respect LDR_CNTRL and set MAXDATA32 to 0xA0000000@DSA.
Nov 29 2022, 2:16 PM · Restricted Project, Restricted Project
w2yehia closed D138944: [AIX][LTO] Properly respect LDR_CNTRL and set MAXDATA32 to 0xA0000000@DSA.
Nov 29 2022, 2:16 PM · Restricted Project, Restricted Project
w2yehia added reviewers for D138944: [AIX][LTO] Properly respect LDR_CNTRL and set MAXDATA32 to 0xA0000000@DSA: rzurob, qiongsiwu.
Nov 29 2022, 12:52 PM · Restricted Project, Restricted Project
w2yehia requested review of D138944: [AIX][LTO] Properly respect LDR_CNTRL and set MAXDATA32 to 0xA0000000@DSA.
Nov 29 2022, 12:48 PM · Restricted Project, Restricted Project

Nov 25 2022

w2yehia accepted D138729: [AIX][LTO] Teaching lto-aix-system-assembler Relative Path and Tilde Resolution.
Nov 25 2022, 11:11 AM · Restricted Project, Restricted Project

Oct 27 2022

w2yehia committed rGc8eb932ce640: [PGO] Simplify InstrProfilingRuntime.cpp (authored by w2yehia).
[PGO] Simplify InstrProfilingRuntime.cpp
Oct 27 2022, 10:13 PM · Restricted Project, Restricted Project
w2yehia accepted D136874: [clang][LTO] Passing vec-extabi to the Backend on AIX.
Oct 27 2022, 8:49 PM · Restricted Project, Restricted Project
w2yehia abandoned D134253: [AIX][PGO] Add missing visibility attribute on an internal function..

Fixed by D136192

Oct 27 2022, 9:10 AM · Restricted Project

Oct 26 2022

w2yehia committed rGaceb67eeb516: Add a testcase for D136192. (authored by w2yehia).
Add a testcase for D136192.
Oct 26 2022, 7:42 AM · Restricted Project, Restricted Project

Oct 25 2022

w2yehia added a comment to D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking..

I wasn't included as a reviewer on D124857 and I missed that change so couldn't comment there, but I'm not a fan of including the AIX support in InstrProfilingPlatformLinux.c. AIX is neither Linux nor ELF-based and big chunks of that file are now #ifdefed out making it harder to comprehend which part is used where. I'd prefer introducing InstrProfilingPlatformAIX.c, moving the AIX-specific logic there, and then figuring out how to possibly share common parts between InstrProfilingPlatformLinux.c and InstrProfilingPlatformAIX.c, for example by moving them to an .inc file.

Oct 25 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 21 2022

w2yehia committed rG461a1836d3d7: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking. (authored by w2yehia).
[PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.
Oct 21 2022, 9:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia closed D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking..
Oct 21 2022, 9:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

w2yehia accepted D135885: [clang][LTO][NFC] Adding More Tests for AIX Options.
Oct 20 2022, 2:39 PM · Restricted Project, Restricted Project
w2yehia edited reviewers for D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking., added: phosek; removed: phodju.
Oct 20 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia updated subscribers of D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking..

@phosek @MaskRay If you can kindly review this patch as it affects non-AIX platforms with the changes in compiler-rt/lib/profile/InstrProfilingRuntime.cpp. I'm hoping the change are like for like but I cannot be sure for all platforms.

Oct 20 2022, 12:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia added a reviewer for D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.: phodju.
Oct 20 2022, 12:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
w2yehia added a reviewer for D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.: sfertile.
Oct 20 2022, 12:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project