Page MenuHomePhabricator

timshen (Tim Shen)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2015, 6:12 PM (226 w, 6 d)

Recent Activity

Wed, Mar 11

timshen committed rGd00f5632f39e: [mlir] Add a simplifying wrapper for generateCopy and expose it. (authored by timshen).
[mlir] Add a simplifying wrapper for generateCopy and expose it.
Wed, Mar 11, 4:31 PM
timshen closed D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..
Wed, Mar 11, 4:31 PM · Restricted Project
timshen added inline comments to D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..
Wed, Mar 11, 3:19 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address all comments.

Wed, Mar 11, 3:19 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Update documentation.

Wed, Mar 11, 1:01 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address comments.

Wed, Mar 11, 11:52 AM · Restricted Project
timshen committed rGced0dd8e5104: [MLIR] Guard DMA-specific logic with DMA option (authored by timshen).
[MLIR] Guard DMA-specific logic with DMA option
Wed, Mar 11, 11:24 AM
timshen closed D75963: [MLIR] Guard DMA-specific logic with DMA option.
Wed, Mar 11, 11:24 AM · Restricted Project

Tue, Mar 10

timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address comments.

Tue, Mar 10, 6:05 PM · Restricted Project
timshen added a comment to D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address comments.

Tue, Mar 10, 6:05 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Add a test.

Tue, Mar 10, 6:05 PM · Restricted Project
timshen planned changes to D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

I'm going to add some tests.

Tue, Mar 10, 4:58 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Update comments.

Tue, Mar 10, 4:26 PM · Restricted Project
timshen created D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..
Tue, Mar 10, 4:26 PM · Restricted Project
timshen created D75963: [MLIR] Guard DMA-specific logic with DMA option.
Tue, Mar 10, 3:54 PM · Restricted Project

Feb 28 2020

timshen committed rG67c1615440ca: [MLIR] Add vector support for fpexp and fptrunc. (authored by timshen).
[MLIR] Add vector support for fpexp and fptrunc.
Feb 28 2020, 12:56 PM
timshen closed D75150: [MLIR] Add vector support for fpexp and fptrunc..
Feb 28 2020, 12:56 PM · Restricted Project
timshen added a comment to D75150: [MLIR] Add vector support for fpexp and fptrunc..

I'm going to commit this, since the comment is addressed.

Feb 28 2020, 12:30 PM · Restricted Project
timshen committed rG0d65000e1177: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types. (authored by timshen).
[MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types.
Feb 28 2020, 12:21 PM
timshen committed rG2a00ae398452: [MLIR] Add LLVMConversionTarget as a customization point. NFC. (authored by timshen).
[MLIR] Add LLVMConversionTarget as a customization point. NFC.
Feb 28 2020, 12:21 PM
timshen closed D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Feb 28 2020, 12:21 PM · Restricted Project
timshen closed D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..
Feb 28 2020, 12:21 PM · Restricted Project

Feb 27 2020

timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Stylistic change and add a comment on why not support memref at the moment.

Feb 27 2020, 1:04 PM · Restricted Project

Feb 26 2020

timshen added inline comments to D75150: [MLIR] Add vector support for fpexp and fptrunc..
Feb 26 2020, 8:39 PM · Restricted Project
timshen updated the diff for D75150: [MLIR] Add vector support for fpexp and fptrunc..

Add more tests.

Feb 26 2020, 8:39 PM · Restricted Project
timshen added inline comments to D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Feb 26 2020, 8:30 PM · Restricted Project
timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Update per comments.

Feb 26 2020, 8:30 PM · Restricted Project
timshen updated the diff for D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Update comments.

Feb 26 2020, 8:30 PM · Restricted Project
timshen added a comment to D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Same as @mehdi_amini, I'd like to understand why is this necessary.

Feb 26 2020, 6:25 PM · Restricted Project
timshen added a comment to D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Can you provide a description for this patch which would motivate this please?

Feb 26 2020, 6:25 PM · Restricted Project
timshen updated the diff for D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Update comments.

Feb 26 2020, 6:25 PM · Restricted Project

Feb 25 2020

timshen created D75150: [MLIR] Add vector support for fpexp and fptrunc..
Feb 25 2020, 3:54 PM · Restricted Project
timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Error message.

Feb 25 2020, 2:27 PM · Restricted Project
timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Add more tests.

Feb 25 2020, 2:19 PM · Restricted Project
timshen updated the diff for D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Spaces.

Feb 25 2020, 2:08 PM · Restricted Project
timshen added a parent revision for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types.: D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..
Feb 25 2020, 2:07 PM · Restricted Project
timshen added a child revision for D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC.: D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Feb 25 2020, 2:07 PM · Restricted Project
timshen created D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Feb 25 2020, 2:07 PM · Restricted Project
timshen created D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..
Feb 25 2020, 2:07 PM · Restricted Project

Feb 24 2020

timshen abandoned D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..
Feb 24 2020, 8:30 PM · Restricted Project
timshen abandoned D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..
Feb 24 2020, 8:30 PM · Restricted Project

Feb 18 2020

timshen committed rGf581e655ec3f: [MLIR] Add std.assume_alignment op. (authored by timshen).
[MLIR] Add std.assume_alignment op.
Feb 18 2020, 6:03 PM
timshen committed rGb762bbd4c868: [MLIR] change NVVM.mma.sync to the most useful variant. (authored by timshen).
[MLIR] change NVVM.mma.sync to the most useful variant.
Feb 18 2020, 6:03 PM
timshen closed D74378: [MLIR] Add std.assume_align op..
Feb 18 2020, 6:03 PM · Restricted Project
timshen closed D74655: [MLIR] change NVVM.mma.sync to the most useful variant..
Feb 18 2020, 6:03 PM · Restricted Project

Feb 14 2020

timshen created D74655: [MLIR] change NVVM.mma.sync to the most useful variant..
Feb 14 2020, 3:34 PM · Restricted Project
timshen added a comment to D74378: [MLIR] Add std.assume_align op..

Pinging @rriddle , can you take another look? Thanks!

Feb 14 2020, 1:34 PM · Restricted Project

Feb 11 2020

timshen added a comment to D74378: [MLIR] Add std.assume_align op..

Done. Used ODS and assemblyFormat syntax. My brain didn't wire up to the simple and new stuff. Thanks!

Feb 11 2020, 12:51 PM · Restricted Project
timshen updated the diff for D74378: [MLIR] Add std.assume_align op..

Address all comments.

Feb 11 2020, 12:51 PM · Restricted Project

Feb 10 2020

timshen created D74378: [MLIR] Add std.assume_align op..
Feb 10 2020, 8:13 PM · Restricted Project

Jan 30 2020

timshen committed rG3ccaac3cdd8f: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get(). (authored by timshen).
[mlir] Add MemRefTypeBuilder and refactor some MemRefType::get().
Jan 30 2020, 11:38 PM
timshen closed D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..
Jan 30 2020, 11:38 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Update one of the callsites to not use auto.

Jan 30 2020, 2:55 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Update comments and fix the memref-normalize failure.

Jan 30 2020, 2:44 PM · Restricted Project

Jan 28 2020

timshen added inline comments to D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..
Jan 28 2020, 3:02 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Update comments.

Jan 28 2020, 3:02 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Address comments.

Jan 28 2020, 2:54 PM · Restricted Project

Jan 26 2020

timshen planned changes to D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..
Jan 26 2020, 8:09 PM · Restricted Project
timshen planned changes to D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..

I'm holding off the review since the discussion in the mailing list is still ongoing.

Jan 26 2020, 8:08 PM · Restricted Project

Jan 23 2020

timshen updated the diff for D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..

Add a test for power of 2 alignment.

Jan 23 2020, 3:01 PM · Restricted Project
timshen added a comment to D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

I personally love the API with chainable calls but we should really get @rriddle 's buyin on this.

Jan 23 2020, 2:42 PM · Restricted Project
timshen updated the diff for D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..

Fix an arc mistake.

Jan 23 2020, 2:40 PM · Restricted Project
timshen updated the diff for D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..

Backport.

Jan 23 2020, 2:32 PM · Restricted Project
timshen updated the diff for D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..

Backport the actual code of removing alignment from AllocOp from the child patch.

Jan 23 2020, 2:31 PM · Restricted Project
timshen added a parent revision for D73298: [mlir] Propagate alignment annotations to LLVM loads and stores.: D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..
Jan 23 2020, 2:31 PM · Restricted Project
timshen added a child revision for D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp.: D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..
Jan 23 2020, 2:31 PM · Restricted Project
timshen created D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..
Jan 23 2020, 2:31 PM · Restricted Project
timshen added a child revision for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get().: D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..
Jan 23 2020, 2:31 PM · Restricted Project
timshen added a parent revision for D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp.: D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..
Jan 23 2020, 2:31 PM · Restricted Project
timshen created D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..
Jan 23 2020, 2:22 PM · Restricted Project
timshen created D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..
Jan 23 2020, 2:20 PM · Restricted Project
timshen accepted D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>)..

What's the test situation for these headers?

Jan 23 2020, 12:46 PM · Restricted Project

Jan 21 2020

timshen committed rG7b771ed44848: [APInt] Fix tests that had wrong assumption about sdivs with negative quotient. (authored by timshen).
[APInt] Fix tests that had wrong assumption about sdivs with negative quotient.
Jan 21 2020, 1:56 PM
timshen closed D70156: [APInt] Fix tests that had wrong assumption about sdivs with negative quotient..
Jan 21 2020, 1:56 PM · Restricted Project

Nov 27 2019

timshen added a reviewer for D70686: Implement LWG#1203 for raw_ostream: timshen.
Nov 27 2019, 2:27 PM · Restricted Project
timshen accepted D70686: Implement LWG#1203 for raw_ostream.
Nov 27 2019, 2:27 PM · Restricted Project

Nov 19 2019

timshen updated the diff for D70156: [APInt] Fix tests that had wrong assumption about sdivs with negative quotient..

EXPECT_TRUE -> EXPECT_EQ.

Nov 19 2019, 5:09 PM · Restricted Project

Nov 12 2019

timshen added a comment to D70156: [APInt] Fix tests that had wrong assumption about sdivs with negative quotient..

This fixes wrong tests introduced by D48498

Nov 12 2019, 6:26 PM · Restricted Project
timshen created D70156: [APInt] Fix tests that had wrong assumption about sdivs with negative quotient..
Nov 12 2019, 6:26 PM · Restricted Project

Oct 22 2019

timshen accepted D69324: [NVPTX] Add llvm.nvvm.mma.m8n8k4.* intrinsics..
Oct 22 2019, 5:31 PM · Restricted Project

Oct 11 2019

timshen accepted D68892: [NVPTX] Restructure shfl instrinsics and add variants that return a predicate..
Oct 11 2019, 4:51 PM · Restricted Project

Oct 2 2019

timshen updated subscribers of rL371640: LiveIntervals: Split live intervals on multiple dead defs.
Oct 2 2019, 1:41 PM
timshen added a comment to rL371640: LiveIntervals: Split live intervals on multiple dead defs.

pranavb@quicinc.com is looking at this.

Oct 2 2019, 1:40 PM

Sep 13 2019

timshen committed rG573863ea180b: [LLDB] Add missing breaks for switch statement (authored by timshen).
[LLDB] Add missing breaks for switch statement
Sep 13 2019, 2:59 PM
timshen committed rL371902: [LLDB] Add missing breaks for switch statement.
[LLDB] Add missing breaks for switch statement
Sep 13 2019, 2:59 PM
timshen committed rGfc637d03b18c: Fix test to use %t for newly created files. (authored by timshen).
Fix test to use %t for newly created files.
Sep 13 2019, 2:07 PM
timshen committed rL371897: Fix test to use %t for newly created files..
Fix test to use %t for newly created files.
Sep 13 2019, 2:05 PM
timshen added a comment to rL371824: Revert "Fix test failures after r371640".

Sorry for not reverting this in the first place and causing bots failures, and thank you!

Sep 13 2019, 7:59 AM

Sep 12 2019

timshen committed rGa31c521f5ebd: Temporarily revert r371640 "LiveIntervals: Split live intervals on multiple… (authored by timshen).
Temporarily revert r371640 "LiveIntervals: Split live intervals on multiple…
Sep 12 2019, 6:37 PM
timshen committed rL371802: Temporarily revert r371640 "LiveIntervals: Split live intervals on multiple….
Temporarily revert r371640 "LiveIntervals: Split live intervals on multiple…
Sep 12 2019, 6:37 PM
timshen added a comment to rL371640: LiveIntervals: Split live intervals on multiple dead defs.

That's fine, it's only one of a series of problems in the testcase I'm trying to fix

Sep 12 2019, 6:37 PM
timshen added a comment to rL371640: LiveIntervals: Split live intervals on multiple dead defs.

We've seen internal Hexagon test failures revealed by this patch, and here is the PR: https://bugs.llvm.org/show_bug.cgi?id=43302. Are you ok with temporarily rolling back this patch while we are investigating the issue?

Sep 12 2019, 5:33 PM
timshen committed rG75e963ec6fae: [ClangTidy] Adjust the name getCheckName to getCheckerName due to API change. (authored by timshen).
[ClangTidy] Adjust the name getCheckName to getCheckerName due to API change.
Sep 12 2019, 2:18 PM
timshen committed rL371773: [ClangTidy] Adjust the name getCheckName to getCheckerName due to API change..
[ClangTidy] Adjust the name getCheckName to getCheckerName due to API change.
Sep 12 2019, 2:17 PM
timshen updated subscribers of rL371772: Fix llvm-reduce tests so that they don't assume the source code is.
Sep 12 2019, 2:07 PM
timshen committed rG396d0e1635b5: Fix llvm-reduce tests so that they don't assume the source code is writable. (authored by timshen).
Fix llvm-reduce tests so that they don't assume the source code is writable.
Sep 12 2019, 2:03 PM
timshen committed rL371772: Fix llvm-reduce tests so that they don't assume the source code is.
Fix llvm-reduce tests so that they don't assume the source code is
Sep 12 2019, 2:03 PM

Aug 23 2019

timshen accepted D66665: [CUDA] Use activemask.b32 instruction to implement __activemask w/ CUDA-9.2+.
Aug 23 2019, 3:39 PM · Restricted Project

Jul 18 2019

timshen added a comment to D41412: [libcxx] implement <experimental/simd> concat() and split().

I spoke to @EricWF who is willing to take a look at all these patches. However, I don't know when exactly will the review starts.

Jul 18 2019, 12:04 PM · Restricted Project

Jul 16 2019

timshen added a comment to D41412: [libcxx] implement <experimental/simd> concat() and split().

Hi @timshen,

I am very interested in these patches. Any chance you can take up the upstreaming process again?

Jul 16 2019, 4:59 PM · Restricted Project