Page MenuHomePhabricator

timshen (Tim Shen)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2015, 6:12 PM (288 w, 4 d)

Recent Activity

Feb 19 2021

timshen committed rGa0757d8ebdef: Patch by @wecing (Chenguang Wang). (authored by timshen).
Patch by @wecing (Chenguang Wang).
Feb 19 2021, 12:45 PM
timshen closed D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Feb 19 2021, 12:45 PM · Restricted Project
timshen accepted D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Nicely done!

Feb 19 2021, 12:18 PM · Restricted Project

Feb 12 2021

timshen added inline comments to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Feb 12 2021, 11:55 AM · Restricted Project

Feb 10 2021

timshen added inline comments to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Feb 10 2021, 11:26 AM · Restricted Project
timshen added inline comments to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Feb 10 2021, 11:18 AM · Restricted Project
timshen added a reviewer for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint: timshen.
Feb 10 2021, 11:18 AM · Restricted Project

Sep 29 2020

timshen committed rGf0506e4923cd: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no… (authored by timshen).
[MLIR] Avoid adding debuginfo for a function if it contains calls that has no…
Sep 29 2020, 1:52 PM
timshen closed D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..
Sep 29 2020, 1:52 PM · Restricted Project

Sep 24 2020

timshen added a comment to D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

@mehdi_amini , can you take a look? River doesn't seem to be around atm.

Did you miss my last question?
I'm fine with this right now, but I wanted to make sure I understand why we don't just verify inside translateModuleToLLVMIR directly, and if we could fix/change translateModuleToLLVMIR to have this?

Sep 24 2020, 12:38 PM · Restricted Project
timshen updated the diff for D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

Move the verification to translateLLVMIR.

Sep 24 2020, 12:38 PM · Restricted Project
timshen added a comment to D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

@mehdi_amini , can you take a look? River doesn't seem to be around atm.

Sep 24 2020, 12:02 PM · Restricted Project
timshen added a reviewer for D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info.: mehdi_amini.
Sep 24 2020, 12:02 PM · Restricted Project

Sep 23 2020

timshen updated the diff for D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

Adjust tests.

Sep 23 2020, 1:54 PM · Restricted Project
timshen updated the diff for D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

Updated the place to verify the LLVM IR.

Sep 23 2020, 1:39 PM · Restricted Project

Sep 22 2020

timshen requested review of D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..
Sep 22 2020, 11:38 PM · Restricted Project

Aug 7 2020

timshen committed rGb53fd9cdba4d: [MLIR] Add getSizeInBits() for tensor of complex (authored by timshen).
[MLIR] Add getSizeInBits() for tensor of complex
Aug 7 2020, 12:39 PM
timshen closed D85382: [MLIR] Add getSizeInBits() for tensor of complex.
Aug 7 2020, 12:39 PM · Restricted Project
timshen updated the diff for D85382: [MLIR] Add getSizeInBits() for tensor of complex.

Remove the assert.

Aug 7 2020, 12:28 PM · Restricted Project

Aug 5 2020

timshen requested review of D85382: [MLIR] Add getSizeInBits() for tensor of complex.
Aug 5 2020, 5:28 PM · Restricted Project

Jun 16 2020

timshen committed rGb877f33d93a2: [MLIR] Add documentation for generate-check-lines.py (authored by timshen).
[MLIR] Add documentation for generate-check-lines.py
Jun 16 2020, 12:07 PM
timshen added a comment to D81903: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source (test) file..

Added documentation in succeeding commits.

Jun 16 2020, 12:05 PM · Restricted Project
timshen committed rG25b3806788ae: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source… (authored by timshen).
[MLIR] Rework generate-test-checks.py to attach CHECK lines to the source…
Jun 16 2020, 11:34 AM
timshen committed rGa6150de4473a: [MLIR] Remove generated spaces at eof for generate-test-checks.py. (authored by timshen).
[MLIR] Remove generated spaces at eof for generate-test-checks.py.
Jun 16 2020, 11:34 AM
timshen closed D81903: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source (test) file..
Jun 16 2020, 11:34 AM · Restricted Project

Jun 15 2020

timshen updated the summary of D81903: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source (test) file..
Jun 15 2020, 8:23 PM · Restricted Project
timshen updated the diff for D81903: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source (test) file..

Remove extra empty line in the end.

Jun 15 2020, 8:23 PM · Restricted Project
timshen updated the diff for D81903: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source (test) file..

Fix typo.

Jun 15 2020, 8:23 PM · Restricted Project
timshen created D81903: [MLIR] Rework generate-test-checks.py to attach CHECK lines to the source (test) file..
Jun 15 2020, 7:51 PM · Restricted Project

May 28 2020

timshen abandoned D80672: [MLIR] Add support for resolving symbols to in-process functions for ExecutionEngine..

You are right, registerSymbols works.

May 28 2020, 1:45 PM · Restricted Project

May 27 2020

timshen abandoned D79457: [MLIR] Add static offset support for ViewOp's source memref..
May 27 2020, 5:29 PM · Restricted Project, Restricted Project
timshen created D80672: [MLIR] Add support for resolving symbols to in-process functions for ExecutionEngine..
May 27 2020, 4:23 PM · Restricted Project

May 7 2020

timshen accepted D79541: [mlir] Simplify and better document std.view semantics.
May 7 2020, 2:09 PM · Restricted Project
timshen added inline comments to D79541: [mlir] Simplify and better document std.view semantics.
May 7 2020, 2:09 PM · Restricted Project
timshen added inline comments to D79541: [mlir] Simplify and better document std.view semantics.
May 7 2020, 1:03 PM · Restricted Project

May 6 2020

timshen accepted D79515: [CUDA] Enable existing builtins for PTX7.0 as well..
May 6 2020, 1:35 PM · Restricted Project

May 5 2020

timshen updated the summary of D79457: [MLIR] Add static offset support for ViewOp's source memref..
May 5 2020, 4:45 PM · Restricted Project, Restricted Project
timshen created D79457: [MLIR] Add static offset support for ViewOp's source memref..
May 5 2020, 4:45 PM · Restricted Project, Restricted Project
timshen accepted D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5.
May 5 2020, 3:40 PM · Restricted Project

Mar 11 2020

timshen committed rGd00f5632f39e: [mlir] Add a simplifying wrapper for generateCopy and expose it. (authored by timshen).
[mlir] Add a simplifying wrapper for generateCopy and expose it.
Mar 11 2020, 4:31 PM
timshen closed D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..
Mar 11 2020, 4:31 PM · Restricted Project
timshen added inline comments to D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..
Mar 11 2020, 3:19 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address all comments.

Mar 11 2020, 3:19 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Update documentation.

Mar 11 2020, 1:01 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address comments.

Mar 11 2020, 11:52 AM · Restricted Project
timshen committed rGced0dd8e5104: [MLIR] Guard DMA-specific logic with DMA option (authored by timshen).
[MLIR] Guard DMA-specific logic with DMA option
Mar 11 2020, 11:24 AM
timshen closed D75963: [MLIR] Guard DMA-specific logic with DMA option.
Mar 11 2020, 11:24 AM · Restricted Project

Mar 10 2020

timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address comments.

Mar 10 2020, 6:05 PM · Restricted Project
timshen added a comment to D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Address comments.

Mar 10 2020, 6:05 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Add a test.

Mar 10 2020, 6:05 PM · Restricted Project
timshen planned changes to D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

I'm going to add some tests.

Mar 10 2020, 4:58 PM · Restricted Project
timshen updated the diff for D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..

Update comments.

Mar 10 2020, 4:26 PM · Restricted Project
timshen created D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it..
Mar 10 2020, 4:26 PM · Restricted Project
timshen created D75963: [MLIR] Guard DMA-specific logic with DMA option.
Mar 10 2020, 3:54 PM · Restricted Project

Feb 28 2020

timshen committed rG67c1615440ca: [MLIR] Add vector support for fpexp and fptrunc. (authored by timshen).
[MLIR] Add vector support for fpexp and fptrunc.
Feb 28 2020, 12:56 PM
timshen closed D75150: [MLIR] Add vector support for fpexp and fptrunc..
Feb 28 2020, 12:56 PM · Restricted Project
timshen added a comment to D75150: [MLIR] Add vector support for fpexp and fptrunc..

I'm going to commit this, since the comment is addressed.

Feb 28 2020, 12:30 PM · Restricted Project
timshen committed rG0d65000e1177: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types. (authored by timshen).
[MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types.
Feb 28 2020, 12:21 PM
timshen committed rG2a00ae398452: [MLIR] Add LLVMConversionTarget as a customization point. NFC. (authored by timshen).
[MLIR] Add LLVMConversionTarget as a customization point. NFC.
Feb 28 2020, 12:21 PM
timshen closed D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Feb 28 2020, 12:21 PM · Restricted Project
timshen closed D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..
Feb 28 2020, 12:21 PM · Restricted Project

Feb 27 2020

timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Stylistic change and add a comment on why not support memref at the moment.

Feb 27 2020, 1:04 PM · Restricted Project

Feb 26 2020

timshen added inline comments to D75150: [MLIR] Add vector support for fpexp and fptrunc..
Feb 26 2020, 8:39 PM · Restricted Project
timshen updated the diff for D75150: [MLIR] Add vector support for fpexp and fptrunc..

Add more tests.

Feb 26 2020, 8:39 PM · Restricted Project
timshen added inline comments to D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Feb 26 2020, 8:30 PM · Restricted Project
timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Update per comments.

Feb 26 2020, 8:30 PM · Restricted Project
timshen updated the diff for D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Update comments.

Feb 26 2020, 8:30 PM · Restricted Project
timshen added a comment to D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Same as @mehdi_amini, I'd like to understand why is this necessary.

Feb 26 2020, 6:25 PM · Restricted Project
timshen added a comment to D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Can you provide a description for this patch which would motivate this please?

Feb 26 2020, 6:25 PM · Restricted Project
timshen updated the diff for D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Update comments.

Feb 26 2020, 6:25 PM · Restricted Project

Feb 25 2020

timshen created D75150: [MLIR] Add vector support for fpexp and fptrunc..
Feb 25 2020, 3:54 PM · Restricted Project
timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Error message.

Feb 25 2020, 2:27 PM · Restricted Project
timshen updated the diff for D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..

Add more tests.

Feb 25 2020, 2:19 PM · Restricted Project
timshen updated the diff for D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..

Spaces.

Feb 25 2020, 2:08 PM · Restricted Project
timshen created D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Feb 25 2020, 2:07 PM · Restricted Project
timshen created D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC..
Feb 25 2020, 2:07 PM · Restricted Project

Feb 24 2020

timshen abandoned D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..
Feb 24 2020, 8:30 PM · Restricted Project
timshen abandoned D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..
Feb 24 2020, 8:30 PM · Restricted Project

Feb 18 2020

timshen committed rGf581e655ec3f: [MLIR] Add std.assume_alignment op. (authored by timshen).
[MLIR] Add std.assume_alignment op.
Feb 18 2020, 6:03 PM
timshen committed rGb762bbd4c868: [MLIR] change NVVM.mma.sync to the most useful variant. (authored by timshen).
[MLIR] change NVVM.mma.sync to the most useful variant.
Feb 18 2020, 6:03 PM
timshen closed D74378: [MLIR] Add std.assume_align op..
Feb 18 2020, 6:03 PM · Restricted Project
timshen closed D74655: [MLIR] change NVVM.mma.sync to the most useful variant..
Feb 18 2020, 6:03 PM · Restricted Project

Feb 14 2020

timshen created D74655: [MLIR] change NVVM.mma.sync to the most useful variant..
Feb 14 2020, 3:34 PM · Restricted Project
timshen added a comment to D74378: [MLIR] Add std.assume_align op..

Pinging @rriddle , can you take another look? Thanks!

Feb 14 2020, 1:34 PM · Restricted Project

Feb 11 2020

timshen added a comment to D74378: [MLIR] Add std.assume_align op..

Done. Used ODS and assemblyFormat syntax. My brain didn't wire up to the simple and new stuff. Thanks!

Feb 11 2020, 12:51 PM · Restricted Project
timshen updated the diff for D74378: [MLIR] Add std.assume_align op..

Address all comments.

Feb 11 2020, 12:51 PM · Restricted Project

Feb 10 2020

timshen created D74378: [MLIR] Add std.assume_align op..
Feb 10 2020, 8:13 PM · Restricted Project

Jan 30 2020

timshen committed rG3ccaac3cdd8f: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get(). (authored by timshen).
[mlir] Add MemRefTypeBuilder and refactor some MemRefType::get().
Jan 30 2020, 11:38 PM
timshen closed D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..
Jan 30 2020, 11:38 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Update one of the callsites to not use auto.

Jan 30 2020, 2:55 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Update comments and fix the memref-normalize failure.

Jan 30 2020, 2:44 PM · Restricted Project

Jan 28 2020

timshen added inline comments to D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..
Jan 28 2020, 3:02 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Update comments.

Jan 28 2020, 3:02 PM · Restricted Project
timshen updated the diff for D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

Address comments.

Jan 28 2020, 2:54 PM · Restricted Project

Jan 26 2020

timshen planned changes to D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..
Jan 26 2020, 8:09 PM · Restricted Project
timshen planned changes to D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..

I'm holding on the review since the discussion in the mailing list is still ongoing.

Jan 26 2020, 8:08 PM · Restricted Project

Jan 23 2020

timshen updated the diff for D73297: [mlir] Add alignment to MemRefType and remove alignment from AllocOp..

Add a test for power of 2 alignment.

Jan 23 2020, 3:01 PM · Restricted Project
timshen added a comment to D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get()..

I personally love the API with chainable calls but we should really get @rriddle 's buyin on this.

Jan 23 2020, 2:42 PM · Restricted Project
timshen updated the diff for D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..

Fix an arc mistake.

Jan 23 2020, 2:40 PM · Restricted Project
timshen updated the diff for D73298: [mlir] Propagate alignment annotations to LLVM loads and stores..

Backport.

Jan 23 2020, 2:32 PM · Restricted Project