Page MenuHomePhabricator

[unittests][CodeGen] Mark tests that cannot be executed with GTEST_SKIP()
ClosedPublic

Authored by ikudrin on May 19 2021, 2:51 AM.

Details

Summary

This helps to distinguish such tests from successfully passed ones.

Diff Detail

Event Timeline

ikudrin requested review of this revision.May 19 2021, 2:51 AM
ikudrin created this revision.

I see // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0 show up in llvm/unittests/CodeGen/DIEHashTest.cpp, llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp and clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp; would you consider updating those at the same time?

Other than that this LGTM, thank you!

dsanders accepted this revision.May 19 2021, 2:29 PM

LGTM too. Thanks!

This revision is now accepted and ready to land.May 19 2021, 2:29 PM

I see // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0 show up in llvm/unittests/CodeGen/DIEHashTest.cpp, llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp and clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp; would you consider updating those at the same time?

This patch is for llvm/unittests/CodeGen. There are D102710 for llvm/unittests/ExecutionEngine and D102643 for clang/unittests/StaticAnalyzer by their corresponding authors.

Other than that this LGTM, thank you!

Thanks!