[mlir][NFC] Move passes in test/lib/Transforms/ to a directory that mirrors what they test

[rriddle]

Summary

test/lib/Transforms/ has bitrot and become somewhat of a dumping grounds for testing pretty much any part of the project. This revision cleans this up, and moves the files within to a directory that reflects what is actually being tested.

[herhut]

Thank you for cleaning this up!

[jpienaar]

Thanks!

mlir/test/lib/Analysis/CMakeLists.txt

 # Exclude tests from libMLIR.so
 add_mlir_library(MLIRTestAnalysis
   TestAliasAnalysis.cpp
+  TestCallGraph.cpp
+  TestLiveness.cpp
+  TestMemRefBoundCheck.cpp
+  TestMemRefDependenceCheck.cpp
+  TestMemRefStrideCalculation.cpp
+  TestNumberOfExecutions.cpp
 
-  EXCLUDE_FROM_LIBMLIR
-
-  ADDITIONAL_HEADER_DIRS
-  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms
 
-  DEPENDS
-  MLIRStandardOpsIncGen
+  EXCLUDE_FROM_LIBMLIR
 
   LINK_LIBS PUBLIC
+  MLIRAffine
   MLIRAnalysis
+  MLIRMemRef
   MLIRPass
   MLIRTestDialect
   )
 
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../Dialect/Test)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../Dialect/Test)

mlir/test/lib/Analysis/TestMemRefBoundCheck.cpp

 // accesses.
 //
 //===----------------------------------------------------------------------===//
 
 #include "mlir/Analysis/AffineAnalysis.h"
 #include "mlir/Analysis/AffineStructures.h"
 #include "mlir/Analysis/Utils.h"
 #include "mlir/Dialect/Affine/IR/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/Builders.h"
 #include "mlir/Pass/Pass.h"
 #include "llvm/ADT/TypeSwitch.h"
 #include "llvm/Support/Debug.h"
 
 #define DEBUG_TYPE "memref-bound-check"
 
 using namespace mlir;

mlir/test/lib/Analysis/TestMemRefDependenceCheck.cpp

 //===- TestMemRefDependenceCheck.cpp - Test dep analysis ------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements a pass to run pair-wise memref access dependence checks.
 //
 //===----------------------------------------------------------------------===//
 
 #include "mlir/Analysis/AffineAnalysis.h"
 #include "mlir/Analysis/AffineStructures.h"
 #include "mlir/Analysis/Utils.h"
 #include "mlir/Dialect/Affine/IR/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/Builders.h"
 #include "mlir/Pass/Pass.h"
 #include "llvm/Support/Debug.h"
 
 #define DEBUG_TYPE "test-memref-dependence-check"
 
 using namespace mlir;
 

mlir/test/lib/Analysis/TestMemRefStrideCalculation.cpp

 //===- TestMemRefStrideCalculation.cpp - Pass to test strides computation--===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "mlir/Dialect/MemRef/IR/MemRef.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/BuiltinTypes.h"
 #include "mlir/Pass/Pass.h"
-#include "mlir/Transforms/Passes.h"
 
 using namespace mlir;
 
 namespace {
 struct TestMemRefStrideCalculation
     : public PassWrapper<TestMemRefStrideCalculation, FunctionPass> {
   void runOnFunction() override;
 };

mlir/test/lib/CMakeLists.txt

 add_subdirectory(Analysis)
+add_subdirectory(Conversion)
 add_subdirectory(Dialect)
 add_subdirectory(IR)
 add_subdirectory(Pass)
 add_subdirectory(Reducer)
 add_subdirectory(Rewrite)
 add_subdirectory(Transforms)

mlir/test/lib/Conversion/CMakeLists.txt

+add_subdirectory(StandardToLLVM)

mlir/test/lib/Conversion/StandardToLLVM/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRTestStandardToLLVM
+  TestConvertCallOp.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRLLVMIR
+  MLIRLLVMIRTransforms
+  MLIRPass
+  MLIRStandardToLLVM
+  MLIRTestDialect
+  )
+
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../../Dialect/Test)
+include_directories(${CMAKE_CURRENT_BINARY_DIR}/../../Dialect/Test)

mlir/test/lib/Dialect/Affine/CMakeLists.txt

 # Exclude tests from libMLIR.so
 add_mlir_library(MLIRAffineTransformsTestPasses
   TestAffineDataCopy.cpp
   TestAffineLoopUnswitching.cpp
+  TestAffineLoopParametricTiling.cpp
   TestLoopPermutation.cpp
   TestVectorizationUtils.cpp
 
   EXCLUDE_FROM_LIBMLIR
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/IR

mlir/test/lib/Dialect/CMakeLists.txt

 add_subdirectory(Affine)
+add_subdirectory(DLTI)
+add_subdirectory(GPU)
+add_subdirectory(Linalg)
+add_subdirectory(Math)
+add_subdirectory(SCF)
 add_subdirectory(Shape)
 add_subdirectory(SPIRV)
+add_subdirectory(StandardOps)
 add_subdirectory(Test)
 add_subdirectory(Tosa)
+add_subdirectory(Vector)

mlir/test/lib/Dialect/DLTI/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRDLTITestPasses
+  TestDataLayoutQuery.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRDLTI
+  MLIRPass
+  MLIRTestDialect
+  )
+
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../Test)
+include_directories(${CMAKE_CURRENT_BINARY_DIR}/../Test)

mlir/test/lib/Dialect/GPU/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRGPUTestPasses
+  TestConvertGPUKernelToCubin.cpp
+  TestConvertGPUKernelToHsaco.cpp
+  TestGpuMemoryPromotion.cpp
+  TestGpuParallelLoopMapping.cpp
+  TestGpuRewrite.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRAffine
+  MLIRGPU
+  MLIRGPUToGPURuntimeTransforms
+  MLIRLLVMToLLVMIRTranslation
+  MLIRNVVMIR
+  MLIRNVVMToLLVMIRTranslation
+  MLIRPass
+  MLIRROCDLIR
+  MLIRROCDLToLLVMIRTranslation
+  MLIRSCF
+  MLIRStandard
+  MLIRTransformUtils
+  )

mlir/test/lib/Dialect/Linalg/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRLinalgTestPasses
+  TestConvVectorization.cpp
+  TestLinalgCodegenStrategy.cpp
+  TestLinalgElementwiseFusion.cpp
+  TestLinalgFusionTransforms.cpp
+  TestLinalgHoisting.cpp
+  TestLinalgTransforms.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRAffine
+  MLIRGPU
+  MLIRLinalg
+  MLIRLinalgTransforms
+  MLIRLLVMToLLVMIRTranslation
+  MLIRPass
+  MLIRStandard
+  MLIRTransformUtils
+  MLIRVector
+  MLIRVectorToSCF
+  )

mlir/test/lib/Dialect/Math/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRMathTestPasses
+  TestExpandTanh.cpp
+  TestPolynomialApproximation.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRMathTransforms
+  MLIRPass
+  MLIRTransformUtils
+  MLIRVector
+  )

mlir/test/lib/Dialect/SCF/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRSCFTestPasses
+  TestSCFUtils.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRPass
+  MLIRSCF
+  MLIRSCFTransforms
+  MLIRTransformUtils
+  )

mlir/test/lib/Dialect/StandardOps/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRStandardOpsTestPasses
+  TestDecomposeCallGraphTypes.cpp
+  TestComposeSubView.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRAffine
+  MLIRPass
+  MLIRStandardOpsTransforms
+  MLIRTestDialect
+  MLIRTransformUtils
+  )
+
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../Test)
+include_directories(${CMAKE_CURRENT_BINARY_DIR}/../Test)

mlir/test/lib/Dialect/Vector/CMakeLists.txt

+# Exclude tests from libMLIR.so
+add_mlir_library(MLIRVectorTestPasses
+  TestVectorTransforms.cpp
+
+  EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRAffine
+  MLIRAnalysis
+  MLIRLinalg
+  MLIRMemRef
+  MLIRPass
+  MLIRSCF
+  MLIRStandard
+  MLIRTransformUtils
+  MLIRVector
+  MLIRVectorToSCF
+  )

mlir/test/lib/IR/CMakeLists.txt

 # Exclude tests from libMLIR.so
 add_mlir_library(MLIRTestIR
+  TestDominance.cpp
   TestFunc.cpp
   TestInterfaces.cpp
   TestMatchers.cpp
+  TestOpaqueLoc.cpp
   TestPrintDefUse.cpp
   TestPrintNesting.cpp
   TestSideEffects.cpp
   TestSlicing.cpp
   TestSymbolUses.cpp
   TestTypes.cpp
   TestVisitors.cpp
 
   EXCLUDE_FROM_LIBMLIR
 
   LINK_LIBS PUBLIC
   MLIRPass
   MLIRTestDialect
   )
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../Dialect/Test)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../Dialect/Test)

mlir/test/lib/IR/TestOpaqueLoc.cpp

 //===- TestOpaqueLoc.cpp - Pass to test opaque locations ------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/Builders.h"
 #include "mlir/Pass/Pass.h"
 
 using namespace mlir;
 
 namespace {
 /// Pass that changes locations to opaque locations for each operation.
 /// It also takes all operations that are not function operations or

mlir/test/lib/Pass/CMakeLists.txt

 # Exclude tests from libMLIR.so
 add_mlir_library(MLIRTestPass
+  TestDynamicPipeline.cpp
   TestPassManager.cpp
 
   EXCLUDE_FROM_LIBMLIR
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Pass
 
   LINK_LIBS PUBLIC
   MLIRIR
   MLIRPass
   )

mlir/test/lib/Pass/TestDynamicPipeline.cpp

 //===------ TestDynamicPipeline.cpp --- dynamic pipeline test pass --------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements a pass to test the dynamic pipeline feature.
 //
 //===----------------------------------------------------------------------===//
 
-#include "mlir/Dialect/SCF/SCF.h"
-#include "mlir/IR/Builders.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Pass/PassManager.h"
-#include "mlir/Transforms/LoopUtils.h"
-#include "mlir/Transforms/Passes.h"
 
 using namespace mlir;
 
 namespace {
 
 class TestDynamicPipelinePass
     : public PassWrapper<TestDynamicPipelinePass, OperationPass<>> {
 public:

mlir/test/lib/Transforms/CMakeLists.txt

 # Exclude tests from libMLIR.so
 add_mlir_library(MLIRTestTransforms
-  TestAffineLoopParametricTiling.cpp
-  TestExpandTanh.cpp
-  TestCallGraph.cpp
-  TestDecomposeCallGraphTypes.cpp
   TestConstantFold.cpp
-  TestConvVectorization.cpp
-  TestConvertCallOp.cpp
-  TestConvertGPUKernelToCubin.cpp
-  TestConvertGPUKernelToHsaco.cpp
-  TestDataLayoutQuery.cpp
-  TestDominance.cpp
-  TestDynamicPipeline.cpp
-  TestComposeSubView.cpp
-  TestLoopFusion.cpp
-  TestGpuMemoryPromotion.cpp
-  TestGpuParallelLoopMapping.cpp
-  TestGpuRewrite.cpp
   TestInlining.cpp
-  TestLinalgCodegenStrategy.cpp
-  TestLinalgElementwiseFusion.cpp
-  TestLinalgFusionTransforms.cpp
-  TestLinalgHoisting.cpp
-  TestLinalgTransforms.cpp
-  TestLiveness.cpp
+  TestLoopFusion.cpp
   TestLoopMapping.cpp
   TestLoopParametricTiling.cpp
   TestLoopUnrolling.cpp
-  TestNumberOfExecutions.cpp
-  TestOpaqueLoc.cpp
-  TestPolynomialApproximation.cpp
-  TestMemRefBoundCheck.cpp
-  TestMemRefDependenceCheck.cpp
-  TestMemRefStrideCalculation.cpp
-  TestSCFUtils.cpp
-  TestVectorTransforms.cpp
 
   EXCLUDE_FROM_LIBMLIR
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms
 
-  DEPENDS
-  MLIRStandardOpsIncGen
-
   LINK_LIBS PUBLIC
-  MLIRAffine
-  MLIRAnalysis
-  MLIREDSC
-  MLIRGPU
-  MLIRGPU
-  MLIRGPUToGPURuntimeTransforms
-  MLIRLinalg
-  MLIRLinalgTransforms
-  MLIRLLVMToLLVMIRTranslation
-  MLIRMathTransforms
-  MLIRNVVMIR
-  MLIRNVVMToLLVMIRTranslation
-  MLIRPass
-  MLIRROCDLIR
-  MLIRROCDLToLLVMIRTranslation
-  MLIRSCF
-  MLIRSCFTransforms
-  MLIRStandardOpsTransforms
-  MLIRSparseTensor
-  MLIRSparseTensorTransforms
-  MLIRTargetLLVMIRExport
-  MLIRTestDialect
-  MLIRTransformUtils
-  MLIRVector
-  MLIRVectorToSCF
+  MLIRTransforms
   )
 
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../Dialect/Test)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../Dialect/Test)

mlir/test/lib/Transforms/TestConstantFold.cpp

 //===- TestConstantFold.cpp - Pass to test constant folding ---------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#include "mlir/Dialect/Affine/IR/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
-#include "mlir/IR/Builders.h"
-#include "mlir/IR/BuiltinOps.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Transforms/FoldUtils.h"
 #include "mlir/Transforms/Passes.h"
 #include "mlir/Transforms/Utils.h"
 
 using namespace mlir;
 
 namespace {

mlir/tools/mlir-opt/CMakeLists.txt

 set(LLVM_OPTIONAL_SOURCES
   null.cpp
 )
 
 get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
 get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
 set(LLVM_LINK_COMPONENTS
   Core
   Support
   AsmParser
   )
 
 if(MLIR_INCLUDE_TESTS)
   set(test_libs
+    MLIRTestStandardToLLVM
     MLIRAffineTransformsTestPasses
+    MLIRDLTITestPasses
+    MLIRGPUTestPasses
+    MLIRLinalgTestPasses
+    MLIRMathTestPasses
+    MLIRSCFTestPasses
     MLIRShapeTestPasses
     MLIRSPIRVTestPasses
+    MLIRStandardOpsTestPasses
+    MLIRVectorTestPasses
     MLIRTestAnalysis
     MLIRTestDialect
     MLIRTestIR
     MLIRTestPass
     MLIRTestReducer
     MLIRTestRewrite
     MLIRTestTransforms
     )