This is an archive of the discontinued LLVM Phabricator instance.

[clang][AArch32] Correctly align HA arguments when passed on the stack
ClosedPublic

Authored by chill on Apr 20 2021, 7:20 AM.

Details

Summary

Analogously to https://reviews.llvm.org/D98794 this patch uses the
alignstack attribute to fix incorrect passing of homogeneous
aggregate (HA) arguments on AArch32. The EABI/AAPCS was recently
updated to clarify how VFP co-processor candidates are aligned:
https://github.com/ARM-software/abi-aa/commit/4488e34998514dc7af5507236f279f6881eede62

Diff Detail

Unit TestsFailed

Event Timeline

chill created this revision.Apr 20 2021, 7:20 AM
chill requested review of this revision.Apr 20 2021, 7:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2021, 7:20 AM
chill updated this revision to Diff 340858.Apr 27 2021, 8:36 AM

Rebase/retested on top of main

rnk edited reviewers, added: aeubanks; removed: rnk.May 7 2021, 2:01 PM
rnk accepted this revision.May 7 2021, 2:03 PM
rnk edited reviewers, added: rnk; removed: aeubanks.

lgtm

Sorry about the delay.

This revision is now accepted and ready to land.May 7 2021, 2:04 PM
chill added a comment.May 10 2021, 5:49 AM

lgtm

Sorry about the delay.

Cheers, no worries!

This revision was landed with ongoing or failed builds.May 10 2021, 8:29 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2021, 8:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript