This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Salvage dbg.value() during ADCE

Authored by djtodoro on Apr 20 2021, 5:03 AM.

Diff Detail

Event Timeline

djtodoro created this revision.Apr 20 2021, 5:03 AM
djtodoro requested review of this revision.Apr 20 2021, 5:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2021, 5:03 AM

I think wait a short while in case anyone has any comments about the test (as a minor nitpick the "Function Attrs" comment could be removed for @llvm.dbg.value), but this LGTM.

dstenb added a subscriber: dstenb.Apr 20 2021, 6:26 AM

Looks good. Just a small nit about the test.


Perhaps hide the implementation details here, and just say "Check that adce salvages debug info properly"?

djtodoro updated this revision to Diff 339135.Apr 21 2021, 1:16 AM
  • Address comments for the test
StephenTozer accepted this revision.Apr 21 2021, 2:38 AM
This revision is now accepted and ready to land.Apr 21 2021, 2:38 AM
djtodoro closed this revision.May 21 2021, 5:49 AM