This is an archive of the discontinued LLVM Phabricator instance.

Differential D100658

[RISCV] Apply clang_builtin_alias to overloaded builtins.
ClosedPublic

Authored by HsiangKai on Apr 16 2021, 9:08 AM.

Details

Reviewers
craig.topper
frasercrmck
rogfer01
khchen
evandro
Commits
rGd8fa5ef6a297: [RISCV] Apply clang_builtin_alias to overloaded builtins.
Summary

We only apply clang_builtin_alias to non-masked builtins.
Masked builtins could not use clang_builtin_alias because the operand order is different between overloaded intrinsics and builtins.

A bunch of test cases need to be updated. I only update clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c for demonstration.

The total testing time for ./bin/llvm-lit -q ../../source/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/ reduced to 1m54.194s from 2m31.482s on my machine.

Diff Detail

Event Timeline

HsiangKai created this revision.Apr 16 2021, 9:08 AM
Herald added subscribers: StephenFan, vkmr, luismarques and 22 others. · View Herald TranscriptApr 16 2021, 9:08 AM
HsiangKai requested review of this revision.Apr 16 2021, 9:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2021, 9:08 AM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
HsiangKai added a parent revision: D100611: [Clang] Add clang attribute `clang_builtin_alias`..Apr 16 2021, 9:08 AM
HsiangKai edited the summary of this revision. (Show Details)Apr 16 2021, 9:11 AM
Harbormaster completed remote builds in B99200: Diff 338145.Apr 16 2021, 11:38 AM
khchen added a comment.Apr 17 2021, 5:53 AM

I think you also need to handle PermuteOperands field?
PermuteOperands performs the order permutation for non-masked and masked intrinsics when the operand order is different to builtins.

HsiangKai updated this revision to Diff 338349.Apr 17 2021, 6:34 PM

Consider PermuteOperands.

Harbormaster completed remote builds in B99355: Diff 338349.Apr 17 2021, 7:38 PM
khchen accepted this revision.Apr 18 2021, 1:39 AM

LGTM.

This revision is now accepted and ready to land.Apr 18 2021, 1:39 AM
HsiangKai updated this revision to Diff 339607.Apr 22 2021, 6:45 AM
HsiangKai retitled this revision from [RISCV] Apply __clang_riscv_builtin_alias to overloaded builtins. to [RISCV] Apply clang_builtin_alias to overloaded builtins..
HsiangKai edited the summary of this revision. (Show Details)

Apply `clang_builtin_alias`.

Harbormaster completed remote builds in B100255: Diff 339607.Apr 22 2021, 8:31 AM
This revision was landed with ongoing or failed builds.Apr 25 2021, 3:12 AM
Closed by commit rGd8fa5ef6a297: [RISCV] Apply clang_builtin_alias to overloaded builtins. (authored by HsiangKai). · Explain Why
This revision was automatically updated to reflect the committed changes.
HsiangKai added a commit: rGd8fa5ef6a297: [RISCV] Apply clang_builtin_alias to overloaded builtins..

Large Diff

This large diff affects 130 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
test/
CodeGen/
RISCV/
rvv-intrinsics-overloaded/
704 lines
352 lines
704 lines
560 lines
560 lines
560 lines
560 lines
560 lines
840 lines
560 lines
704 lines
704 lines
704 lines
144 lines
72 lines
432 lines
144 lines
56 lines
144 lines
144 lines
144 lines
36 lines
144 lines
144 lines
144 lines
144 lines
72 lines
416 lines
144 lines
144 lines
144 lines
144 lines
72 lines
72 lines
72 lines
72 lines
144 lines
72 lines
72 lines
432 lines
72 lines
72 lines
72 lines
144 lines
128 lines
304 lines
64 lines
64 lines
64 lines
64 lines
64 lines
80 lines
128 lines
88 lines
88 lines
212 lines
1528 lines
212 lines
1528 lines
704 lines
704 lines
704 lines
56 lines
704 lines
388 lines
144 lines
72 lines
72 lines
144 lines
144 lines
144 lines
704 lines
28 lines
28 lines
56 lines
704 lines
56 lines
704 lines
352 lines
56 lines
704 lines
704 lines
704 lines
56 lines
1760 lines
564 lines
28 lines
28 lines
480 lines
92 lines
704 lines
704 lines
180 lines
240 lines
240 lines
704 lines
56 lines
352 lines
352 lines
352 lines
352 lines
352 lines
352 lines
704 lines
1256 lines
352 lines
704 lines
352 lines
452 lines
224 lines
352 lines
352 lines
424 lines
424 lines
704 lines
352 lines
352 lines
352 lines
352 lines
352 lines
704 lines
704 lines
960 lines
840 lines
720 lines
288 lines
960 lines
704 lines
224 lines
utils/
TableGen/
31 lines

Diff 340347

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamomax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamomin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoswap.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoxor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vdiv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfclass.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfcvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfdiv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfirst.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmacc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmerge.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmsac.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfncvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfnmacc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfnmadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfnmsac.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfnmsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrdiv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrec7.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfredmax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfredmin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfredsum.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrsqrt7.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfsgnj.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfslide1down.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfslide1up.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfsqrt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwcvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwmacc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwmsac.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwnmacc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwnmsac.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwredsum.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vid.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/viota.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vle.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxei.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vlse.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxei.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmacc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmadc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmerge.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfeq.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfge.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfgt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfle.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmflt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfne.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmnand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmnor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsbc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsbf.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmseq.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsgt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsif.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsle.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmslt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsne.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsof.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmxnor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmxor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnclip.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vneg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnmsac.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnmsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnot.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnsra.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnsrl.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vpopc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vredand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vredmax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vredmin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vredor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vredsum.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vredxor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vrem.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vrgather.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vrsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsbc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vse.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsext.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vslide1down.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vslide1up.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vslidedown.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vslideup.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsll.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsra.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsrl.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssra.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssrl.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwmacc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwredsum.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vxor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vzext.c

clang/utils/TableGen/RISCVVEmitter.cpp