Page MenuHomePhabricator

[TTI] NFC: Change getArithmeticInstrCost to return InstructionCost
ClosedPublic

Authored by sdesmalen on Mon, Apr 12, 8:47 AM.

Details

Summary

This patch migrates the TTI cost interfaces to return an InstructionCost.

See this patch for the introduction of the type: https://reviews.llvm.org/D91174
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146408.html

Diff Detail

Event Timeline

sdesmalen created this revision.Mon, Apr 12, 8:47 AM
sdesmalen requested review of this revision.Mon, Apr 12, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Apr 12, 8:47 AM
dmgreen accepted this revision.Wed, Apr 14, 5:32 AM

Looks good

llvm/lib/Target/X86/X86TargetTransformInfo.cpp
3419–3421

I noticed this one, which can probably be removed now too?

This revision is now accepted and ready to land.Wed, Apr 14, 5:32 AM
sdesmalen updated this revision to Diff 337473.Wed, Apr 14, 8:44 AM
sdesmalen marked an inline comment as done.

Removed another case of .getValue()

llvm/lib/Target/X86/X86TargetTransformInfo.cpp
3419–3421

You're right, fixed it now!

This revision was landed with ongoing or failed builds.Wed, Apr 14, 9:34 AM
This revision was automatically updated to reflect the committed changes.