Page MenuHomePhabricator

[TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost
ClosedPublic

Authored by sdesmalen on Fri, Apr 9, 8:12 AM.

Details

Summary

This patch migrates the TTI cost interfaces to return an InstructionCost.

See this patch for the introduction of the type: https://reviews.llvm.org/D91174
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146408.html

Diff Detail

Event Timeline

sdesmalen created this revision.Fri, Apr 9, 8:12 AM
sdesmalen requested review of this revision.Fri, Apr 9, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Apr 9, 8:12 AM
sdesmalen updated this revision to Diff 336771.Mon, Apr 12, 1:21 AM

Merged patch with D100207

sdesmalen retitled this revision from [TTI] NFC: Change getMemoryOpCost to return InstructionCost to [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost.Mon, Apr 12, 1:22 AM
dmgreen accepted this revision.Mon, Apr 12, 7:45 AM

This LGTM too.

llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
1021

Is this going to be converted too? Hopefully it's pretty mechanical at this point, like these others.

This revision is now accepted and ready to land.Mon, Apr 12, 7:45 AM

Thanks for the review @dmgreen!

llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
1021

Yes, I have a bunch more patches that follow this one.

This revision was landed with ongoing or failed builds.Tue, Apr 13, 6:22 AM
This revision was automatically updated to reflect the committed changes.