We were missing some instruction costs when converting vectors of
floating point half types into integers. This patch adds more costs
to the table in getCastInstrCost and updates an existing test:
Analysis/CostModel/AArch64/sve-fptoi.ll
Paths
| Differential D99935
[AArch64] Add instruction costs for FP_TO_UINT and FP_TO_SINT with half types ClosedPublic Authored by david-arm on Apr 6 2021, 3:18 AM.
Details Summary We were missing some instruction costs when converting vectors of Analysis/CostModel/AArch64/sve-fptoi.ll
Diff Detail
Event TimelineHerald added subscribers: danielkiss, hiraditya, kristof.beyls. · View Herald TranscriptApr 6 2021, 3:18 AM Comment Actions
Comment Actions Hey @david-arm,
This revision is now accepted and ready to land.Apr 20 2021, 3:52 AM Comment Actions Thank you @david-arm. This revision was landed with ongoing or failed builds.Apr 21 2021, 1:40 AM Closed by commit rG57ca65e21e9a: [AArch64] Add instruction costs for FP_TO_UINT and FP_TO_SINT with half types (authored by david-arm). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 339137 llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
llvm/test/Analysis/CostModel/AArch64/sve-fptoi.ll
|
After private discussion with @sdesmalen it turns out we shouldn't need entries for illegal -> illegal types as they will both be split in the BasicTTIImpl::getCastInstrCost function.