Page MenuHomePhabricator

nasherm (Nashe Mncube)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2021, 6:34 AM (11 w, 3 d)

Recent Activity

Mar 29 2021

nasherm committed rG19601a4c6c48: [SVE][Analysis]Instruction costs for ops on scalable-vec (authored by nasherm).
[SVE][Analysis]Instruction costs for ops on scalable-vec
Mar 29 2021, 3:16 AM
nasherm closed D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.
Mar 29 2021, 3:16 AM · Restricted Project

Mar 26 2021

nasherm updated the diff for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.

Implemented Carol's suggestions.

Mar 26 2021, 7:26 AM · Restricted Project
nasherm updated the diff for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.

Response to David's cost comments, minor changes.

Mar 26 2021, 6:08 AM · Restricted Project
nasherm committed rGb723aa2a5ab2: [InstCombine]Generalise regression tests for sve (authored by nasherm).
[InstCombine]Generalise regression tests for sve
Mar 26 2021, 5:05 AM
nasherm closed D99253: [InstCombine]Generalise regression tests for sve.
Mar 26 2021, 5:05 AM · Restricted Project
nasherm added a reviewer for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors: CarolineConcatto.
Mar 26 2021, 4:53 AM · Restricted Project

Mar 24 2021

nasherm updated the summary of D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.
Mar 24 2021, 7:49 AM · Restricted Project
nasherm retitled D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors from [SVE] Add instruction cost for fptrunc in loops to [SVE][CostModel] Add instruction cost for operations on scalable vectors.
Mar 24 2021, 7:47 AM · Restricted Project
nasherm updated the diff for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.

Combined several patches which all deal with the same problem: instruction
costs for scalable vectors.

Mar 24 2021, 7:46 AM · Restricted Project
nasherm committed rGac2a1e959690: [SVE] Suppress vselect warning from incorrect interface call (authored by nasherm).
[SVE] Suppress vselect warning from incorrect interface call
Mar 24 2021, 7:35 AM
nasherm closed D98249: [SVE] Suppress vselect warning from incorrect interface call.
Mar 24 2021, 7:34 AM · Restricted Project
nasherm added a reviewer for D99253: [InstCombine]Generalise regression tests for sve: lebedev.ri.
Mar 24 2021, 4:02 AM · Restricted Project
nasherm requested review of D99253: [InstCombine]Generalise regression tests for sve.
Mar 24 2021, 4:01 AM · Restricted Project

Mar 23 2021

nasherm added inline comments to D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.
Mar 23 2021, 6:07 AM · Restricted Project
nasherm added inline comments to D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.
Mar 23 2021, 5:38 AM · Restricted Project
nasherm committed rG5d929794a876: [llvm-opt] Bug fix within combining FP vectors (authored by nasherm).
[llvm-opt] Bug fix within combining FP vectors
Mar 23 2021, 5:14 AM
nasherm closed D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.
Mar 23 2021, 5:14 AM · Restricted Project
nasherm updated the diff for D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.

Response to David's comments

Mar 23 2021, 5:06 AM · Restricted Project

Mar 22 2021

nasherm updated the diff for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.

Responded to David's comments to take into account half-precision
floats.

Mar 22 2021, 8:48 AM · Restricted Project

Mar 19 2021

nasherm updated the diff for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.

Remove lint

Mar 19 2021, 8:50 AM · Restricted Project
nasherm updated the diff for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.

Refactored regression test. Removed clang-format changes

Mar 19 2021, 8:48 AM · Restricted Project
nasherm updated the diff for D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.

Addressed Sander's comment on casting to FixedVectorType as well
as Carol's suggestion for regression test.

Mar 19 2021, 7:59 AM · Restricted Project
nasherm added inline comments to D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.
Mar 19 2021, 4:06 AM · Restricted Project
nasherm added reviewers for D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors: david-arm, sdesmalen.
Mar 19 2021, 2:43 AM · Restricted Project
nasherm requested review of D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors.
Mar 19 2021, 2:37 AM · Restricted Project
nasherm updated the diff for D98249: [SVE] Suppress vselect warning from incorrect interface call.

Removed changes to comments within ValueType.h

Mar 19 2021, 2:36 AM · Restricted Project

Mar 18 2021

nasherm updated the diff for D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.

In response to Sander and David's approach, I have
refactored the solution to use the simpler check
for splat vectors i.e. checking with constant
fpext expressions

Mar 18 2021, 9:55 AM · Restricted Project
nasherm updated the diff for D98249: [SVE] Suppress vselect warning from incorrect interface call.

Addressed Sander's comments regarding renaming and using <vselect x 16 x ty> types.

Mar 18 2021, 7:10 AM · Restricted Project

Mar 17 2021

nasherm added inline comments to D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.
Mar 17 2021, 5:52 AM · Restricted Project
nasherm updated the diff for D98249: [SVE] Suppress vselect warning from incorrect interface call.

Slight change to the checking call which triggers the warning. We now
check using the ElementCount interface.

Mar 17 2021, 3:32 AM · Restricted Project
nasherm updated the diff for D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.

Response to Carol and Sander's comments. I have gone for an
approach which implements an optimisation for the case
where we have a trunc op of the following form

Mar 17 2021, 3:00 AM · Restricted Project

Mar 10 2021

nasherm requested review of D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support.
Mar 10 2021, 7:25 AM · Restricted Project
nasherm updated the diff for D98249: [SVE] Suppress vselect warning from incorrect interface call.

Response to David's comments

Mar 10 2021, 7:24 AM · Restricted Project

Mar 9 2021

nasherm requested review of D98249: [SVE] Suppress vselect warning from incorrect interface call.
Mar 9 2021, 4:19 AM · Restricted Project

Mar 2 2021

nasherm added inline comments to D96546: [LoopVectorize] NFCI: BuildVPlansWithVPRecipes to include ScalableVFs..
Mar 2 2021, 3:04 AM · Restricted Project

Feb 22 2021

nasherm committed rG0327cfe2f762: [llvm-link] fix IRMover returning wrong modified vector type (authored by nasherm).
[llvm-link] fix IRMover returning wrong modified vector type
Feb 22 2021, 3:32 AM
nasherm closed D96953: [SVE] fix IRMover returning wrong modified vector type.
Feb 22 2021, 3:31 AM · Restricted Project

Feb 18 2021

nasherm updated the diff for D96953: [SVE] fix IRMover returning wrong modified vector type.

In response to Sander's comments.

Feb 18 2021, 8:53 AM · Restricted Project
nasherm updated the diff for D96953: [SVE] fix IRMover returning wrong modified vector type.

Addressing Sander's comments.

Feb 18 2021, 7:44 AM · Restricted Project
nasherm requested review of D96953: [SVE] fix IRMover returning wrong modified vector type.
Feb 18 2021, 5:40 AM · Restricted Project