This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Fix isel pattern of masked vmslt[u]
ClosedPublic

Authored by arcbbb on Mar 17 2021, 7:16 PM.

Details

Summary

This patch changes the operand order of masked vmslt[u]
from (mask, rs1, scalar, maskedoff, vl)
to (maskedoff, rs1, scalar, mask, vl).

Diff Detail

Event Timeline

arcbbb created this revision.Mar 17 2021, 7:16 PM
arcbbb requested review of this revision.Mar 17 2021, 7:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2021, 7:16 PM
craig.topper accepted this revision.Mar 17 2021, 7:57 PM

LGTM wish I knew how I messed that up cause it seems obviously wrong now that you've pointed it out. I've verified that the codegen is much more similar to the vmsle tests now.

This revision is now accepted and ready to land.Mar 17 2021, 7:57 PM
This revision was automatically updated to reflect the committed changes.