[M68k] Forward declare getMCInstrBeads in one place

[ricky26]

Summary

At the moment getMCInstrBeads is forward-declared in a few places,
bring this together into a single header file.

This was done as part of the disassembler work, since the disassembler
would otherwise add one more forward declaration.

[RKSimon]

llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp

30–31

Probably best to move this back to where it was?

[myhsu]

llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp

30–31

+1

[ricky26]

Moved inc file include back

[ricky26]

I've moved that #include back, my bad!

[RKSimon]

LGTM - @myhsu ?

[myhsu]

LGTM
BTW, @ricky26 I think you can consider applying for commit access. We don't have a concrete numbers on how many patches you should have before asking for that access, but since you already have some patches accepted and you're working on AsmParser and Disassembler which have non-trivial amount of work, I think that can be a good justification :-)
Please consult this page for how to obtain the access: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access (Yes, we're still using the old-school way on applying this). Optionally you can CC me when you send the email to Chris.

llvm/lib/Target/M68k/M68kInstrInfo.h

 #define GET_INSTRINFO_HEADER
 #include "M68kGenInstrInfo.inc"
 
 namespace llvm {
 
 class M68kSubtarget;
 
 namespace M68k {
-// Forward declaration
-const uint8_t *getMCInstrBeads(unsigned Opcode);
-
 // These MUST be kept in sync with codes definitions in M68kInstrInfo.td
 enum CondCode {
   COND_T = 0,   // True
   COND_F = 1,   // False
   COND_HI = 2,  // High
   COND_LS = 3,  // Less or Same
   COND_CC = 4,  // Carry Clear
   COND_CS = 5,  // Carry Set

llvm/lib/Target/M68k/M68kInstrInfo.cpp

 ///
 //===----------------------------------------------------------------------===//
 
 #include "M68kInstrInfo.h"
 
 #include "M68kInstrBuilder.h"
 #include "M68kMachineFunction.h"
 #include "M68kTargetMachine.h"
+#include "MCTargetDesc/M68kMCCodeEmitter.h"
 
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/ScopeExit.h"
 #include "llvm/CodeGen/LivePhysRegs.h"
 #include "llvm/CodeGen/LiveVariables.h"
 #include "llvm/CodeGen/MachineInstrBuilder.h"
 #include "llvm/CodeGen/MachineRegisterInfo.h"
 #include "llvm/Support/ErrorHandling.h"

llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.h

+//===-- M68kMCCodeEmitter.h - M68k Code Emitter ----------------*- C++ -*--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// \file
+/// This file contains the declarations for the code emitter which are useful
+/// outside of the emitter itself.
+///
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIB_TARGET_M68K_MCTARGETDESC_M68KMCCODEEMITTER_H
+#define LLVM_LIB_TARGET_M68K_MCTARGETDESC_M68KMCCODEEMITTER_H
+
+#include <cstdint>
+
+namespace llvm {
+namespace M68k {
+
+const uint8_t *getMCInstrBeads(unsigned);
+
+} // namespace M68k
+} // namespace llvm
+
+#endif

llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp

 //===-- M68kMCCodeEmitter.cpp - Convert M68k code emitter ---*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
 /// This file contains defintions for M68k code emitter.
 ///
 //===----------------------------------------------------------------------===//
 
+#include "MCTargetDesc/M68kMCCodeEmitter.h"
 #include "MCTargetDesc/M68kBaseInfo.h"
 #include "MCTargetDesc/M68kFixupKinds.h"
 #include "MCTargetDesc/M68kMCTargetDesc.h"
 
 #include "llvm/MC/MCCodeEmitter.h"
 #include "llvm/MC/MCContext.h"
 #include "llvm/MC/MCExpr.h"
 #include "llvm/MC/MCInst.h"
 #include "llvm/MC/MCInstrInfo.h"
 #include "llvm/MC/MCRegisterInfo.h"
 #include "llvm/MC/MCSubtargetInfo.h"
 #include "llvm/MC/MCSymbol.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/EndianStream.h"
 #include "llvm/Support/raw_ostream.h"
 
-namespace llvm {
-namespace M68k {
-// Forward declarations
-const uint8_t *getMCInstrBeads(unsigned);
-} // end namespace M68k
-} // end namespace llvm
-
 using namespace llvm;
 
 #define DEBUG_TYPE "m68k-mccodeemitter"
 
 namespace {
 class M68kMCCodeEmitter : public MCCodeEmitter {
   M68kMCCodeEmitter(const M68kMCCodeEmitter &) = delete;
   void operator=(const M68kMCCodeEmitter &) = delete;
   const MCInstrInfo &MCII;