Page MenuHomePhabricator

ricky26 (Ricky Taylor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2021, 4:00 AM (80 w, 2 d)

Recent Activity

May 18 2022

ricky26 accepted D125861: [M68k][Disassembler] Fix decoding conflict.

LGTM

May 18 2022, 5:21 AM · Restricted Project, Restricted Project
ricky26 added inline comments to D125861: [M68k][Disassembler] Fix decoding conflict.
May 18 2022, 2:46 AM · Restricted Project, Restricted Project

May 1 2022

ricky26 added a comment to D120958: [TableGen] Add support for variable length instruction in decoder generator.

It's taken me a very long time to find time to read though this patch (I'm very sorry about that). The approach seems nice and straight forward & the generated code looks good. Thanks a lot for finding the time to get this through. 😅

May 1 2022, 2:33 PM · Restricted Project, Restricted Project

Feb 15 2022

ricky26 accepted D119665: [M68k] Adopt VarLenCodeEmitter for control instructions.

LGTM. Might be worth waiting for @myhsu to review, but I don't think there's anything controversial. Thanks! 😄

Feb 15 2022, 5:52 AM · Restricted Project
ricky26 added inline comments to D119665: [M68k] Adopt VarLenCodeEmitter for control instructions.
Feb 15 2022, 5:01 AM · Restricted Project
ricky26 added a comment to D119665: [M68k] Adopt VarLenCodeEmitter for control instructions.

Thanks for this, I'm really enjoying the new syntax, it's so much easier to follow. I'm a little bit unsure about the test change.

Feb 15 2022, 3:53 AM · Restricted Project
ricky26 accepted D119101: [M68k][VarLenCodeEmitter] Support reloc & pc-rel immediate values.

LGTM. I had underestimated how complicated it would be to generate relocations, but this looks good.

Feb 15 2022, 2:36 AM · Restricted Project

Feb 14 2022

ricky26 accepted D119100: [TableGen] Add a new `encoder` directive into VarLenCodeEmitterGen.

This LGTM. I can't spot any code style issues and it should only affect the 68k for now. I like how it looks in the tablegen files. Nice work. :)

Feb 14 2022, 4:11 AM · Restricted Project

Jan 15 2022

ricky26 added a comment to D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.

Style is fine, tests run clean for me.

Jan 15 2022, 5:19 AM · Restricted Project

Dec 14 2021

ricky26 accepted D115234: [M68k] Adopt the new VarLenCodeEmitterGen for arithmetic instructions.

LGTM

Dec 14 2021, 2:08 AM · Restricted Project

Dec 11 2021

ricky26 accepted D115128: [TableGen][CodeEmitter] Introducing the VarLenCodeEmitterGen infrastructure.

LGTM. There's one comment that I think might be wrong. This is cool to see and I favour it much more than the existing code beads, IMO it's much more readable. Thanks! :)

Dec 11 2021, 4:48 PM · Restricted Project

Nov 9 2021

ricky26 added a comment to D111497: m68k: Support bit shifts on 64-bit integers.

I've been meaning to take a look since it shouldn't need much, but I've not gotten around to it yet.

Nov 9 2021, 3:26 PM · Restricted Project

Oct 25 2021

ricky26 added a comment to D111497: m68k: Support bit shifts on 64-bit integers.

I'm still getting test failures with this updated patch.

Oct 25 2021, 5:45 PM · Restricted Project

Oct 21 2021

ricky26 added a comment to D111497: m68k: Support bit shifts on 64-bit integers.

@AnnikaCodes, I'm seeing test failures from this patch. It looks like it's generating SETCC nodes which don't return i8 (which the M68k requires).

Oct 21 2021, 4:21 PM · Restricted Project
ricky26 added a comment to D111497: m68k: Support bit shifts on 64-bit integers.

I'm happy to. Are you ready for this to land @AnnikaCodes?

Oct 21 2021, 5:11 AM · Restricted Project

Sep 29 2021

ricky26 committed rGe1e3b6ee7297: [M68k] Avoid UB in disassembler (authored by ricky26).
[M68k] Avoid UB in disassembler
Sep 29 2021, 2:12 PM
ricky26 closed D110769: [M68k] Avoid UB in disassembler.
Sep 29 2021, 2:12 PM · Restricted Project
ricky26 requested review of D110769: [M68k] Avoid UB in disassembler.
Sep 29 2021, 1:18 PM · Restricted Project

Sep 17 2021

ricky26 added inline comments to D98540: [M68k] Implement Disassembler.
Sep 17 2021, 2:10 PM · Restricted Project

Aug 27 2021

ricky26 committed rG8d3f112f0cdb: [M68k] Update pointer data layout (authored by ricky26).
[M68k] Update pointer data layout
Aug 27 2021, 3:48 AM
ricky26 closed D108792: [M68k] Update pointer data layout.
Aug 27 2021, 3:48 AM · Restricted Project, Restricted Project

Aug 26 2021

ricky26 requested review of D108792: [M68k] Update pointer data layout.
Aug 26 2021, 3:16 PM · Restricted Project, Restricted Project
ricky26 added a comment to D108760: [M68k] Add parsing support for more operand types.

Fair enough, makes good sense. I was trying to chip away at things which didn't involve messing with the instruction definitions (since they feel a little up in the air still).

Aug 26 2021, 3:07 PM · Restricted Project
ricky26 added inline comments to D108760: [M68k] Add parsing support for more operand types.
Aug 26 2021, 6:02 AM · Restricted Project
ricky26 requested review of D108760: [M68k] Add parsing support for more operand types.
Aug 26 2021, 5:25 AM · Restricted Project

Aug 25 2021

ricky26 committed rGf659b6b1fa43: [M68k][NFC] Rename M68kOperand::Kind to KindTy (authored by ricky26).
[M68k][NFC] Rename M68kOperand::Kind to KindTy
Aug 25 2021, 2:25 PM
ricky26 closed D108723: [M68k][NFC] Rename M68kOperand::Kind to KindTy.
Aug 25 2021, 2:25 PM · Restricted Project
ricky26 updated the diff for D108723: [M68k][NFC] Rename M68kOperand::Kind to KindTy.

Make the commit title more precise.

Aug 25 2021, 2:21 PM · Restricted Project
ricky26 updated the diff for D108723: [M68k][NFC] Rename M68kOperand::Kind to KindTy.

Update the commit message.

Aug 25 2021, 1:36 PM · Restricted Project
ricky26 updated the diff for D108723: [M68k][NFC] Rename M68kOperand::Kind to KindTy.

Change over to using KindTy as the name of the enumeration.

Aug 25 2021, 1:18 PM · Restricted Project
ricky26 added a comment to D108723: [M68k][NFC] Rename M68kOperand::Kind to KindTy.

As suggested here [1] by @jrtc27, I think the better solution is to rename the enum Kind to KindTy.

[1] https://github.com/rust-lang/rust/pull/88321#discussion_r696043053

Edit: Rename because that would match the naming scheme also used by the RISCV AsmParser.

Aug 25 2021, 1:01 PM · Restricted Project
ricky26 updated subscribers of D108723: [M68k][NFC] Rename M68kOperand::Kind to KindTy.
Aug 25 2021, 12:54 PM · Restricted Project
ricky26 requested review of D108723: [M68k][NFC] Rename M68kOperand::Kind to KindTy.
Aug 25 2021, 12:53 PM · Restricted Project

Aug 24 2021

ricky26 committed rG47f52f989b06: [M68k][AsmParser] Support parsing register masks & fix printing them (authored by ricky26).
[M68k][AsmParser] Support parsing register masks & fix printing them
Aug 24 2021, 2:40 AM
ricky26 closed D108597: [M68k][AsmParser] Support parsing register masks & fix printing them.
Aug 24 2021, 2:40 AM · Restricted Project
ricky26 added a comment to D108597: [M68k][AsmParser] Support parsing register masks & fix printing them.

I just found that bits in the move mask will be inverted if the destination operand is predecrement mode address (i.e. -(An)). But we're not even supporting that addressing mode for MOVEM yet so I think it's fine for now.

Aug 24 2021, 2:06 AM · Restricted Project

Aug 23 2021

ricky26 requested review of D108597: [M68k][AsmParser] Support parsing register masks & fix printing them.
Aug 23 2021, 4:14 PM · Restricted Project

May 2 2021

ricky26 accepted D101733: [M68k][AsmParser] Fix invalid register name parsing logics.

LGTM

May 2 2021, 4:23 PM · Restricted Project
ricky26 added a comment to D101732: [M68k][AsmParser] Support negative integer constants.

Somehow my comment got trimmed (I think because a new diff appeared between me writing it and pressing submit).

May 2 2021, 3:19 PM · Restricted Project
ricky26 accepted D101732: [M68k][AsmParser] Support negative integer constants.

One nitpick, I don't believe it needs addressing but wanted to point it out anyway.

May 2 2021, 3:17 PM · Restricted Project
ricky26 added inline comments to D101733: [M68k][AsmParser] Fix invalid register name parsing logics.
May 2 2021, 3:12 PM · Restricted Project
ricky26 accepted D101410: [M68k][test] Initial migration of MC tests.

The relocation tests look a little messier than the others (were they generated from the old tests?) but it's pretty clear and more representative of what LLVM will output I guess.

May 2 2021, 3:04 PM · Restricted Project

Apr 19 2021

ricky26 committed rG2221185776c3: [M68k] Implement Disassembler (authored by ricky26).
[M68k] Implement Disassembler
Apr 19 2021, 2:29 PM
ricky26 committed rG6de262827c29: [M68k] Change printing of absolute memory references (authored by ricky26).
[M68k] Change printing of absolute memory references
Apr 19 2021, 2:29 PM
ricky26 closed D98540: [M68k] Implement Disassembler.
Apr 19 2021, 2:28 PM · Restricted Project
ricky26 closed D100697: [M68k] Change printing of absolute memory references.
Apr 19 2021, 2:28 PM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Fixup one missed instance of the "don't use braces" rule.

Apr 19 2021, 2:10 PM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Fixed up code style.

Apr 19 2021, 2:07 PM · Restricted Project

Apr 17 2021

ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Fix up the other switch statement that I somehow missed.

Apr 17 2021, 5:56 PM · Restricted Project
ricky26 added a comment to D98540: [M68k] Implement Disassembler.

First of all, good job :-)
Though I only scanned over the patch, I'm a little concerned about the adoption of code beads here because ideally, we are going to remove code beads from LLVM in the future.

Apr 17 2021, 3:45 AM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Shorten switch to a single assert.

Apr 17 2021, 3:44 AM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Apply review feedback.

Apr 17 2021, 3:25 AM · Restricted Project
ricky26 requested review of D100697: [M68k] Change printing of absolute memory references.
Apr 17 2021, 3:24 AM · Restricted Project

Apr 14 2021

ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Add loop changes missed from previous diff.

Apr 14 2021, 6:29 AM · Restricted Project
ricky26 added a reviewer for D98540: [M68k] Implement Disassembler: RKSimon.

I think this is now ready for review proper.

Apr 14 2021, 6:21 AM · Restricted Project
ricky26 retitled D98540: [M68k] Implement Disassembler from WIP: [M68k] Implement Disassembler to [M68k] Implement Disassembler.
Apr 14 2021, 6:17 AM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Improve code style, add encoding tests to instructions.s.

Apr 14 2021, 6:17 AM · Restricted Project

Apr 13 2021

ricky26 committed rG6e098e133dc7: [M68k] Implement AsmParser (authored by ricky26).
[M68k] Implement AsmParser
Apr 13 2021, 1:30 AM
ricky26 closed D98537: [M68k] Implement AsmParser.
Apr 13 2021, 1:30 AM · Restricted Project

Apr 12 2021

ricky26 added a comment to D98537: [M68k] Implement AsmParser.

@myhsu when you get a moment, can you check that this is all OK now? :)

Apr 12 2021, 4:43 AM · Restricted Project

Apr 6 2021

ricky26 added a comment to D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..

It looks like this adds support for X86 identifiers starting with $ (I'm actually surprised this wasn't allowed before).

Well. Yes and no. If you take a look at the parseIdentifier routine in AsmParser.cpp...

Right, that makes sense!

An argument could be made that the parseIdentifier routine could be modified or overridden wherever appropriate and given custom logic.

The benefit being that target AsmParsers have the opportunity to parse the starting symbol as something else. The drawback being that stitching everything back together is more complicated (looking at the code, I'm not convinced that it'd parse $$ as an identifier, for example).

Apr 6 2021, 1:54 PM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Use assembly comments in the assembly test rather than C++ comments

Apr 6 2021, 11:43 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.
  • Hide private implementation details of M68kAsmParser
  • Remove superfluous FileCheck parameter from test
  • Add migration notice to test
Apr 6 2021, 11:29 AM · Restricted Project

Apr 5 2021

ricky26 added a comment to D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..

I'm new to reviewing code here, so call me out if I mess up the etiquette. :)

Apr 5 2021, 4:19 PM · Restricted Project
ricky26 added a comment to D98537: [M68k] Implement AsmParser.

Thanks for this amazing efforts :-) I only have minor formatting comments inlined in the code.
I do have a more high-level question: It seems that you only support Motorola syntax right now, is that true? I'm totally fine if you don't add the MIT syntax in this patch, just want to make sure.
Now a bigger issue is the testing: Presumably we should rewrite all of our existing tests under test/CodeGen/M68k/Encoding into assembly and put it under test/MC/M68k. I believe this can give us a better testing coverage on all of our MC components including AsmParser.
On one hand I don't want to put those migrating changes into this patch because it will easily bloat the size. Not to mention those tests contains binary encoding tests, so if we need migrate both kinds of tests at once. On the other hand, I still need to make sure this patch reaches certain test coverage. Fortunately, the test you provided seemed to cover cases in each instruction classes. Can you add a comment in that test file to note our tests migration plan?

Apr 5 2021, 2:53 PM · Restricted Project
ricky26 committed rG4db18d62afa8: [M68k] Add support for Motorola literal syntax to AsmParser (authored by ricky26).
[M68k] Add support for Motorola literal syntax to AsmParser
Apr 5 2021, 12:03 PM
ricky26 closed D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Apr 5 2021, 12:02 PM · Restricted Project

Apr 4 2021

ricky26 added inline comments to D98537: [M68k] Implement AsmParser.
Apr 4 2021, 4:07 PM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Rebase onto changed AsmLexer patch

Apr 4 2021, 4:06 PM · Restricted Project

Apr 2 2021

ricky26 updated the diff for D98519: [M68k] Add support for Motorola literal syntax to AsmParser.

Pulled the use of UseMotorolaIntegers back into this patch.

Apr 2 2021, 5:15 PM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Rebased, fixed some bugs & added some tests.

Apr 2 2021, 5:08 PM · Restricted Project
ricky26 added inline comments to D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Apr 2 2021, 10:37 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Remove header to appease clang-tidy

Apr 2 2021, 7:55 AM · Restricted Project
ricky26 updated the diff for D98519: [M68k] Add support for Motorola literal syntax to AsmParser.

Apply review feedback, add some tests and a flag for llvm-mc.

Apr 2 2021, 7:17 AM · Restricted Project
ricky26 added reviewers for D98519: [M68k] Add support for Motorola literal syntax to AsmParser: epastor, anirudhp, scott.linder, myhsu.
Apr 2 2021, 6:02 AM · Restricted Project
ricky26 updated the summary of D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Apr 2 2021, 6:02 AM · Restricted Project
ricky26 published D98519: [M68k] Add support for Motorola literal syntax to AsmParser for review.
Apr 2 2021, 5:52 AM · Restricted Project
ricky26 added a comment to D98537: [M68k] Implement AsmParser.

I've added a test (it uses many of the instructions which are defined with both Motorola & MIT operand syntax) and tidied everything up.

Apr 2 2021, 5:33 AM · Restricted Project
ricky26 retitled D98537: [M68k] Implement AsmParser from WIP: [M68k] Implement AsmParser to [M68k] Implement AsmParser.
Apr 2 2021, 5:27 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Rebase onto latest main

Apr 2 2021, 5:23 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Reworked parsing and added the first test

Apr 2 2021, 5:04 AM · Restricted Project

Mar 31 2021

ricky26 added a comment to D98537: [M68k] Implement AsmParser.

Are there any differences in how the input/output/clobber operands in a possible inline asm statement that is parsed, or do they follow the standard GNU asm format with just platform specific syntactical differences in the assembler text?

Mar 31 2021, 12:56 AM · Restricted Project

Mar 19 2021

ricky26 committed rG028d6250eac5: [M68k] Replace unknown operand with explicit type (authored by ricky26).
[M68k] Replace unknown operand with explicit type
Mar 19 2021, 6:45 AM
ricky26 closed D98819: [M68k] Replace unknown operand with explicit type.
Mar 19 2021, 6:45 AM · Restricted Project
ricky26 updated the diff for D98819: [M68k] Replace unknown operand with explicit type.

Made as_imm16 comment more generic

Mar 19 2021, 6:44 AM · Restricted Project
ricky26 committed rGcd442157cff4: [M68k] Convert register Aliases to AltNames (authored by ricky26).
[M68k] Convert register Aliases to AltNames
Mar 19 2021, 4:45 AM
ricky26 committed rG51884c6beff7: [M68k] Introduce DReg bead (authored by ricky26).
[M68k] Introduce DReg bead
Mar 19 2021, 4:45 AM
ricky26 closed D98536: [M68k] Convert register Aliases to AltNames.
Mar 19 2021, 4:45 AM · Restricted Project
ricky26 closed D98534: [M68k] Introduce DReg bead.
Mar 19 2021, 4:45 AM · Restricted Project

Mar 18 2021

ricky26 committed rG6dad34454d41: Test commit (authored by ricky26).
Test commit
Mar 18 2021, 9:29 AM

Mar 17 2021

ricky26 published D98540: [M68k] Implement Disassembler for review.

I've marked this 'Ready for Review' since otherwise notifications don't happen. To be clear though, this is not ready to merge.

Mar 17 2021, 4:49 PM · Restricted Project
ricky26 published D98537: [M68k] Implement AsmParser for review.

I've marked this 'Ready for Review' since otherwise notifications don't happen. To be clear though, this is not ready to merge.

Mar 17 2021, 4:47 PM · Restricted Project
ricky26 requested review of D98819: [M68k] Replace unknown operand with explicit type.
Mar 17 2021, 2:54 PM · Restricted Project
ricky26 updated the diff for D98534: [M68k] Introduce DReg bead.

Fix one superfluous DReg: the rr arithmetic includes the DA bit for the operand already.

Mar 17 2021, 2:50 PM · Restricted Project
ricky26 updated the diff for D98534: [M68k] Introduce DReg bead.

Remove operand type changes. (These will appear in another differential shortly.)

Mar 17 2021, 2:36 PM · Restricted Project
ricky26 added a comment to D98536: [M68k] Convert register Aliases to AltNames.

Yep, converted those back into sequences. Thanks.

Mar 17 2021, 2:13 PM · Restricted Project
ricky26 updated the diff for D98536: [M68k] Convert register Aliases to AltNames.

Change explicit register lists back into sequences where possible.

Mar 17 2021, 2:11 PM · Restricted Project

Mar 16 2021

ricky26 updated the diff for D98536: [M68k] Convert register Aliases to AltNames.

Use Register second parameter instead of an extra 'let'

Mar 16 2021, 1:33 PM · Restricted Project
ricky26 added a comment to D98536: [M68k] Convert register Aliases to AltNames.

Are you trying to distinguish the sub-register use cases from alternative naming (e.g. a5 & bp)?

Mar 16 2021, 1:25 PM · Restricted Project
ricky26 added a comment to D98535: [M68k] Add more specific operand classes.

I don't have commit access, so if someone could land this for me, I'd appreciate it! :)

Mar 16 2021, 1:14 PM · Restricted Project