Page MenuHomePhabricator

ricky26 (Ricky Taylor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2021, 4:00 AM (11 w, 4 d)

Recent Activity

Today

ricky26 committed rG2221185776c3: [M68k] Implement Disassembler (authored by ricky26).
[M68k] Implement Disassembler
Mon, Apr 19, 2:29 PM
ricky26 committed rG6de262827c29: [M68k] Change printing of absolute memory references (authored by ricky26).
[M68k] Change printing of absolute memory references
Mon, Apr 19, 2:29 PM
ricky26 closed D98540: [M68k] Implement Disassembler.
Mon, Apr 19, 2:28 PM · Restricted Project
ricky26 closed D100697: [M68k] Change printing of absolute memory references.
Mon, Apr 19, 2:28 PM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Fixup one missed instance of the "don't use braces" rule.

Mon, Apr 19, 2:10 PM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Fixed up code style.

Mon, Apr 19, 2:07 PM · Restricted Project

Sat, Apr 17

ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Fix up the other switch statement that I somehow missed.

Sat, Apr 17, 5:56 PM · Restricted Project
ricky26 added a comment to D98540: [M68k] Implement Disassembler.

First of all, good job :-)
Though I only scanned over the patch, I'm a little concerned about the adoption of code beads here because ideally, we are going to remove code beads from LLVM in the future.

Sat, Apr 17, 3:45 AM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Shorten switch to a single assert.

Sat, Apr 17, 3:44 AM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Apply review feedback.

Sat, Apr 17, 3:25 AM · Restricted Project
ricky26 requested review of D100697: [M68k] Change printing of absolute memory references.
Sat, Apr 17, 3:24 AM · Restricted Project

Wed, Apr 14

ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Add loop changes missed from previous diff.

Wed, Apr 14, 6:29 AM · Restricted Project
ricky26 added a reviewer for D98540: [M68k] Implement Disassembler: RKSimon.

I think this is now ready for review proper.

Wed, Apr 14, 6:21 AM · Restricted Project
ricky26 retitled D98540: [M68k] Implement Disassembler from WIP: [M68k] Implement Disassembler to [M68k] Implement Disassembler.
Wed, Apr 14, 6:17 AM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Improve code style, add encoding tests to instructions.s.

Wed, Apr 14, 6:17 AM · Restricted Project

Tue, Apr 13

ricky26 committed rG6e098e133dc7: [M68k] Implement AsmParser (authored by ricky26).
[M68k] Implement AsmParser
Tue, Apr 13, 1:30 AM
ricky26 closed D98537: [M68k] Implement AsmParser.
Tue, Apr 13, 1:30 AM · Restricted Project

Mon, Apr 12

ricky26 added a comment to D98537: [M68k] Implement AsmParser.

@myhsu when you get a moment, can you check that this is all OK now? :)

Mon, Apr 12, 4:43 AM · Restricted Project

Tue, Apr 6

ricky26 added a comment to D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..

It looks like this adds support for X86 identifiers starting with $ (I'm actually surprised this wasn't allowed before).

Well. Yes and no. If you take a look at the parseIdentifier routine in AsmParser.cpp...

Right, that makes sense!

An argument could be made that the parseIdentifier routine could be modified or overridden wherever appropriate and given custom logic.

The benefit being that target AsmParsers have the opportunity to parse the starting symbol as something else. The drawback being that stitching everything back together is more complicated (looking at the code, I'm not convinced that it'd parse $$ as an identifier, for example).

Tue, Apr 6, 1:54 PM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Use assembly comments in the assembly test rather than C++ comments

Tue, Apr 6, 11:43 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.
  • Hide private implementation details of M68kAsmParser
  • Remove superfluous FileCheck parameter from test
  • Add migration notice to test
Tue, Apr 6, 11:29 AM · Restricted Project

Mon, Apr 5

ricky26 added a comment to D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..

I'm new to reviewing code here, so call me out if I mess up the etiquette. :)

Mon, Apr 5, 4:19 PM · Restricted Project
ricky26 added a comment to D98537: [M68k] Implement AsmParser.

Thanks for this amazing efforts :-) I only have minor formatting comments inlined in the code.
I do have a more high-level question: It seems that you only support Motorola syntax right now, is that true? I'm totally fine if you don't add the MIT syntax in this patch, just want to make sure.
Now a bigger issue is the testing: Presumably we should rewrite all of our existing tests under test/CodeGen/M68k/Encoding into assembly and put it under test/MC/M68k. I believe this can give us a better testing coverage on all of our MC components including AsmParser.
On one hand I don't want to put those migrating changes into this patch because it will easily bloat the size. Not to mention those tests contains binary encoding tests, so if we need migrate both kinds of tests at once. On the other hand, I still need to make sure this patch reaches certain test coverage. Fortunately, the test you provided seemed to cover cases in each instruction classes. Can you add a comment in that test file to note our tests migration plan?

Mon, Apr 5, 2:53 PM · Restricted Project
ricky26 committed rG4db18d62afa8: [M68k] Add support for Motorola literal syntax to AsmParser (authored by ricky26).
[M68k] Add support for Motorola literal syntax to AsmParser
Mon, Apr 5, 12:03 PM
ricky26 closed D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Mon, Apr 5, 12:02 PM · Restricted Project

Sun, Apr 4

ricky26 added inline comments to D98537: [M68k] Implement AsmParser.
Sun, Apr 4, 4:07 PM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Rebase onto changed AsmLexer patch

Sun, Apr 4, 4:06 PM · Restricted Project

Fri, Apr 2

ricky26 updated the diff for D98519: [M68k] Add support for Motorola literal syntax to AsmParser.

Pulled the use of UseMotorolaIntegers back into this patch.

Fri, Apr 2, 5:15 PM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Rebased, fixed some bugs & added some tests.

Fri, Apr 2, 5:08 PM · Restricted Project
ricky26 added inline comments to D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Fri, Apr 2, 10:37 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Remove header to appease clang-tidy

Fri, Apr 2, 7:55 AM · Restricted Project
ricky26 updated the diff for D98519: [M68k] Add support for Motorola literal syntax to AsmParser.

Apply review feedback, add some tests and a flag for llvm-mc.

Fri, Apr 2, 7:17 AM · Restricted Project
ricky26 added reviewers for D98519: [M68k] Add support for Motorola literal syntax to AsmParser: epastor, anirudhp, scott.linder, myhsu.
Fri, Apr 2, 6:02 AM · Restricted Project
ricky26 updated the summary of D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Fri, Apr 2, 6:02 AM · Restricted Project
ricky26 published D98519: [M68k] Add support for Motorola literal syntax to AsmParser for review.
Fri, Apr 2, 5:52 AM · Restricted Project
ricky26 added a comment to D98537: [M68k] Implement AsmParser.

I've added a test (it uses many of the instructions which are defined with both Motorola & MIT operand syntax) and tidied everything up.

Fri, Apr 2, 5:33 AM · Restricted Project
ricky26 retitled D98537: [M68k] Implement AsmParser from WIP: [M68k] Implement AsmParser to [M68k] Implement AsmParser.
Fri, Apr 2, 5:27 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Rebase onto latest main

Fri, Apr 2, 5:23 AM · Restricted Project
ricky26 updated the diff for D98537: [M68k] Implement AsmParser.

Reworked parsing and added the first test

Fri, Apr 2, 5:04 AM · Restricted Project

Wed, Mar 31

ricky26 added a comment to D98537: [M68k] Implement AsmParser.

Are there any differences in how the input/output/clobber operands in a possible inline asm statement that is parsed, or do they follow the standard GNU asm format with just platform specific syntactical differences in the assembler text?

Wed, Mar 31, 12:56 AM · Restricted Project

Mar 19 2021

ricky26 committed rG028d6250eac5: [M68k] Replace unknown operand with explicit type (authored by ricky26).
[M68k] Replace unknown operand with explicit type
Mar 19 2021, 6:45 AM
ricky26 closed D98819: [M68k] Replace unknown operand with explicit type.
Mar 19 2021, 6:45 AM · Restricted Project
ricky26 updated the diff for D98819: [M68k] Replace unknown operand with explicit type.

Made as_imm16 comment more generic

Mar 19 2021, 6:44 AM · Restricted Project
ricky26 committed rGcd442157cff4: [M68k] Convert register Aliases to AltNames (authored by ricky26).
[M68k] Convert register Aliases to AltNames
Mar 19 2021, 4:45 AM
ricky26 committed rG51884c6beff7: [M68k] Introduce DReg bead (authored by ricky26).
[M68k] Introduce DReg bead
Mar 19 2021, 4:45 AM
ricky26 closed D98536: [M68k] Convert register Aliases to AltNames.
Mar 19 2021, 4:45 AM · Restricted Project
ricky26 closed D98534: [M68k] Introduce DReg bead.
Mar 19 2021, 4:45 AM · Restricted Project

Mar 18 2021

ricky26 committed rG6dad34454d41: Test commit (authored by ricky26).
Test commit
Mar 18 2021, 9:29 AM

Mar 17 2021

ricky26 published D98540: [M68k] Implement Disassembler for review.

I've marked this 'Ready for Review' since otherwise notifications don't happen. To be clear though, this is not ready to merge.

Mar 17 2021, 4:49 PM · Restricted Project
ricky26 published D98537: [M68k] Implement AsmParser for review.

I've marked this 'Ready for Review' since otherwise notifications don't happen. To be clear though, this is not ready to merge.

Mar 17 2021, 4:47 PM · Restricted Project
ricky26 requested review of D98819: [M68k] Replace unknown operand with explicit type.
Mar 17 2021, 2:54 PM · Restricted Project
ricky26 updated the diff for D98534: [M68k] Introduce DReg bead.

Fix one superfluous DReg: the rr arithmetic includes the DA bit for the operand already.

Mar 17 2021, 2:50 PM · Restricted Project
ricky26 updated the diff for D98534: [M68k] Introduce DReg bead.

Remove operand type changes. (These will appear in another differential shortly.)

Mar 17 2021, 2:36 PM · Restricted Project
ricky26 added a comment to D98536: [M68k] Convert register Aliases to AltNames.

Yep, converted those back into sequences. Thanks.

Mar 17 2021, 2:13 PM · Restricted Project
ricky26 updated the diff for D98536: [M68k] Convert register Aliases to AltNames.

Change explicit register lists back into sequences where possible.

Mar 17 2021, 2:11 PM · Restricted Project

Mar 16 2021

ricky26 updated the diff for D98536: [M68k] Convert register Aliases to AltNames.

Use Register second parameter instead of an extra 'let'

Mar 16 2021, 1:33 PM · Restricted Project
ricky26 added a comment to D98536: [M68k] Convert register Aliases to AltNames.

Are you trying to distinguish the sub-register use cases from alternative naming (e.g. a5 & bp)?

Mar 16 2021, 1:25 PM · Restricted Project
ricky26 added a comment to D98535: [M68k] Add more specific operand classes.

I don't have commit access, so if someone could land this for me, I'd appreciate it! :)

Mar 16 2021, 1:14 PM · Restricted Project
ricky26 added a comment to D98534: [M68k] Introduce DReg bead.

It acts like a default when decoding (in one of the later patches). The DA bead is still needed since it's used for instructions where it can be either an address or data register.

Mar 16 2021, 1:07 PM · Restricted Project
ricky26 added a comment to D98533: [M68k] Forward declare getMCInstrBeads in one place.

I've moved that #include back, my bad!

Mar 16 2021, 1:01 PM · Restricted Project
ricky26 updated the diff for D98533: [M68k] Forward declare getMCInstrBeads in one place.

Moved inc file include back

Mar 16 2021, 12:59 PM · Restricted Project

Mar 12 2021

ricky26 updated the diff for D98535: [M68k] Add more specific operand classes.

Move the operand parser declarations back to this patch

Mar 12 2021, 4:04 PM · Restricted Project
ricky26 added inline comments to D98517: [M68k] Make M68k TargetMachine use getter function.
Mar 12 2021, 1:37 PM · Restricted Project
ricky26 updated the diff for D98517: [M68k] Make M68k TargetMachine use getter function.

Remove unecessary ../ from include

Mar 12 2021, 1:35 PM · Restricted Project
ricky26 updated the diff for D98527: [M68k] Tidy up some bit shifting during code emission.

Fixed implicit 32-bit shifts (they are now explicitly 64-bits)

Mar 12 2021, 1:25 PM · Restricted Project
ricky26 added inline comments to D98535: [M68k] Add more specific operand classes.
Mar 12 2021, 1:22 PM · Restricted Project
ricky26 published D98532: [M68k] Use fixed asm string for MxPseudo instructions for review.
Mar 12 2021, 12:32 PM · Restricted Project
ricky26 published D98534: [M68k] Introduce DReg bead for review.
Mar 12 2021, 12:32 PM · Restricted Project
ricky26 published D98536: [M68k] Convert register Aliases to AltNames for review.
Mar 12 2021, 12:29 PM · Restricted Project
ricky26 published D98535: [M68k] Add more specific operand classes for review.

@myhsu I've put together this stack for my assembler/disassembler implementation. I'd very much appreciate any help finding other appropriate reviewers!

Mar 12 2021, 12:19 PM · Restricted Project
ricky26 published D98533: [M68k] Forward declare getMCInstrBeads in one place for review.
Mar 12 2021, 11:57 AM · Restricted Project
ricky26 requested review of D98527: [M68k] Tidy up some bit shifting during code emission.
Mar 12 2021, 9:43 AM · Restricted Project
ricky26 updated the diff for D98517: [M68k] Make M68k TargetMachine use getter function.

Appease clang-tidy

Mar 12 2021, 9:36 AM · Restricted Project
ricky26 published D98517: [M68k] Make M68k TargetMachine use getter function for review.
Mar 12 2021, 9:07 AM · Restricted Project

Mar 11 2021

ricky26 added a comment to D98428: [M68k] Fix extract-section.py under Python 3.

I do not, please commit this @myhsu! :)

Mar 11 2021, 10:30 AM · Restricted Project
ricky26 requested review of D98428: [M68k] Fix extract-section.py under Python 3.
Mar 11 2021, 8:00 AM · Restricted Project