The three bit nf is one less than the number of NFIELDS,
so we manually decrement 1 for VS1/2/4/8R & VL1/2/4/8R.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Heh, coincidentally, I created D98180 an hour or so ago. Looks like I might have read the spec incorrectly. The wording's a little odd to me.
Comment Actions
Oops, sorry I didn't notice your patch, otherwise I would reply in yours instead. I just happened to encounter this runtime bug today.
Comment Actions
No worries, it's my fault for not including you (I usually do). I think you're right, anyway: I only tested cases 1 and 2 before submitting my patch. Shame on me.
Comment Actions
LGTM. Does this need to be merged to LLVM 12? If so please file a bugzilla.
llvm/lib/Target/RISCV/RISCVInstrInfoV.td | ||
---|---|---|
514 | Feels like tablegen should have maybe warned about the int being truncated to 3 bits. @Paul-C-Anagnostopoulos? |
Feels like tablegen should have maybe warned about the int being truncated to 3 bits. @Paul-C-Anagnostopoulos?