This is already deprecated, so remove code working on this.
Also update the tests by using S_CBRANCH_EXECZ instead of SI_MASK_BRANCH.
The tests to specifically test the insert-skip feature are not valid
anymore, so just remove them.
Details
Details
- Reviewers
arsenm cdevadas foad - Commits
- rGf0ccdde3c9ab: [AMDGPU] Remove SI_MASK_BRANCH
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/SIInsertSkips.cpp | ||
---|---|---|
213 | If SIInsertSkips is no longer inserting skips, it needs a new name |
Comment Actions
I find it is not a good idea to remove the tests. So I adjust the lit-test to make sure RemoveShortExecBranches works correctly.
llvm/lib/Target/AMDGPU/SIInsertSkips.cpp | ||
---|---|---|
213 | I don't have good idea on that. I am happy if some one could came up with a good name. And I believe that should be in a separate patch. This patch just aims to remove "SI_MASK_BRANCH". |
Comment Actions
I agree with renaming being a follow up patch.
I wonder if this entire pass could be merged with SIRemoveShortExecBranches and the result renamed SILateBranchLowering?
If SIInsertSkips is no longer inserting skips, it needs a new name