This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Simplify ModuleTranslation for LLVM IR
ClosedPublic

Authored by ftynse on Feb 16 2021, 5:34 AM.

Details

Summary

A series of preceding patches changed the mechanism for translating MLIR to
LLVM IR to use dialect interface with delayed registration. It is no longer
necessary for specific dialects to derive from ModuleTranslation. Remove all
virtual methods from ModuleTranslation and factor out the entry point to be a
free function.

Also perform some cleanups in ModuleTranslation internals.

Depends On D96774

Diff Detail

Event Timeline

ftynse created this revision.Feb 16 2021, 5:34 AM
ftynse requested review of this revision.Feb 16 2021, 5:34 AM
Herald added a reviewer: herhut. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache accepted this revision.Feb 16 2021, 8:39 AM
This revision is now accepted and ready to land.Feb 16 2021, 8:39 AM
This revision was landed with ongoing or failed builds.Feb 16 2021, 9:43 AM
This revision was automatically updated to reflect the committed changes.