This is an archive of the discontinued LLVM Phabricator instance.

[llvm/Support] Add SHA256 implementation
ClosedPublic

Authored by cynecx on Feb 11 2021, 1:19 PM.

Details

Summary

Adds an *unaudited* SHA-256 implementation to llvm/Support. The ongoing lld-macho effort needs this to emit an adhoc code signature for macho files on macOS Big Sur.

Diff Detail

Event Timeline

cynecx created this revision.Feb 11 2021, 1:19 PM
cynecx requested review of this revision.Feb 11 2021, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 1:19 PM
smeenai added a subscriber: smeenai.

Adding some reviewers who've contributed to the SHA1 implementation.

This revision is now accepted and ready to land.Feb 11 2021, 2:24 PM

@mehdi_amini Thanks for the review. I don't have commit rights. I'd be great if someone could commit this!

I'll wait a couple of days to see if anyone has a concern with this, ping me on Monday if I forget :)

Can you also add the motivation in the description? What are you planning to use this for?

I'll wait a couple of days to see if anyone has a concern with this, ping me on Monday if I forget :)

Will do :)

Can you also add the motivation in the description? What are you planning to use this for?

SHA-256 hashing is required for https://reviews.llvm.org/D96164 (lld needs this to emit an adhoc code signature for macho files on macOS Big Sur).

cynecx edited the summary of this revision. (Show Details)Feb 12 2021, 10:36 AM
cynecx edited the summary of this revision. (Show Details)Feb 14 2021, 9:28 AM

What do you want for author information? Right now I have "cynecx <me@cynecx.net>"

@mehdi_amini That's alright. Thank You!

This revision was landed with ongoing or failed builds.Feb 14 2021, 11:23 AM
This revision was automatically updated to reflect the committed changes.